dash klibc DEBUG more compile trouble

dash klibc DEBUG more compile trouble

[maximilian attems]

once taken that stat/stat64 appart, histedit appears to be a minefield:

usr/dash/histedit.c:59: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
usr/dash/histedit.c:60: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘*’ token
usr/dash/histedit.c: In function ‘histedit’:
usr/dash/histedit.c:82: error: ‘hist’ undeclared (first use in this function)
usr/dash/histedit.c:82: error: (Each undeclared identifier is reported only once
usr/dash/histedit.c:82: error: for each function it appears in.)
usr/dash/histedit.c:87: warning: implicit declaration of function ‘history_init’
usr/dash/histedit.c:95: error: ‘el’ undeclared (first use in this function)
usr/dash/histedit.c:111: warning: implicit declaration of function ‘el_init’
usr/dash/histedit.c:114: warning: implicit declaration of function ‘el_set’
usr/dash/histedit.c:114: error: ‘EL_HIST’ undeclared (first use in this function)
usr/dash/histedit.c:114: error: ‘history’ undeclared (first use in this function)
usr/dash/histedit.c:115: error: ‘EL_PROMPT’ undeclared (first use in this function)
usr/dash/histedit.c:123: warning: implicit declaration of function ‘el_end’
usr/dash/histedit.c:129: error: ‘EL_EDITOR’ undeclared (first use in this function)
usr/dash/histedit.c:132: warning: implicit declaration of function ‘el_source’
usr/dash/histedit.c:141: warning: implicit declaration of function ‘history_end’
usr/dash/histedit.c: In function ‘sethistsize’:
usr/dash/histedit.c:153: error: ‘HistEvent’ undeclared (first use in this function)
usr/dash/histedit.c:153: error: expected ‘;’ before ‘he’
usr/dash/histedit.c:155: error: ‘hist’ undeclared (first use in this function)
usr/dash/histedit.c:159: warning: implicit declaration of function ‘history’
usr/dash/histedit.c:159: error: ‘he’ undeclared (first use in this function)
usr/dash/histedit.c:159: error: ‘H_SETSIZE’ undeclared (first use in this function)
usr/dash/histedit.c: In function ‘setterm’:
usr/dash/histedit.c:166: error: ‘el’ undeclared (first use in this function)
usr/dash/histedit.c:167: error: ‘EL_TERMINAL’ undeclared (first use in this function)
usr/dash/histedit.c: In function ‘histcmd’:
usr/dash/histedit.c:182: error: ‘HistEvent’ undeclared (first use in this function)
usr/dash/histedit.c:182: error: expected ‘;’ before ‘he’
usr/dash/histedit.c:191: error: ‘MAXPATHLEN’ undeclared (first use in this function)
usr/dash/histedit.c:209: error: ‘hist’ undeclared (first use in this function)
usr/dash/histedit.c:218: error: ‘optreset’ undeclared (first use in this function)
usr/dash/histedit.c:332: error: ‘H_PREV’ undeclared (first use in this function)
usr/dash/histedit.c:332: error: ‘H_NEXT’ undeclared (first use in this function)
usr/dash/histedit.c:341: warning: implicit declaration of function ‘mkstemp’
usr/dash/histedit.c:357: error: ‘he’ undeclared (first use in this function)
usr/dash/histedit.c:357: error: ‘H_FIRST’ undeclared (first use in this function)
usr/dash/histedit.c:358: error: ‘H_NEXT_EVENT’ undeclared (first use in this function)
usr/dash/histedit.c:380: error: ‘H_ENTER’ undeclared (first use in this function)
usr/dash/histedit.c:191: warning: unused variable ‘editfile’
usr/dash/histedit.c: In function ‘str_to_event’:
usr/dash/histedit.c:447: error: ‘HistEvent’ undeclared (first use in this function)
usr/dash/histedit.c:447: error: expected ‘;’ before ‘he’
usr/dash/histedit.c:452: error: ‘hist’ undeclared (first use in this function)
usr/dash/histedit.c:452: error: ‘he’ undeclared (first use in this function)
usr/dash/histedit.c:452: error: ‘H_FIRST’ undeclared (first use in this function)
usr/dash/histedit.c:464: error: ‘H_NEXT’ undeclared (first use in this function)
usr/dash/histedit.c:467: error: ‘H_LAST’ undeclared (first use in this function)
usr/dash/histedit.c:469: error: ‘H_NEXT_EVENT’ undeclared (first use in this function)
usr/dash/histedit.c:486: error: ‘H_PREV_STR’ undeclared (first use in this function)
make[2]: *** [usr/dash/histedit.o] Error 1
make[1]: *** [all] Error 2
make: *** [klibc] Error 2

this happens on top of the 2 patches sent earlier and is easy to
reproduce:
git clone git://git.kernel.org/pub/scm/libs/klibc/klibc.git
make   KLIBCKERNELSRC=`pwd`/../linux-2.6 EXTRA_KLIBCCFLAGS="-DDEBUG=1"

Re: dash klibc DEBUG more compile trouble

[Herbert Xu]

maximilian attems <max@stro.at> wrote:
> once taken that stat/stat64 appart, histedit appears to be a minefield:

Unless you have libedit, you're supposed to define SMALL.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: dash klibc DEBUG more compile trouble

[maximilian attems]

On Sun, 11 Jul 2010, Herbert Xu wrote:

> maximilian attems <max@stro.at> wrote:
> > once taken that stat/stat64 appart, histedit appears to be a minefield:
> 
> Unless you have libedit, you're supposed to define SMALL.

indeed we do define it, but it was due to my poor Kconfig foo
that it gets undefined again on debug compile run.
thanks Herbert for aboves comment, helped out.

so compiling klibc with
 make   KLIBCKERNELSRC=`pwd`/../linux-2.6 EXTRA_KLIBCCFLAGS="-DDEBUG=1 " V=1

is either wrong or the klibc Kbuild is buggy as it undefines the Kbuild
specific entries in the subdirs.
so in usr/dash/Kbuild the config-cppflags are no longer used on build.

Sam any opinon?


thanks

-- 
maks

Re: dash klibc DEBUG more compile trouble

[Sam Ravnborg]

On Wed, Sep 08, 2010 at 06:20:17PM +0200, maximilian attems wrote:
> On Sun, 11 Jul 2010, Herbert Xu wrote:
> 
> > maximilian attems <max@stro.at> wrote:
> > > once taken that stat/stat64 appart, histedit appears to be a minefield:
> > 
> > Unless you have libedit, you're supposed to define SMALL.
> 
> indeed we do define it, but it was due to my poor Kconfig foo
> that it gets undefined again on debug compile run.
> thanks Herbert for aboves comment, helped out.
> 
> so compiling klibc with
>  make   KLIBCKERNELSRC=`pwd`/../linux-2.6 EXTRA_KLIBCCFLAGS="-DDEBUG=1 " V=1
> 
> is either wrong or the klibc Kbuild is buggy as it undefines the Kbuild
> specific entries in the subdirs.

It is wrong...
When you specify an variable on the commandline like in this
case you do with EXTRA_KLIBCCFLAGS=... then make will use the value
you assign to the variable rather than the value that is assigned
in the makefile.

So you actually overwrite the variable EXTRA_KLIBCCFLAGS, where you
expected to append to it.

I took a quick look at the kbuild stuff in klibc - and
there does not seem to be any way to pass extra flags on the commandline.

Except that you can say:

make CC="gcc -DDEBUG=1"

But I did not test this.

	Sam

Re: dash klibc DEBUG more compile trouble

[maximilian attems]

hello Sam,


On Wed, Sep 08, 2010 at 09:09:57PM +0200, Sam Ravnborg wrote:
> On Wed, Sep 08, 2010 at 06:20:17PM +0200, maximilian attems wrote:
<snipp>
> > 
> > so compiling klibc with
> >  make   KLIBCKERNELSRC=`pwd`/../linux-2.6 EXTRA_KLIBCCFLAGS="-DDEBUG=1 " V=1
> > 
> > is either wrong or the klibc Kbuild is buggy as it undefines the Kbuild
> > specific entries in the subdirs.
> 
> It is wrong...
> When you specify an variable on the commandline like in this
> case you do with EXTRA_KLIBCCFLAGS=... then make will use the value
> you assign to the variable rather than the value that is assigned
> in the makefile.
> 
> So you actually overwrite the variable EXTRA_KLIBCCFLAGS, where you
> expected to append to it.

indeed thanks for the explanations.
 
> I took a quick look at the kbuild stuff in klibc - and
> there does not seem to be any way to pass extra flags on the commandline.
> 
> Except that you can say:
> 
> make CC="gcc -DDEBUG=1"
> 
> But I did not test this.

this works indeed, thanks for the hint. :)

-- 
maks