From: Grant Likely <grant.likely@secretlab.ca>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH 1/2] OMAP2+: PM: initial runtime PM core support
Date: Wed, 8 Sep 2010 11:39:31 -0600 [thread overview]
Message-ID: <20100908173931.GL3686@angua.secretlab.ca> (raw)
In-Reply-To: <871v945esf.fsf@deeprootsystems.com>
On Wed, Sep 08, 2010 at 10:24:48AM -0700, Kevin Hilman wrote:
> Grant Likely <grant.likely@secretlab.ca> writes:
>
> > On Tue, Sep 07, 2010 at 05:54:41PM -0700, Kevin Hilman wrote:
> >> + omap_pm->runtime_suspend = omap_pm_runtime_suspend;
> >> + omap_pm->runtime_resume = omap_pm_runtime_resume;
> >
> > This will fail to build when CONFIG_PM_RUNTIME is unset. None of this
> > file should be build when CONFIG_PM_RUNTIME=n.
>
> FYI... Rather than not building the whole file, I'm fixing this by
> adding an #else clause to the #ifdef:
>
> #else
> #define omap_pm_runtime_suspend NULL
> #define omap_pm_runtime_resume NULL
> #endif /* CONFIG_PM_RUNTIME */
>
> This is because I'll also be building on this to hook up the
> _[suspend|resume]_noirq() methods which are based on #ifdef
> CONFIG_SUSPEND and not CONFIG_PM_RUNTIME.
okay.
g.
WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] OMAP2+: PM: initial runtime PM core support
Date: Wed, 8 Sep 2010 11:39:31 -0600 [thread overview]
Message-ID: <20100908173931.GL3686@angua.secretlab.ca> (raw)
In-Reply-To: <871v945esf.fsf@deeprootsystems.com>
On Wed, Sep 08, 2010 at 10:24:48AM -0700, Kevin Hilman wrote:
> Grant Likely <grant.likely@secretlab.ca> writes:
>
> > On Tue, Sep 07, 2010 at 05:54:41PM -0700, Kevin Hilman wrote:
> >> + omap_pm->runtime_suspend = omap_pm_runtime_suspend;
> >> + omap_pm->runtime_resume = omap_pm_runtime_resume;
> >
> > This will fail to build when CONFIG_PM_RUNTIME is unset. None of this
> > file should be build when CONFIG_PM_RUNTIME=n.
>
> FYI... Rather than not building the whole file, I'm fixing this by
> adding an #else clause to the #ifdef:
>
> #else
> #define omap_pm_runtime_suspend NULL
> #define omap_pm_runtime_resume NULL
> #endif /* CONFIG_PM_RUNTIME */
>
> This is because I'll also be building on this to hook up the
> _[suspend|resume]_noirq() methods which are based on #ifdef
> CONFIG_SUSPEND and not CONFIG_PM_RUNTIME.
okay.
g.
next prev parent reply other threads:[~2010-09-08 17:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 0:54 [PATCH 1/2] OMAP2+: PM: initial runtime PM core support Kevin Hilman
2010-09-08 0:54 ` Kevin Hilman
2010-09-08 0:54 ` [PATCH 2/2] OMAP1: PM: add simple runtime PM layer to manage clocks Kevin Hilman
2010-09-08 0:54 ` Kevin Hilman
2010-09-08 16:22 ` Grant Likely
2010-09-08 16:22 ` Grant Likely
2010-09-08 16:21 ` [PATCH 1/2] OMAP2+: PM: initial runtime PM core support Grant Likely
2010-09-08 16:21 ` Grant Likely
2010-09-08 17:08 ` Kevin Hilman
2010-09-08 17:08 ` Kevin Hilman
2010-09-08 17:40 ` Grant Likely
2010-09-08 17:40 ` Grant Likely
2010-09-08 17:24 ` Kevin Hilman
2010-09-08 17:24 ` Kevin Hilman
2010-09-08 17:39 ` Grant Likely [this message]
2010-09-08 17:39 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908173931.GL3686@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.