All of lore.kernel.org
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
Date: Wed, 8 Sep 2010 17:54:15 +0200	[thread overview]
Message-ID: <201009081754.15515.marek.vasut@gmail.com> (raw)
In-Reply-To: <AANLkTi=StWVfeGjNCqJWJka0yifXv6rEB6GoZEkq7NT5@mail.gmail.com>

Dne St 8. z??? 2010 07:34:24 Haojian Zhuang napsal(a):
> On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <mark.brown314@gmail.com> 
wrote:
> > Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> > ---
> >  arch/arm/mach-mmp/teton_bga.c |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-mmp/teton_bga.c
> > b/arch/arm/mach-mmp/teton_bga.c index bbeda5c..8e5801c 100644
> > --- a/arch/arm/mach-mmp/teton_bga.c
> > +++ b/arch/arm/mach-mmp/teton_bga.c
> > @@ -22,6 +22,7 @@
> >  #include <mach/gpio.h>
> >  #include <linux/input.h>
> >  #include <plat/pxa27x_keypad.h>
> > +#include <linux/i2c.h>
> > 
> >  #include "common.h"
> > 
> > @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata
> > = { GPIO110_KP_MKIN0,
> >        GPIO111_KP_MKOUT7,
> >        GPIO112_KP_MKOUT6,
> > +
> > +       /* i2c bus */
> > +       GPIO105_CI2C_SDA,
> > +       GPIO106_CI2C_SCL,
> >  };
> > 
> >  static unsigned int teton_bga_matrix_key_map[] = {
> > @@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data
> > teton_bga_keypad_info __initdata = { .debounce_interval      = 30,
> >  };
> > 
> > +static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
> > +       { I2C_BOARD_INFO("ds1337", 0x68), },
> > +};
> > +
> 
> I don't have the schematic of teton. But RTC chips should always has
> an irq pin. Is it also connected in your platform?

I think this one doesn't, but I haven't checked.

Cheers

> 
> >  static void __init teton_bga_init(void)
> >  {
> >        mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> > @@ -59,6 +68,7 @@ static void __init teton_bga_init(void)
> >        /* on-chip devices */
> >        pxa168_add_uart(1);
> >        pxa168_add_keypad(&teton_bga_keypad_info);
> > +       pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
> >  }
> > 
> >  MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> > --
> > 1.7.0.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> > in the body of a message to majordomo at vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
	"Mark F. Brown" <mark.brown314@gmail.com>,
	Eric Miao <eric.y.miao@gmail.com>,
	Haojian Zhuang <haojian.zhuang@marvell.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
Date: Wed, 8 Sep 2010 17:54:15 +0200	[thread overview]
Message-ID: <201009081754.15515.marek.vasut@gmail.com> (raw)
In-Reply-To: <AANLkTi=StWVfeGjNCqJWJka0yifXv6rEB6GoZEkq7NT5@mail.gmail.com>

Dne St 8. září 2010 07:34:24 Haojian Zhuang napsal(a):
> On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <mark.brown314@gmail.com> 
wrote:
> > Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> > ---
> >  arch/arm/mach-mmp/teton_bga.c |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-mmp/teton_bga.c
> > b/arch/arm/mach-mmp/teton_bga.c index bbeda5c..8e5801c 100644
> > --- a/arch/arm/mach-mmp/teton_bga.c
> > +++ b/arch/arm/mach-mmp/teton_bga.c
> > @@ -22,6 +22,7 @@
> >  #include <mach/gpio.h>
> >  #include <linux/input.h>
> >  #include <plat/pxa27x_keypad.h>
> > +#include <linux/i2c.h>
> > 
> >  #include "common.h"
> > 
> > @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata
> > = { GPIO110_KP_MKIN0,
> >        GPIO111_KP_MKOUT7,
> >        GPIO112_KP_MKOUT6,
> > +
> > +       /* i2c bus */
> > +       GPIO105_CI2C_SDA,
> > +       GPIO106_CI2C_SCL,
> >  };
> > 
> >  static unsigned int teton_bga_matrix_key_map[] = {
> > @@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data
> > teton_bga_keypad_info __initdata = { .debounce_interval      = 30,
> >  };
> > 
> > +static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
> > +       { I2C_BOARD_INFO("ds1337", 0x68), },
> > +};
> > +
> 
> I don't have the schematic of teton. But RTC chips should always has
> an irq pin. Is it also connected in your platform?

I think this one doesn't, but I haven't checked.

Cheers

> 
> >  static void __init teton_bga_init(void)
> >  {
> >        mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> > @@ -59,6 +68,7 @@ static void __init teton_bga_init(void)
> >        /* on-chip devices */
> >        pxa168_add_uart(1);
> >        pxa168_add_keypad(&teton_bga_keypad_info);
> > +       pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
> >  }
> > 
> >  MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> > --
> > 1.7.0.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> > in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2010-09-08 15:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08  2:56 [PATCH 0/3] ARM: pxa168: Added Teton BGA Board Support Mark F. Brown
2010-09-08  2:56 ` Mark F. Brown
2010-09-08  2:56 ` [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Mark F. Brown
2010-09-08  2:56   ` Mark F. Brown
2010-09-08  5:36   ` Haojian Zhuang
2010-09-08  5:36     ` Haojian Zhuang
2010-09-08 15:51   ` Marek Vasut
2010-09-08 15:51     ` Marek Vasut
2010-09-08 23:42     ` Mark F. Brown
2010-09-08 23:42       ` Mark F. Brown
2010-09-09  1:21       ` Marek Vasut
2010-09-09  1:21         ` Marek Vasut
2010-09-09  7:39         ` Eric Miao
2010-09-09  7:39           ` Eric Miao
2010-09-09 18:11           ` Marek Vasut
2010-09-09 18:11             ` Marek Vasut
2010-09-08  2:56 ` [PATCH 2/3] ARM: pxa168/teton bga: added keypad support Mark F. Brown
2010-09-08  2:56   ` Mark F. Brown
2010-09-08  2:56 ` [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337 Mark F. Brown
2010-09-08  2:56   ` Mark F. Brown
2010-09-08  5:34   ` Haojian Zhuang
2010-09-08  5:34     ` Haojian Zhuang
2010-09-08 15:54     ` Marek Vasut [this message]
2010-09-08 15:54       ` Marek Vasut
     [not found]       ` <AANLkTinGE=wxCcnSBiZQFeJxDG21DMd6KEcckavVuTbE@mail.gmail.com>
2010-09-08 21:09         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009081754.15515.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.