From: "David Härdeman" <david@hardeman.nu>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Linux Input <linux-input@vger.kernel.org>,
linux-media@vger.kernel.org, Jarod Wilson <jarod@redhat.com>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Ville Syrjala <syrjala@sci.fi>
Subject: Re: [PATCH 4/6] Input: winbond-cir - switch to using new keycode interface
Date: Wed, 8 Sep 2010 23:16:17 +0200 [thread overview]
Message-ID: <20100908211617.GB13938@hardeman.nu> (raw)
In-Reply-To: <20100908074200.32365.98120.stgit@hammer.corenet.prv>
On Wed, Sep 08, 2010 at 12:42:00AM -0700, Dmitry Torokhov wrote:
> Switch the code to use new style of getkeycode and setkeycode
> methods to allow retrieving and setting keycodes not only by
> their scancodes but also by index.
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
>
> drivers/input/misc/winbond-cir.c | 248 +++++++++++++++++++++++++-------------
> 1 files changed, 163 insertions(+), 85 deletions(-)
Thanks for doing the conversion for me, but I think you can skip this
patch. The driver will (if I understood your patchset correctly) still
work with the old get/setkeycode ioctls and I have a patch lined up that
converts winbond-cir.c to use ir-core which means all of the input
related code is removed.
--
David Härdeman
next prev parent reply other threads:[~2010-09-08 21:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 7:41 [PATCH 0/6] Large scancode handling Dmitry Torokhov
2010-09-08 7:41 ` [PATCH 1/6] Input: add support for large scancodes Dmitry Torokhov
2010-10-29 21:36 ` James Hogan
2010-10-29 22:34 ` James Hogan
2010-09-08 7:41 ` [PATCH 2/6] Input: sparse-keymap - switch to using new keycode interface Dmitry Torokhov
2010-09-08 7:41 ` [PATCH 3/6] Input: hid-input " Dmitry Torokhov
2010-09-08 7:42 ` [PATCH 4/6] Input: winbond-cir " Dmitry Torokhov
2010-09-08 21:16 ` David Härdeman [this message]
2010-09-08 23:00 ` Dmitry Torokhov
2010-09-08 23:00 ` Dmitry Torokhov
2010-09-08 23:09 ` David Härdeman
2010-09-08 23:09 ` David Härdeman
2010-09-08 23:14 ` Mauro Carvalho Chehab
2010-09-08 23:14 ` Mauro Carvalho Chehab
2010-09-08 7:42 ` [PATCH 5/6] Input: ati-remote2 " Dmitry Torokhov
2010-09-09 12:40 ` Ville Syrjälä
2010-09-13 16:28 ` Dmitry Torokhov
2010-09-13 16:28 ` Dmitry Torokhov
2010-09-15 21:04 ` Ville Syrjälä
2010-09-15 21:04 ` Ville Syrjälä
2010-09-15 21:13 ` Dmitry Torokhov
2010-09-08 7:42 ` [PATCH 6/6] Input: media/IR " Dmitry Torokhov
2010-09-08 9:48 ` [PATCH 0/6] Large scancode handling Jiri Kosina
2010-09-08 14:24 ` Jarod Wilson
2010-09-08 15:15 ` Mauro Carvalho Chehab
2010-09-08 15:22 ` Jarod Wilson
2010-09-08 15:25 ` Jiri Kosina
2010-09-08 15:36 ` Dmitry Torokhov
2010-09-08 16:09 ` Jarod Wilson
2010-09-08 16:56 ` Dmitry Torokhov
2010-09-08 17:29 ` Jarod Wilson
2010-09-13 15:00 ` Jiri Kosina
2010-09-08 15:36 ` Dmitry Torokhov
2010-09-08 14:31 ` Jarod Wilson
2010-09-08 15:34 ` Dmitry Torokhov
2010-09-13 17:48 ` Jarod Wilson
2010-09-14 1:26 ` Dmitry Torokhov
2010-09-08 15:23 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908211617.GB13938@hardeman.nu \
--to=david@hardeman.nu \
--cc=dmitry.torokhov@gmail.com \
--cc=jarod@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@redhat.com \
--cc=syrjala@sci.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.