From: "David Härdeman" <david@hardeman.nu>
To: Jarod Wilson <jarod@redhat.com>
Cc: Brian Rogers <brian@xyzw.org>,
jarod@wilsonet.com, linux-media@vger.kernel.org,
mchehab@redhat.com, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] ir-core: centralize sysfs raw decoder enabling/disabling
Date: Wed, 8 Sep 2010 23:22:55 +0200 [thread overview]
Message-ID: <20100908212255.GC13938@hardeman.nu> (raw)
In-Reply-To: <20100908141613.GB22323@redhat.com>
On Wed, Sep 08, 2010 at 10:16:13AM -0400, Jarod Wilson wrote:
> On Wed, Sep 08, 2010 at 07:04:03AM -0700, Brian Rogers wrote:
> > ir_dev->raw is also null. If I check these pointers before using
> > them, and bail out if both are null, then I get a working lircd, but
> > of course the file /sys/devices/virtual/rc/rc0/protocols no longer
> > does anything. On 2.6.35.4, the system never creates the
> > /sys/class/rc/rc0/current_protocol file. Is it the case that the
> > 'protocols' file should never appear, because my card can't support
> > this feature?
>
> Hm... So protocols is indeed intended for hardware that handles raw IR, as
> its a list of raw IR decoders available/enabled/disabled for the receiver.
> But some devices that do onboard decoding and deal with scancodes still
> need to support changing protocols, as they can be told "decode rc5" or
> "decode nec", etc... My memory is currently foggy on how it was exactly
> that it was supposed to be donee though. :) (Yet another reason I really
> need to poke at the imon driver code again).
This, and a raft of similar bugreports was one of the reasons I wrote
the rc_dev patch (which gets rid of ir_dev->props, the source of many
oopses by now).
Hardware decoders should work with the same sysfs file, the driver
should set ir_dev->props->change_protocol (current) or
rc->change_protocol (future) and it'll get notified when userspace
interacts with the sysfs file and the hardware can then react
accordingly. So the answer is yes - all hardware should have the file.
--
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "David Härdeman" <david@hardeman.nu>
To: Jarod Wilson <jarod@redhat.com>
Cc: Brian Rogers <brian@xyzw.org>,
jarod@wilsonet.com, linux-media@vger.kernel.org,
mchehab@redhat.com, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] ir-core: centralize sysfs raw decoder enabling/disabling
Date: Wed, 8 Sep 2010 23:22:55 +0200 [thread overview]
Message-ID: <20100908212255.GC13938@hardeman.nu> (raw)
In-Reply-To: <20100908141613.GB22323@redhat.com>
On Wed, Sep 08, 2010 at 10:16:13AM -0400, Jarod Wilson wrote:
> On Wed, Sep 08, 2010 at 07:04:03AM -0700, Brian Rogers wrote:
> > ir_dev->raw is also null. If I check these pointers before using
> > them, and bail out if both are null, then I get a working lircd, but
> > of course the file /sys/devices/virtual/rc/rc0/protocols no longer
> > does anything. On 2.6.35.4, the system never creates the
> > /sys/class/rc/rc0/current_protocol file. Is it the case that the
> > 'protocols' file should never appear, because my card can't support
> > this feature?
>
> Hm... So protocols is indeed intended for hardware that handles raw IR, as
> its a list of raw IR decoders available/enabled/disabled for the receiver.
> But some devices that do onboard decoding and deal with scancodes still
> need to support changing protocols, as they can be told "decode rc5" or
> "decode nec", etc... My memory is currently foggy on how it was exactly
> that it was supposed to be donee though. :) (Yet another reason I really
> need to poke at the imon driver code again).
This, and a raft of similar bugreports was one of the reasons I wrote
the rc_dev patch (which gets rid of ir_dev->props, the source of many
oopses by now).
Hardware decoders should work with the same sysfs file, the driver
should set ir_dev->props->change_protocol (current) or
rc->change_protocol (future) and it'll get notified when userspace
interacts with the sysfs file and the hardware can then react
accordingly. So the answer is yes - all hardware should have the file.
--
David Härdeman
next prev parent reply other threads:[~2010-09-08 21:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 20:29 [PATCH 0/2] ir-core: raw decoder framework changes David Härdeman
2010-06-13 20:29 ` David Härdeman
2010-06-13 20:29 ` [PATCH 1/2] ir-core: centralize sysfs raw decoder enabling/disabling David Härdeman
2010-06-16 20:05 ` Jarod Wilson
2010-06-16 20:05 ` Jarod Wilson
2010-06-16 20:39 ` Jarod Wilson
2010-06-16 20:39 ` Jarod Wilson
2010-06-28 16:56 ` Mauro Carvalho Chehab
2010-06-28 16:56 ` Mauro Carvalho Chehab
2010-09-08 14:04 ` Brian Rogers
2010-09-08 14:16 ` Jarod Wilson
2010-09-08 21:22 ` David Härdeman [this message]
2010-09-08 21:22 ` David Härdeman
2010-09-15 12:57 ` [PATCH] ir-core: Fix null dereferences in the protocols sysfs interface Brian Rogers
2010-09-15 14:41 ` Jarod Wilson
2010-06-13 20:29 ` [PATCH 2/2] ir-core: move decoding state to ir_raw_event_ctrl David Härdeman
2010-06-13 20:29 ` David Härdeman
2010-06-16 20:06 ` Jarod Wilson
2010-06-16 20:06 ` Jarod Wilson
2010-06-16 20:39 ` Jarod Wilson
2010-06-16 20:39 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908212255.GC13938@hardeman.nu \
--to=david@hardeman.nu \
--cc=brian@xyzw.org \
--cc=jarod@redhat.com \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.