* possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking
@ 2010-09-09 13:37 Olaf Hering
2010-09-09 13:48 ` Tim Deegan
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2010-09-09 13:37 UTC (permalink / raw)
To: xen-devel
Hello,
the comments in hap_enable_vram_tracking() and hap_clean_vram_tracking()
say the pages will be set to read-only, but it passes p2m_ram_rw instead
of p2m_ram_ro to p2m_change_type().
Bug or feature?
Olaf
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking
2010-09-09 13:37 possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking Olaf Hering
@ 2010-09-09 13:48 ` Tim Deegan
0 siblings, 0 replies; 2+ messages in thread
From: Tim Deegan @ 2010-09-09 13:48 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel@lists.xensource.com
At 14:37 +0100 on 09 Sep (1284043066), Olaf Hering wrote:
>
> Hello,
>
> the comments in hap_enable_vram_tracking() and hap_clean_vram_tracking()
> say the pages will be set to read-only, but it passes p2m_ram_rw instead
> of p2m_ram_ro to p2m_change_type().
>
> Bug or feature?
Neither. :) It's changing _from_ type p2m_ram_rw to type p2m_ram_logdirty
(which is read-only until the next write, when it reverts to p2m_ram_rw
and marks the page dirty).
Cheers,
Tim.
--
Tim Deegan <Tim.Deegan@citrix.com>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-09 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-09 13:37 possible code/comment mismatch in hap_enable_vram_tracking/hap_clean_vram_tracking Olaf Hering
2010-09-09 13:48 ` Tim Deegan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.