From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [RFC PATCH] lm75: some optimisations
Date: Thu, 09 Sep 2010 14:05:23 +0000 [thread overview]
Message-ID: <20100909140523.GA15906@ericsson.com> (raw)
In-Reply-To: <1284037694-16806-1-git-send-email-shubhrajyoti@ti.com>
On Thu, Sep 09, 2010 at 09:08:14AM -0400, Shubhrajyoti D wrote:
> Functions that used only at probe may be optimised.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> drivers/hwmon/lm75.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index ab5b87a..7857b94 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -134,7 +134,7 @@ static const struct attribute_group lm75_group = {
>
> /* device probe and removal */
>
> -static int
> +static int __devinit
> lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)
> {
> struct lm75_data *data;
> @@ -196,7 +196,7 @@ exit_free:
> return status;
> }
>
> -static int lm75_remove(struct i2c_client *client)
> +static int __devexit lm75_remove(struct i2c_client *client)
> {
> struct lm75_data *data = i2c_get_clientdata(client);
>
Other drivers reference the exit function using __devexit_p():
lm78.c:static int __devexit lm78_isa_remove(struct platform_device *pdev);
lm78.c: .remove = __devexit_p(lm78_isa_remove),
You might want to do the same.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2010-09-09 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 13:20 [lm-sensors] [RFC PATCH] lm75: some optimisations Shubhrajyoti D
2010-09-09 14:05 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909140523.GA15906@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.