bugs compiling 2.6.35.4

bugs compiling 2.6.35.4

[Dennis Gilmore]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

Trying to compile the current Fedora 14 kernel 
im getting 
drivers/built-in.o: In function `n2_des_setkey':
/builddir/build/BUILD/kernel-2.6.35.fc14/linux-2.6.35.sparc64/drivers/crypto/n2_core.c:701: 
undefined reference to `des_ekey'
`.exit.text' referenced in section `.devexit.text' of drivers/built-in.o: 
defined in discarded section `.exit.text' of drivers/built-in.o

we have CONFIG_CRYPTO_DEV_NIAGARA2=y and CONFIG_CRYPTO_DES=m 


With CONFIG_DEBUG_STRICT_USER_COPY_CHECKS=y  i get the following while 
unsetting it allows compilation to move on

In file included from 
/builddir/build/BUILD/kernel-2.6.35.fc14/linux-2.6.35.sparc64/arch/sparc/include/asm/uaccess.h:4,
                 from 
/builddir/build/BUILD/kernel-2.6.35.fc14/linux-2.6.35.sparc64/arch/sparc/include/asm/elf_64.h:10,
                 from 
/builddir/build/BUILD/kernel-2.6.35.fc14/linux-2.6.35.sparc64/arch/sparc/include/asm/elf.h:4,
                 from include/linux/elf.h:7,
                 from include/linux/module.h:14,
                 from fs/debugfs/file.c:16:
In function 'copy_from_user',
    inlined from 'write_file_bool' at fs/debugfs/file.c:434:
/builddir/build/BUILD/kernel-2.6.35.fc14/linux-2.6.35.sparc64/arch/sparc/include/asm/uaccess_64.h:232: 
error: call to 'copy_from_user_overflow' declared with attribute error: 
copy_from_user() buffer size is not provably correct
make[2]: *** [fs/debugfs/file.o] Error 1

Dennis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bugs compiling 2.6.35.4

[David Miller]

Turn off CONFIG_DEBUG_STRICT_USER_COPY_CHECKS in your config, it
is a debugging facility for kernel developers not something you
should enable yourself.

In fact because so many people turned this on and report the build
failures, I've simply just removed it from the tree as I got tired
of explaining this every single time :-/

Re: bugs compiling 2.6.35.4

[Dennis Gilmore]

[-- Attachment #1: Type: Text/Plain, Size: 807 bytes --]

On Thursday, September 09, 2010 10:36:51 pm David Miller wrote:
> Turn off CONFIG_DEBUG_STRICT_USER_COPY_CHECKS in your config, it
> is a debugging facility for kernel developers not something you
> should enable yourself.
> 
> In fact because so many people turned this on and report the build
> failures, I've simply just removed it from the tree as I got tired
> of explaining this every single time :-/
> --
> To unsubscribe from this list: send the line "unsubscribe sparclinux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

the fedora kernel devs have it enabled.  and we picked it up though the 
generic configs for every arch.  for now ive turned it off however the first 
issue still exists.

Dennis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: bugs compiling 2.6.35.4

[David Miller]

From: Dennis Gilmore <dennis@ausil.us>
Date: Thu, 9 Sep 2010 22:56:29 -0500

> for now ive turned it off however the first issue still exists.

Ok, I need to add a CRYPTO_DES dependency on the N2 crypto
driver.

I'll send the following patch to the crypto maintainer, thanks.

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index ea0b386..ad1cd59 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -172,6 +172,7 @@ config CRYPTO_DEV_MV_CESA
 
 config CRYPTO_DEV_NIAGARA2
        tristate "Niagara2 Stream Processing Unit driver"
+       select CRYPTO_DES
        select CRYPTO_ALGAPI
        depends on SPARC64
        help