From: Dan Carpenter <error27@gmail.com>
To: Greg Rose <gregory.v.rose@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] ixgbevf: potential NULL dereference on allocation failure
Date: Fri, 10 Sep 2010 11:52:34 +0000 [thread overview]
Message-ID: <20100910115234.GB5959@bicker> (raw)
If "rx_ring" is NULL then it will oops when we try:
memcpy(rx_ring, adapter->rx_ring,
adapter->num_rx_queues * sizeof(struct ixgbevf_ring));
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
To be honest, I'm not sure why the check for need_tx_update is there.
This change has only been compile tested.
diff --git a/drivers/net/ixgbevf/ethtool.c b/drivers/net/ixgbevf/ethtool.c
index 4680b06..7f194aa 100644
--- a/drivers/net/ixgbevf/ethtool.c
+++ b/drivers/net/ixgbevf/ethtool.c
@@ -385,7 +385,7 @@ static int ixgbevf_set_ringparam(struct net_device *netdev,
if (new_rx_count != adapter->rx_ring_count) {
rx_ring = kcalloc(adapter->num_rx_queues,
sizeof(struct ixgbevf_ring), GFP_KERNEL);
- if ((!rx_ring) && (need_tx_update)) {
+ if (!rx_ring) {
err = -ENOMEM;
goto err_rx_setup;
}
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Greg Rose <gregory.v.rose@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] ixgbevf: potential NULL dereference on allocation failure
Date: Fri, 10 Sep 2010 13:52:34 +0200 [thread overview]
Message-ID: <20100910115234.GB5959@bicker> (raw)
If "rx_ring" is NULL then it will oops when we try:
memcpy(rx_ring, adapter->rx_ring,
adapter->num_rx_queues * sizeof(struct ixgbevf_ring));
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
To be honest, I'm not sure why the check for need_tx_update is there.
This change has only been compile tested.
diff --git a/drivers/net/ixgbevf/ethtool.c b/drivers/net/ixgbevf/ethtool.c
index 4680b06..7f194aa 100644
--- a/drivers/net/ixgbevf/ethtool.c
+++ b/drivers/net/ixgbevf/ethtool.c
@@ -385,7 +385,7 @@ static int ixgbevf_set_ringparam(struct net_device *netdev,
if (new_rx_count != adapter->rx_ring_count) {
rx_ring = kcalloc(adapter->num_rx_queues,
sizeof(struct ixgbevf_ring), GFP_KERNEL);
- if ((!rx_ring) && (need_tx_update)) {
+ if (!rx_ring) {
err = -ENOMEM;
goto err_rx_setup;
}
next reply other threads:[~2010-09-10 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 11:52 Dan Carpenter [this message]
2010-09-10 11:52 ` [patch] ixgbevf: potential NULL dereference on allocation failure Dan Carpenter
2010-09-10 20:21 ` [patch] ixgbevf: potential NULL dereference on allocation David Miller
2010-09-10 20:21 ` [patch] ixgbevf: potential NULL dereference on allocation failure David Miller
2010-09-10 20:25 ` [patch] ixgbevf: potential NULL dereference on allocation Rose, Gregory V
2010-09-10 20:25 ` [patch] ixgbevf: potential NULL dereference on allocation failure Rose, Gregory V
2010-09-14 16:57 ` [patch] ixgbevf: potential NULL dereference on allocation Rose, Gregory V
2010-09-14 16:57 ` [patch] ixgbevf: potential NULL dereference on allocation failure Rose, Gregory V
2010-09-19 18:33 ` [patch] ixgbevf: potential NULL dereference on allocation David Miller
2010-09-19 18:33 ` [patch] ixgbevf: potential NULL dereference on allocation failure David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910115234.GB5959@bicker \
--to=error27@gmail.com \
--cc=davem@davemloft.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.