From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>, Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 1/4] hugetlb, rmap: always use anon_vma root pointer
Date: Fri, 10 Sep 2010 23:50:22 +0200 [thread overview]
Message-ID: <20100910235022.74ec04de@basil.nowhere.org> (raw)
In-Reply-To: <AANLkTikV9nXxMW8X9Wq+wGaJfzMEAmzTFrDNf8Aq4cTs@mail.gmail.com>
On Fri, 10 Sep 2010 10:19:24 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, Sep 9, 2010 at 9:23 PM, Naoya Horiguchi
> <n-horiguchi@ah.jp.nec.com> wrote:
> > This patch applies Andrea's fix given by the following patch into
> > hugepage rmapping code:
> >
> > commit 288468c334e98aacbb7e2fb8bde6bc1adcd55e05
> > Author: Andrea Arcangeli <aarcange@redhat.com>
> > Date: Mon Aug 9 17:19:09 2010 -0700
> >
> > This patch uses anon_vma->root and avoids unnecessary overwriting
> > when anon_vma is already set up.
>
> Btw, why isn't the code in __page_set_anon_rmap() also doing this
> cleaner version (ie a single "if (PageAnon(page)) return;" up front)?
Perhaps I misunderstand the question, but __page_set_anon_rmap
should handle Anon pages, shouldn't it?
>
> The comments in that function are also some alien language translated
> to english by some broken automatic translation service. Could
> somebody clean up that function and come up with a comment that
> actually parses as English and makes sense?
I'll do that.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>, Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 1/4] hugetlb, rmap: always use anon_vma root pointer
Date: Fri, 10 Sep 2010 23:50:22 +0200 [thread overview]
Message-ID: <20100910235022.74ec04de@basil.nowhere.org> (raw)
In-Reply-To: <AANLkTikV9nXxMW8X9Wq+wGaJfzMEAmzTFrDNf8Aq4cTs@mail.gmail.com>
On Fri, 10 Sep 2010 10:19:24 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, Sep 9, 2010 at 9:23 PM, Naoya Horiguchi
> <n-horiguchi@ah.jp.nec.com> wrote:
> > This patch applies Andrea's fix given by the following patch into
> > hugepage rmapping code:
> >
> > commit 288468c334e98aacbb7e2fb8bde6bc1adcd55e05
> > Author: Andrea Arcangeli <aarcange@redhat.com>
> > Date: Mon Aug 9 17:19:09 2010 -0700
> >
> > This patch uses anon_vma->root and avoids unnecessary overwriting
> > when anon_vma is already set up.
>
> Btw, why isn't the code in __page_set_anon_rmap() also doing this
> cleaner version (ie a single "if (PageAnon(page)) return;" up front)?
Perhaps I misunderstand the question, but __page_set_anon_rmap
should handle Anon pages, shouldn't it?
>
> The comments in that function are also some alien language translated
> to english by some broken automatic translation service. Could
> somebody clean up that function and come up with a comment that
> actually parses as English and makes sense?
I'll do that.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-10 21:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 4:23 [PATCH 0/4] hugetlb, rmap: fixes and cleanups Naoya Horiguchi
2010-09-10 4:23 ` Naoya Horiguchi
2010-09-10 4:23 ` [PATCH 1/4] hugetlb, rmap: always use anon_vma root pointer Naoya Horiguchi
2010-09-10 4:23 ` Naoya Horiguchi
2010-09-10 14:37 ` Andrea Arcangeli
2010-09-10 14:37 ` Andrea Arcangeli
2010-09-10 14:40 ` Rik van Riel
2010-09-10 14:40 ` Rik van Riel
2010-09-10 17:19 ` Linus Torvalds
2010-09-10 17:19 ` Linus Torvalds
2010-09-10 21:50 ` Andi Kleen [this message]
2010-09-10 21:50 ` Andi Kleen
2010-09-10 22:07 ` Linus Torvalds
2010-09-10 22:07 ` Linus Torvalds
2010-09-11 2:09 ` Rik van Riel
2010-09-11 2:09 ` Rik van Riel
2010-09-10 4:23 ` [PATCH 2/4] hugetlb, rmap: use hugepage_add_new_anon_rmap() in hugetlb_cow() Naoya Horiguchi
2010-09-10 4:23 ` Naoya Horiguchi
2010-09-10 14:39 ` Andrea Arcangeli
2010-09-10 14:39 ` Andrea Arcangeli
2010-09-10 14:40 ` Rik van Riel
2010-09-10 14:40 ` Rik van Riel
2010-09-10 4:23 ` [PATCH 3/4] hugetlb, rmap: fix confusing page locking " Naoya Horiguchi
2010-09-10 4:23 ` Naoya Horiguchi
2010-09-10 14:41 ` Rik van Riel
2010-09-10 14:41 ` Rik van Riel
2010-09-10 17:15 ` Linus Torvalds
2010-09-10 17:15 ` Linus Torvalds
2010-09-23 23:50 ` Naoya Horiguchi
2010-09-23 23:50 ` Naoya Horiguchi
2010-09-10 4:23 ` [PATCH 4/4] hugetlb, rmap: add BUG_ON(!PageLocked) in hugetlb_add_anon_rmap() Naoya Horiguchi
2010-09-10 4:23 ` Naoya Horiguchi
2010-09-10 14:42 ` Rik van Riel
2010-09-10 14:42 ` Rik van Riel
2010-09-10 14:44 ` Andrea Arcangeli
2010-09-10 14:44 ` Andrea Arcangeli
2010-09-10 9:04 ` [PATCH 0/4] hugetlb, rmap: fixes and cleanups Andi Kleen
2010-09-10 9:04 ` Andi Kleen
2010-09-10 11:47 ` Naoya Horiguchi
2010-09-10 11:47 ` Naoya Horiguchi
2010-09-10 14:30 ` Andi Kleen
2010-09-10 14:30 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910235022.74ec04de@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.