From: Joerg Roedel <joro@8bytes.org>
To: Avi Kivity <avi@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/7] svm: Add test for selective cr0 intercept
Date: Sun, 12 Sep 2010 11:36:30 +0200 [thread overview]
Message-ID: <20100912093629.GD680@8bytes.org> (raw)
In-Reply-To: <4C8C981A.9070303@redhat.com>
On Sun, Sep 12, 2010 at 11:06:34AM +0200, Avi Kivity wrote:
> On 09/10/2010 06:34 PM, Joerg Roedel wrote:
>> + /*
>> + * If we are here the test failed, not sure what to do now because we
>> + * are not in guest-mode anymore so we can't trigger an intercept.
>> + * Trigger a tripple-fault for now.
>> + */
>> + printf("sel_cr0 test failed. Can not recover from this - exiting\n");
>> + exit(1);
>
> Don't understand - we're still in guest mode (only running very
> slowly...). All you have to do is fall off the end here, and you'll
> exit with VMMCALL.
The bug I fixed was, that the guest continues to run in l1 mode with the
l2 rip, rsp, and rax. So if the bug is there, it continues to run in
this function, but with no chance to intercept anymore because the guest
is not longer in emulated guest mode.
I agree that this is a test specific to that bug. I should probably add
another test to check if the correct intercepts are reported.
Joerg
next prev parent reply other threads:[~2010-09-12 9:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 15:34 [PATCH 0/7] New Unit-Tests for KVM SVM emulation Joerg Roedel
2010-09-10 15:34 ` [PATCH 1/7] svm: Add test for selective cr0 intercept Joerg Roedel
2010-09-12 9:06 ` Avi Kivity
2010-09-12 9:36 ` Joerg Roedel [this message]
2010-09-12 14:42 ` Avi Kivity
2010-09-10 15:34 ` [PATCH 2/7] svm: Run tests with NPT enabled if available Joerg Roedel
2010-09-12 9:10 ` Avi Kivity
2010-09-12 14:39 ` Joerg Roedel
2010-09-10 15:34 ` [PATCH 3/7] svm: Add test for NX bit check in emulated NPT Joerg Roedel
2010-09-10 15:34 ` [PATCH 4/7] svm: Add test for US " Joerg Roedel
2010-09-10 15:34 ` [PATCH 5/7] svm: Add test for RSVD " Joerg Roedel
2010-09-10 15:34 ` [PATCH 6/7] svm: Add test for RW " Joerg Roedel
2010-09-10 15:34 ` [PATCH 7/7] svm: Add test for the NPT page table walker Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 15:59 [PATCH 0/7] New Unit-Tests for KVM SVM emulation v2 Joerg Roedel
2010-09-14 15:59 ` [PATCH 1/7] svm: Add test for selective cr0 intercept Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100912093629.GD680@8bytes.org \
--to=joro@8bytes.org \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.