From: Joerg Roedel <joro@8bytes.org>
To: Avi Kivity <avi@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/7] svm: Run tests with NPT enabled if available
Date: Sun, 12 Sep 2010 16:39:52 +0200 [thread overview]
Message-ID: <20100912143952.GF680@8bytes.org> (raw)
In-Reply-To: <4C8C991A.6020106@redhat.com>
On Sun, Sep 12, 2010 at 11:10:50AM +0200, Avi Kivity wrote:
> On 09/10/2010 06:34 PM, Joerg Roedel wrote:
>> This patch adds code to setup a nested page table which is
>> used for all tests.
>>
>
>> +
>> + printf("NPT detected - running all tests with NPT enabled\n");
>> +
>> + /*
>> + * Nested paging supported - Build a nested page table
>> + * Build the page-table bottom-up and map everything with 2M pages
>> + */
>> +
>> + address = 0;
>> +
>> + /* PTE level */
>
> Conflicts with previous comment - these aren't 2M pages.
Oh right, I used 2M pages in the first version but figured out then that
2MB are not granular enough to write all the NPT tests. Thus I changed
it to 4k pages and forgot to update the comment. I will resend this one.
Joerg
next prev parent reply other threads:[~2010-09-12 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 15:34 [PATCH 0/7] New Unit-Tests for KVM SVM emulation Joerg Roedel
2010-09-10 15:34 ` [PATCH 1/7] svm: Add test for selective cr0 intercept Joerg Roedel
2010-09-12 9:06 ` Avi Kivity
2010-09-12 9:36 ` Joerg Roedel
2010-09-12 14:42 ` Avi Kivity
2010-09-10 15:34 ` [PATCH 2/7] svm: Run tests with NPT enabled if available Joerg Roedel
2010-09-12 9:10 ` Avi Kivity
2010-09-12 14:39 ` Joerg Roedel [this message]
2010-09-10 15:34 ` [PATCH 3/7] svm: Add test for NX bit check in emulated NPT Joerg Roedel
2010-09-10 15:34 ` [PATCH 4/7] svm: Add test for US " Joerg Roedel
2010-09-10 15:34 ` [PATCH 5/7] svm: Add test for RSVD " Joerg Roedel
2010-09-10 15:34 ` [PATCH 6/7] svm: Add test for RW " Joerg Roedel
2010-09-10 15:34 ` [PATCH 7/7] svm: Add test for the NPT page table walker Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 15:59 [PATCH 0/7] New Unit-Tests for KVM SVM emulation v2 Joerg Roedel
2010-09-14 15:59 ` [PATCH 2/7] svm: Run tests with NPT enabled if available Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100912143952.GF680@8bytes.org \
--to=joro@8bytes.org \
--cc=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.