* [PATCH / 4.0.1] fix fd leak in xenstore
@ 2010-09-14 14:37 Olaf Hering
2010-09-14 15:11 ` Gianni Tedesco
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2010-09-14 14:37 UTC (permalink / raw)
To: xen-devel
Missing from commit 'libxl: Backported stuff from unstable'
Without this change, xs_daemon_open/xs_daemon_close will leak filedescriptors.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/xenstore/xs.c | 2 ++
1 file changed, 2 insertions(+)
--- xen-4.0.1-testing.orig/tools/xenstore/xs.c
+++ xen-4.0.1-testing/tools/xenstore/xs.c
@@ -285,6 +285,8 @@ void xs_daemon_close(struct xs_handle *h
mutex_unlock(&h->request_mutex);
mutex_unlock(&h->reply_mutex);
mutex_unlock(&h->watch_mutex);
+
+ close_fds_free(h);
}
static bool read_all(int fd, void *data, unsigned int len)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH / 4.0.1] fix fd leak in xenstore
2010-09-14 14:37 [PATCH / 4.0.1] fix fd leak in xenstore Olaf Hering
@ 2010-09-14 15:11 ` Gianni Tedesco
2010-09-14 17:12 ` [PATCH / 4.0.1] fix fd leak in xenstore [and 1 more messages] Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Gianni Tedesco @ 2010-09-14 15:11 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel@lists.xensource.com
On Tue, 2010-09-14 at 15:37 +0100, Olaf Hering wrote:
> Missing from commit 'libxl: Backported stuff from unstable'
> Without this change, xs_daemon_open/xs_daemon_close will leak filedescriptors.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> ---
> tools/xenstore/xs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- xen-4.0.1-testing.orig/tools/xenstore/xs.c
> +++ xen-4.0.1-testing/tools/xenstore/xs.c
> @@ -285,6 +285,8 @@ void xs_daemon_close(struct xs_handle *h
> mutex_unlock(&h->request_mutex);
> mutex_unlock(&h->reply_mutex);
> mutex_unlock(&h->watch_mutex);
> +
> + close_fds_free(h);
> }
>
> static bool read_all(int fd, void *data, unsigned int len)
ack, well spotted
Gianni
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH / 4.0.1] fix fd leak in xenstore [and 1 more messages]
2010-09-14 15:11 ` Gianni Tedesco
@ 2010-09-14 17:12 ` Ian Jackson
0 siblings, 0 replies; 3+ messages in thread
From: Ian Jackson @ 2010-09-14 17:12 UTC (permalink / raw)
To: Keir Fraser; +Cc: Olaf Hering, xen-devel, Gianni Tedesco
Olaf Hering writes ("[Xen-devel] [PATCH / 4.0.1] fix fd leak in xenstore"):
>
> Missing from commit 'libxl: Backported stuff from unstable'
> Without this change, xs_daemon_open/xs_daemon_close will leak filedescriptors.
You are right.
Keir, could you please apply Olaf's patch to xen-4.0-testing ?
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Gianni Tedesco <gianni.tedesco@citrix.com>
Thanks,
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-14 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-14 14:37 [PATCH / 4.0.1] fix fd leak in xenstore Olaf Hering
2010-09-14 15:11 ` Gianni Tedesco
2010-09-14 17:12 ` [PATCH / 4.0.1] fix fd leak in xenstore [and 1 more messages] Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.