From: Alan Cox <alan@linux.intel.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org
Subject: Re: [PATCH 5/7] sdhci: Tidy up spaces in sdhci_intel_mid
Date: Tue, 14 Sep 2010 15:21:36 +0100 [thread overview]
Message-ID: <20100914152136.082acc02@linux.intel.com> (raw)
In-Reply-To: <20100914144512.GH2629@pengutronix.de>
On Tue, 14 Sep 2010 16:45:12 +0200
Wolfram Sang <w.sang@pengutronix.de> wrote:
> On Tue, Sep 14, 2010 at 02:40:57PM +0100, Alan Cox wrote:
> > On Tue, 14 Sep 2010 16:21:29 +0200
> > Wolfram Sang <w.sang@pengutronix.de> wrote:
> >
> > > On Mon, Sep 13, 2010 at 06:39:41PM +0100, Alan Cox wrote:
> > > > Coding style fixes
> > > >
> > > > Signed-off-by: Alan Cox <alan@linux.intel.com>
> > >
> > > Shouldn't this be folded into the patch which initially creates
> > > sdhci-intel-mid.c?
> >
> > The work was done later and the signoffs are not the same. In the
> > ideal world - yes of course. I can redo them this way if you want
> > but it'll probably be about a month.
>
> I would indeed prefer to first have minimal changes to the
> mmc/sdhci-core and then have the final version of sdhci-intel-mid.c
> put on top of that (also applies to patch 4/7). Less error prone and
> easier to review. Yet, I am not the one who is picking up the patches.
>
> (BTW can't you just combine SoB if you fold patches?)
Ok will have a look at that next month and will also split the host
ops patches into a patch to add them and a patch to use them.
Alan
next prev parent reply other threads:[~2010-09-14 15:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 17:38 [PATCH 0/7] Intel MID SDHCI support (take two) Alan Cox
2010-09-13 17:38 ` [PATCH 1/7] sdhci: Rework some of the quirk behaviour Alan Cox
2010-09-14 14:34 ` Wolfram Sang
2010-09-14 14:20 ` Alan Cox
2010-09-13 17:39 ` [PATCH 2/7] sdhci: Allow the probe handler to override slots Alan Cox
2010-09-13 17:39 ` [PATCH 3/7] sdhci: Intel Medfield support Alan Cox
2010-09-13 17:39 ` [PATCH 4/7] mmc: serialization support Alan Cox
2010-09-13 17:39 ` [PATCH 5/7] sdhci: Tidy up spaces in sdhci_intel_mid Alan Cox
2010-09-14 14:21 ` Wolfram Sang
2010-09-14 13:40 ` Alan Cox
2010-09-14 14:45 ` Wolfram Sang
2010-09-14 14:21 ` Alan Cox [this message]
2010-09-14 16:57 ` Chris Ball
2010-09-14 16:41 ` Alan Cox
2010-09-14 20:00 ` Wolfram Sang
2010-09-13 17:39 ` [PATCH 6/7] sdhci_pci: Tidy this as well Alan Cox
2010-09-13 17:39 ` [PATCH 7/7] sdhci: Tidy up sdhci.c Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914152136.082acc02@linux.intel.com \
--to=alan@linux.intel.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.