From: Chris Ball <cjb@laptop.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Alan Cox <alan@linux.intel.com>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 5/7] sdhci: Tidy up spaces in sdhci_intel_mid
Date: Tue, 14 Sep 2010 17:57:43 +0100 [thread overview]
Message-ID: <20100914165743.GA19431@void.printf.net> (raw)
In-Reply-To: <20100914144512.GH2629@pengutronix.de>
Hi,
On Tue, Sep 14, 2010 at 04:45:12PM +0200, Wolfram Sang wrote:
> I would indeed prefer to first have minimal changes to the
> mmc/sdhci-core and then have the final version of sdhci-intel-mid.c put
> on top of that (also applies to patch 4/7). Less error prone and easier
> to review. Yet, I am not the one who is picking up the patches.
>
> (BTW can't you just combine SoB if you fold patches?)
I'm willing to help split up/fold patches if it'll help, especially
if it would make a difference to whether or not we get MID support
into 2.6.37, which is worth trying for. I like Wolfram's suggested
patchset format. Alan, do you feel comfortable re-doing this in time
for some testing before the merge window opens, or should I help?
I think we should postpone style cleanups outside of sdhci-intel-mid.c
until .38, when there'll be less of an outstanding patch backlog.
The big question seems to be whether the approach the patchset takes
-- moving from quirks to hooks, extending sdhci.c without creating a
full driver, and the initial choice of overridable hooks -- makes
sense. I'd be happy to hear everyone's thoughts on that.
Thanks for the review so far, Wolfram!
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-14 16:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 17:38 [PATCH 0/7] Intel MID SDHCI support (take two) Alan Cox
2010-09-13 17:38 ` [PATCH 1/7] sdhci: Rework some of the quirk behaviour Alan Cox
2010-09-14 14:34 ` Wolfram Sang
2010-09-14 14:20 ` Alan Cox
2010-09-13 17:39 ` [PATCH 2/7] sdhci: Allow the probe handler to override slots Alan Cox
2010-09-13 17:39 ` [PATCH 3/7] sdhci: Intel Medfield support Alan Cox
2010-09-13 17:39 ` [PATCH 4/7] mmc: serialization support Alan Cox
2010-09-13 17:39 ` [PATCH 5/7] sdhci: Tidy up spaces in sdhci_intel_mid Alan Cox
2010-09-14 14:21 ` Wolfram Sang
2010-09-14 13:40 ` Alan Cox
2010-09-14 14:45 ` Wolfram Sang
2010-09-14 14:21 ` Alan Cox
2010-09-14 16:57 ` Chris Ball [this message]
2010-09-14 16:41 ` Alan Cox
2010-09-14 20:00 ` Wolfram Sang
2010-09-13 17:39 ` [PATCH 6/7] sdhci_pci: Tidy this as well Alan Cox
2010-09-13 17:39 ` [PATCH 7/7] sdhci: Tidy up sdhci.c Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914165743.GA19431@void.printf.net \
--to=cjb@laptop.org \
--cc=alan@linux.intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.