* [patch] infiniband: nes_cm: remove unneeded variable
@ 2010-09-15 16:32 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-09-15 16:32 UTC (permalink / raw)
To: Faisal Latif
Cc: Chien Tung, Roland Dreier, Or Gerlitz,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Just a small cleanup. The "passive_state" variable isn't used any more
after: dae58728dc "RDMA/nes: Fix double CLOSE event indication crash"
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index 61e0efd..5c8d34c 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -1424,7 +1424,6 @@ static void handle_rst_pkt(struct nes_cm_node *cm_node, struct sk_buff *skb,
{
int reset = 0; /* whether to send reset in case of err.. */
- int passive_state;
atomic_inc(&cm_resets_recvd);
nes_debug(NES_DBG_CM, "Received Reset, cm_node = %p, state = %u."
" refcnt=%d\n", cm_node, cm_node->state,
@@ -1439,7 +1438,7 @@ static void handle_rst_pkt(struct nes_cm_node *cm_node, struct sk_buff *skb,
active_open_err(cm_node, skb, reset);
break;
case NES_CM_STATE_MPAREQ_RCVD:
- passive_state = atomic_add_return(1, &cm_node->passive_state);
+ atomic_inc(&cm_node->passive_state);
dev_kfree_skb_any(skb);
break;
case NES_CM_STATE_ESTABLISHED:
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] infiniband: nes_cm: remove unneeded variable
@ 2010-09-15 16:32 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-09-15 16:32 UTC (permalink / raw)
To: Faisal Latif
Cc: Chien Tung, Roland Dreier, Or Gerlitz,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
Just a small cleanup. The "passive_state" variable isn't used any more
after: dae58728dc "RDMA/nes: Fix double CLOSE event indication crash"
Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index 61e0efd..5c8d34c 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -1424,7 +1424,6 @@ static void handle_rst_pkt(struct nes_cm_node *cm_node, struct sk_buff *skb,
{
int reset = 0; /* whether to send reset in case of err.. */
- int passive_state;
atomic_inc(&cm_resets_recvd);
nes_debug(NES_DBG_CM, "Received Reset, cm_node = %p, state = %u."
" refcnt=%d\n", cm_node, cm_node->state,
@@ -1439,7 +1438,7 @@ static void handle_rst_pkt(struct nes_cm_node *cm_node, struct sk_buff *skb,
active_open_err(cm_node, skb, reset);
break;
case NES_CM_STATE_MPAREQ_RCVD:
- passive_state = atomic_add_return(1, &cm_node->passive_state);
+ atomic_inc(&cm_node->passive_state);
dev_kfree_skb_any(skb);
break;
case NES_CM_STATE_ESTABLISHED:
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [patch] infiniband: nes_cm: remove unneeded variable
2010-09-15 16:32 ` Dan Carpenter
@ 2010-09-15 18:16 ` Latif, Faisal
-1 siblings, 0 replies; 6+ messages in thread
From: Latif, Faisal @ 2010-09-15 18:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tung, Chien Tin, Roland Dreier, Or Gerlitz,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>-----Original Message-----
>From: Dan Carpenter [mailto:error27@gmail.com]
>Sent: Wednesday, September 15, 2010 11:33 AM
>To: Latif, Faisal
>Cc: Tung, Chien Tin; Roland Dreier; Or Gerlitz; linux-
>rdma@vger.kernel.org; kernel-janitors@vger.kernel.org
>Subject: [patch] infiniband: nes_cm: remove unneeded variable
>
>Just a small cleanup. The "passive_state" variable isn't used any more
>after: dae58728dc "RDMA/nes: Fix double CLOSE event indication crash"
>
>Signed-off-by: Dan Carpenter <error27@gmail.com>
>
>diff --git a/drivers/infiniband/hw/nes/nes_cm.c
>b/drivers/infiniband/hw/nes/nes_cm.c
>index 61e0efd..5c8d34c 100644
>--- a/drivers/infiniband/hw/nes/nes_cm.c
>+++ b/drivers/infiniband/hw/nes/nes_cm.c
>@@ -1424,7 +1424,6 @@ static void handle_rst_pkt(struct nes_cm_node
>*cm_node, struct sk_buff *skb,
This is fine.
Thanks
Faisal
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [patch] infiniband: nes_cm: remove unneeded variable
@ 2010-09-15 18:16 ` Latif, Faisal
0 siblings, 0 replies; 6+ messages in thread
From: Latif, Faisal @ 2010-09-15 18:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tung, Chien Tin, Roland Dreier, Or Gerlitz,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>-----Original Message-----
>From: Dan Carpenter [mailto:error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
>Sent: Wednesday, September 15, 2010 11:33 AM
>To: Latif, Faisal
>Cc: Tung, Chien Tin; Roland Dreier; Or Gerlitz; linux-
>rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>Subject: [patch] infiniband: nes_cm: remove unneeded variable
>
>Just a small cleanup. The "passive_state" variable isn't used any more
>after: dae58728dc "RDMA/nes: Fix double CLOSE event indication crash"
>
>Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
>diff --git a/drivers/infiniband/hw/nes/nes_cm.c
>b/drivers/infiniband/hw/nes/nes_cm.c
>index 61e0efd..5c8d34c 100644
>--- a/drivers/infiniband/hw/nes/nes_cm.c
>+++ b/drivers/infiniband/hw/nes/nes_cm.c
>@@ -1424,7 +1424,6 @@ static void handle_rst_pkt(struct nes_cm_node
>*cm_node, struct sk_buff *skb,
This is fine.
Thanks
Faisal
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] infiniband: nes_cm: remove unneeded variable
2010-09-15 16:32 ` Dan Carpenter
@ 2010-09-29 3:50 ` Roland Dreier
-1 siblings, 0 replies; 6+ messages in thread
From: Roland Dreier @ 2010-09-29 3:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Faisal Latif, Chien Tung, Roland Dreier, Or Gerlitz,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
thanks, applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-29 3:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-15 16:32 [patch] infiniband: nes_cm: remove unneeded variable Dan Carpenter
2010-09-15 16:32 ` Dan Carpenter
2010-09-15 18:16 ` Latif, Faisal
2010-09-15 18:16 ` Latif, Faisal
2010-09-29 3:50 ` Roland Dreier
2010-09-29 3:50 ` Roland Dreier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.