Re: [lm-sensors] [patch 01/36] hwmon: New driver for the

Re: [lm-sensors] [patch 01/36] hwmon: New driver for the

[Guenter Roeck]

Hi Jean,

On Wed, Sep 15, 2010 at 09:40:27AM -0400, Jean Delvare wrote:
[...]
> +module_init(sensors_w83795_init);
> +module_exit(sensors_w83795_exit);
> +
Nitpick but causes a whitespace error when integrating (empty last line),
which is then retained through the entire series.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [patch 01/36] hwmon: New driver for the

[Jean Delvare]

On Wed, 15 Sep 2010 09:34:47 -0700, Guenter Roeck wrote:
> Hi Jean,
> 
> On Wed, Sep 15, 2010 at 09:40:27AM -0400, Jean Delvare wrote:
> [...]
> > +module_init(sensors_w83795_init);
> > +module_exit(sensors_w83795_exit);
> > +
> Nitpick but causes a whitespace error when integrating (empty last line),
> which is then retained through the entire series.

Fixed, thanks for reporting. Not sure which tool pointed it out, but
checkpatch didn't tell me.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [patch 01/36] hwmon: New driver for the

[Guenter Roeck]

On Wed, Sep 15, 2010 at 12:43:23PM -0400, Jean Delvare wrote:
> On Wed, 15 Sep 2010 09:34:47 -0700, Guenter Roeck wrote:
> > Hi Jean,
> > 
> > On Wed, Sep 15, 2010 at 09:40:27AM -0400, Jean Delvare wrote:
> > [...]
> > > +module_init(sensors_w83795_init);
> > > +module_exit(sensors_w83795_exit);
> > > +
> > Nitpick but causes a whitespace error when integrating (empty last line),
> > which is then retained through the entire series.
> 
> Fixed, thanks for reporting. Not sure which tool pointed it out, but
> checkpatch didn't tell me.
> 
Yes, I know. Often happens to me with whitespace errors.

"git am" complains about it, unless you use -3.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [patch 01/36] hwmon: New driver for the

[Henrique de Moraes Holschuh]

It seems to be working so far.  I got this information from SuperMicro,
for their C7X58 and X8SAX motherboards (included here as a direct
transcription from their reply):

Windbond W83795AG, Slave Address=0x2e (0x5c in 8-Bit format)
==============================Fan1/CPU Fan Speed, Offset 0x2e         RPM = 84375/Data
Fan2 Fan Speed, Offset 0x2f             RPM = 84375/Data
Fan3 Fan Speed, Offset 0x30             RPM = 84375/Data
Fan4 Fan Speed, Offset 0x31             RPM = 84375/Data
Fan5 Fan Speed, Offset 0x32             RPM = 84375/Data
Fan6 Fan Speed, Offset 0x33             RPM = 84375/Data
CPU Voltage, Offset 0x10                Voltage = Data* 0.008
DIMM Voltage, Offset 0x12               Voltage = Data* 0.008
+5V Voltage, Offset 0x13                Voltage = Data* 0.008 * (40/10)
+12V Voltage, Offset 0x14               Voltage = Data* 0.008/(10./66.2)
-12V Voltage, Offset 0x15               Voltage = ((Data*0.008-2.048)/Fact)+2.048
+3.3V Voltage, Offset 0x1c              Voltage = Data* 0.024
+3.3VSB Voltage, Offset 0x1d            Voltage = Data* 0.024
Battery Voltage, Offset 0x1e            Voltage = Data* 0.024
CPU Temperature, Offset 0x26            Temperature = Data
System Temperature, Offset 0x20         Temperature = Data

Chassis Intrusion, Bank 0, Offset 0x46, BitMask 0x40    1 = Bad, 0 Good
                        (Clear Bit: Bank 0, Offset 0x4d, BitMask 0x80)

Power Supply Failure, GP31(From W83627DHG-P)    1 = Good, 0 = Bad

Is there any way to access the last two?  Do we export the GPIO pins of
these chips through sysfs at all?

Also, I am wondering what they mean with "Fact" in the -12V reading.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [patch 01/36] hwmon: New driver for the

[Henrique de Moraes Holschuh]

On Mon, 27 Sep 2010, Henrique de Moraes Holschuh wrote:
> Chassis Intrusion, Bank 0, Offset 0x46, BitMask 0x40    1 = Bad, 0 > Good
>                         (Clear Bit: Bank 0, Offset 0x4d, BitMask 0x80)
> 
> Power Supply Failure, GP31(From W83627DHG-P)    1 = Good, 0 = Bad

[...]
> Is there any way to access the last two?  Do we export the GPIO pins of
> these chips through sysfs at all?

Bah, yes, we do. It's all there in sysfs, at least for the first one...

> Also, I am wondering what they mean with "Fact" in the -12V reading.

I've asked them about it, I hope they will answer.  All other readings from
the new module are matching fine with SuperODoctor (SuperMicro's userspace
monitoring application/driver through i2c-dev).

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors