All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: "Ohad Ben-Cohen" <ohad@wizery.com>,
	"Michał Mirosław" <mirqus@gmail.com>,
	"Kalle Valo" <kalle.valo@iki.fi>,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	akpm@linux-foundation.org, "Nicolas Pitre" <nico@fluxnic.net>,
	linux-mmc@vger.kernel.org,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
	linux-wireless@vger.kernel.org, "San Mehat" <san@google.com>,
	"Roger Quadros" <roger.quadros@nokia.com>,
	"Chikkature Rajashekar Madhusudhan" <madhu.cr@ti.com>,
	"Luciano Coelho" <luciano.coelho@nokia.com>,
	linux-omap@vger.kernel.org, "Ido Yariv" <ido@wizery.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 3/7] wireless: wl12xx: add platform data passing support
Date: Wed, 15 Sep 2010 09:39:39 -0700	[thread overview]
Message-ID: <20100915163939.GU8647@atomide.com> (raw)
In-Reply-To: <AANLkTikSP874gnsPrc_M1LJYNpjX+Lz3-5=Bk5_HtgP+@mail.gmail.com>

* Vitaly Wool <vitalywool@gmail.com> [100915 01:18]:
> 2010/9/15 Ohad Ben-Cohen <ohad@wizery.com>:
> >> Sorry for pushing at this, but why would you mark data that's meant to
> >> be used after init phase as __initdata?
> >
> > I can remove the first copying as well if Russell is ok with it.
> 
> I personally think it's not worth it. This copying basically happens
> only once and this point is soooo irrelevant. My position therefore
> is: let's get the current implementation in, and if Michal is
> uncomfortable with that, he can come up with the patch. Let's
> concentrate on the real problems.

This becomes an issue when compiling in support for multiple
boards.. All the data that's not in use for the booted board
should be __initdata.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/7] wireless: wl12xx: add platform data passing support
Date: Wed, 15 Sep 2010 09:39:39 -0700	[thread overview]
Message-ID: <20100915163939.GU8647@atomide.com> (raw)
In-Reply-To: <AANLkTikSP874gnsPrc_M1LJYNpjX+Lz3-5=Bk5_HtgP+@mail.gmail.com>

* Vitaly Wool <vitalywool@gmail.com> [100915 01:18]:
> 2010/9/15 Ohad Ben-Cohen <ohad@wizery.com>:
> >> Sorry for pushing at this, but why would you mark data that's meant to
> >> be used after init phase as __initdata?
> >
> > I can remove the first copying as well if Russell is ok with it.
> 
> I personally think it's not worth it. This copying basically happens
> only once and this point is soooo irrelevant. My position therefore
> is: let's get the current implementation in, and if Michal is
> uncomfortable with that, he can come up with the patch. Let's
> concentrate on the real problems.

This becomes an issue when compiling in support for multiple
boards.. All the data that's not in use for the booted board
should be __initdata.

Regards,

Tony

  reply	other threads:[~2010-09-15 16:40 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 21:26 [PATCH v5 0/7] native wl1271 support on ZOOM Ohad Ben-Cohen
2010-09-01 21:26 ` Ohad Ben-Cohen
2010-09-01 21:26 ` Ohad Ben-Cohen
2010-09-01 21:26 ` [PATCH v5 1/7] wireless: wl1271: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-01 21:26 ` [PATCH v5 2/7] wireless: wl1271: support return value for the set power func Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-01 21:26 ` [PATCH v5 3/7] wireless: wl12xx: add platform data passing support Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
     [not found]   ` <1283376410-9999-4-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2010-09-04 12:23     ` Michał Mirosław
2010-09-04 12:23       ` Michał Mirosław
2010-09-04 12:23       ` Michał Mirosław
2010-09-06 11:55       ` Ohad Ben-Cohen
2010-09-06 11:55         ` Ohad Ben-Cohen
2010-09-06 11:55         ` Ohad Ben-Cohen
     [not found]       ` <AANLkTi=goLEUqM1XQ__PrGu4=Erw2utaNP4qFmSgRta2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-06 12:07         ` Russell King - ARM Linux
2010-09-06 12:07           ` Russell King - ARM Linux
2010-09-06 12:07           ` Russell King - ARM Linux
2010-09-06 13:46           ` Ohad Ben-Cohen
2010-09-06 13:46             ` Ohad Ben-Cohen
2010-09-06 19:42           ` Michał Mirosław
2010-09-06 19:42             ` Michał Mirosław
2010-09-15  8:00             ` Ohad Ben-Cohen
2010-09-15  8:00               ` Ohad Ben-Cohen
     [not found]               ` <AANLkTinM8vY7CygEN6DBR35WLkU-QOBwuiaRrpfwF6Mz-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-15  8:27                 ` Vitaly Wool
2010-09-15  8:27                   ` Vitaly Wool
2010-09-15  8:27                   ` Vitaly Wool
2010-09-15 16:39                   ` Tony Lindgren [this message]
2010-09-15 16:39                     ` Tony Lindgren
2010-09-15  8:25             ` Russell King - ARM Linux
2010-09-15  8:25               ` Russell King - ARM Linux
2010-09-15 16:10               ` Michał Mirosław
2010-09-15 16:10                 ` Michał Mirosław
2010-09-01 21:26 ` [PATCH v5 4/7] wireless: wl1271: take irq info from private board data Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
     [not found] ` <1283376410-9999-1-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2010-09-01 21:26   ` [PATCH v5 5/7] wireless: wl1271: make ref_clock configurable by board Ohad Ben-Cohen
2010-09-01 21:26     ` Ohad Ben-Cohen
2010-09-01 21:26     ` Ohad Ben-Cohen
2010-09-01 21:26   ` [PATCH v5 6/7] omap: zoom: add fixed regulator device for wlan Ohad Ben-Cohen
2010-09-01 21:26     ` Ohad Ben-Cohen
2010-09-01 21:26     ` Ohad Ben-Cohen
2010-09-01 21:26 ` [PATCH v5 7/7] omap: zoom: add mmc3/wl1271 device support Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-01 21:26   ` Ohad Ben-Cohen
2010-09-15  9:21 ` [PATCH v5 0/7] native wl1271 support on ZOOM Ohad Ben-Cohen
2010-09-15  9:21   ` Ohad Ben-Cohen
     [not found]   ` <AANLkTikedoL3HjohQfq2qa0TU5yMJR5p1GqyQJtQGrdb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-15 11:08     ` Vitaly Wool
2010-09-15 11:08       ` Vitaly Wool
2010-09-15 11:08       ` Vitaly Wool
2010-09-15 13:21       ` John W. Linville
2010-09-15 13:21         ` John W. Linville
2010-09-15 16:34         ` Tony Lindgren
2010-09-15 16:34           ` Tony Lindgren
2010-09-15 16:46           ` Ohad Ben-Cohen
2010-09-15 16:46             ` Ohad Ben-Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100915163939.GU8647@atomide.com \
    --to=tony@atomide.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=ido@wizery.com \
    --cc=kalle.valo@iki.fi \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=luciano.coelho@nokia.com \
    --cc=madhu.cr@ti.com \
    --cc=mirqus@gmail.com \
    --cc=nico@fluxnic.net \
    --cc=ohad@wizery.com \
    --cc=roger.quadros@nokia.com \
    --cc=san@google.com \
    --cc=vitalywool@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.