From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Tejun Heo <tj@kernel.org>
Cc: "Linux-pm mailing list" <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: [RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating PM workqueue
Date: Wed, 15 Sep 2010 21:56:30 +0200 [thread overview]
Message-ID: <201009152156.30749.rjw@sisk.pl> (raw)
From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: PM / Runtime: Use alloc_workqueue() for creating PM workqueue
Although we need the PM workqueue to be freezable, we don't need it
to be singlethread. Also, the number of concurrent work items
running on a single CPU need not be constrained. For these reasons
use alloc_workqueue() directly, with suitable arguments, instead of
create_freezeable_workqueue(), to create the runtime PM workqueue.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
Tejun,
I'm not sure about that WQ_RESCUER thing. Can you please tell me what
exactly it is for?
Thanks,
Rafael
---
kernel/power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/kernel/power/main.c
===================================================================
--- linux-2.6.orig/kernel/power/main.c
+++ linux-2.6/kernel/power/main.c
@@ -308,7 +308,7 @@ EXPORT_SYMBOL_GPL(pm_wq);
static int __init pm_start_workqueue(void)
{
- pm_wq = create_freezeable_workqueue("pm");
+ pm_wq = alloc_workqueue("pm", WQ_FREEZEABLE | WQ_RESCUER, 0);
return pm_wq ? 0 : -ENOMEM;
}
next reply other threads:[~2010-09-15 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 19:56 Rafael J. Wysocki [this message]
2010-09-16 8:11 ` [RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating PM workqueue Tejun Heo
2010-09-16 18:24 ` Rafael J. Wysocki
2010-09-16 18:24 ` Rafael J. Wysocki
2010-09-17 9:57 ` Tejun Heo
2010-09-17 9:57 ` Tejun Heo
2010-09-16 8:11 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2010-09-15 19:56 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009152156.30749.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.