All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating PM workqueue
Date: Thu, 16 Sep 2010 10:11:30 +0200	[thread overview]
Message-ID: <4C91D132.6090607@kernel.org> (raw)
In-Reply-To: <201009152156.30749.rjw@sisk.pl>

Hello, Rafael.

On 09/15/2010 09:56 PM, Rafael J. Wysocki wrote:
> I'm not sure about that WQ_RESCUER thing.  Can you please tell me what
> exactly it is for?

It's to guarantee forward progress for workqueues which process work
items which may be used to reclaim memory.  It reserves a rescue
worker thread to be used under memory pressure.  I finished workqueue
documentation a few days ago and sent pull request to Linus.

  http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f

So, for pm_wq, there's no reason to use WQ_RESUER.
alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Thanks for doing it.

-- 
tejun

  parent reply	other threads:[~2010-09-16  8:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-15 19:56 [RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating PM workqueue Rafael J. Wysocki
2010-09-16  8:11 ` Tejun Heo
2010-09-16  8:11 ` Tejun Heo [this message]
2010-09-16 18:24   ` Rafael J. Wysocki
2010-09-17  9:57     ` Tejun Heo
2010-09-17  9:57       ` Tejun Heo
2010-09-16 18:24   ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2010-09-15 19:56 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C91D132.6090607@kernel.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.