From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
catalin.marinas@arm.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable
Date: Wed, 15 Sep 2010 17:21:35 -0700 [thread overview]
Message-ID: <20100916002134.GL4174@atomide.com> (raw)
In-Reply-To: <1283846243-11600-4-git-send-email-santosh.shilimkar@ti.com>
* Santosh Shilimkar <santosh.shilimkar@ti.com> [100907 00:50]:
> The machine_kexec() calls outer_disable which can crash on OMAP4
> becasue of trustzone restrictions.
>
> This patch overrides the default l2x0_disable with a OMAP4
> specific implementation taking care of trustzone
<snip>
> @@ -66,6 +73,12 @@ static int __init omap_l2_cache_init(void)
>
> */
> l2x0_init(l2cache_base, 0x0e050000, 0xc0000fff);
>
> + /*
> + * Override default outer_cache.disable with a OMAP4
> + * specific one
> + */
> + outer_cache.disable = omap4_l2x0_disable;
> +
> return 0;
> }
> early_initcall(omap_l2_cache_init);
Just to be sure.. No outer_cache functions get set unless
l2x0_init gets called, right? So omap2 and omap3 functions
always stay NULL with omap3_defconfig?
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable
Date: Wed, 15 Sep 2010 17:21:35 -0700 [thread overview]
Message-ID: <20100916002134.GL4174@atomide.com> (raw)
In-Reply-To: <1283846243-11600-4-git-send-email-santosh.shilimkar@ti.com>
* Santosh Shilimkar <santosh.shilimkar@ti.com> [100907 00:50]:
> The machine_kexec() calls outer_disable which can crash on OMAP4
> becasue of trustzone restrictions.
>
> This patch overrides the default l2x0_disable with a OMAP4
> specific implementation taking care of trustzone
<snip>
> @@ -66,6 +73,12 @@ static int __init omap_l2_cache_init(void)
>
> */
> l2x0_init(l2cache_base, 0x0e050000, 0xc0000fff);
>
> + /*
> + * Override default outer_cache.disable with a OMAP4
> + * specific one
> + */
> + outer_cache.disable = omap4_l2x0_disable;
> +
> return 0;
> }
> early_initcall(omap_l2_cache_init);
Just to be sure.. No outer_cache functions get set unless
l2x0_init gets called, right? So omap2 and omap3 functions
always stay NULL with omap3_defconfig?
Tony
next prev parent reply other threads:[~2010-09-16 0:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 7:57 [PATCH 0/6] ARM: l2x0: kexex, cleanup and optimisation Santosh Shilimkar
2010-09-07 7:57 ` Santosh Shilimkar
2010-09-07 7:57 ` [PATCH 1/6] arm: Disable outer (L2) cache in kexec Santosh Shilimkar
2010-09-07 7:57 ` [PATCH 2/6] arm: Implement l2x0 cache disable functions Santosh Shilimkar
2010-09-07 7:57 ` [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable Santosh Shilimkar
2010-09-07 7:57 ` Santosh Shilimkar
2010-09-07 7:57 ` [PATCH 4/6] ARM: l2x0: Fix coding-style in the cache-l2x0.h Santosh Shilimkar
2010-09-07 7:57 ` Santosh Shilimkar
2010-09-07 7:57 ` [PATCH 5/6] ARM: l2x0: Determine the cache size Santosh Shilimkar
2010-09-07 7:57 ` Santosh Shilimkar
2010-09-07 7:57 ` [PATCH 6/6] ARM: l2x0: Optimise the range based operations Santosh Shilimkar
2010-09-07 7:57 ` Santosh Shilimkar
2010-10-04 21:22 ` Russell King - ARM Linux
2010-10-04 21:22 ` Russell King - ARM Linux
2010-10-05 4:54 ` Shilimkar, Santosh
2010-10-05 4:54 ` Shilimkar, Santosh
2010-10-06 5:12 ` Shilimkar, Santosh
2010-10-06 5:12 ` Shilimkar, Santosh
2012-06-18 17:41 ` Antti P Miettinen
2010-09-16 0:21 ` Tony Lindgren [this message]
2010-09-16 0:21 ` [PATCH 3/6] omap4: l2x0: Override the default l2x0_disable Tony Lindgren
2010-09-16 5:56 ` Shilimkar, Santosh
2010-09-16 5:56 ` Shilimkar, Santosh
2010-09-07 18:18 ` [PATCH 0/6] ARM: l2x0: kexex, cleanup and optimisation Linus Walleij
2010-09-07 18:18 ` Linus Walleij
2010-09-08 7:34 ` Shilimkar, Santosh
2010-09-08 7:34 ` Shilimkar, Santosh
2010-09-08 12:35 ` Linus Walleij
2010-09-08 12:35 ` Linus Walleij
2010-09-08 15:01 ` Catalin Marinas
2010-09-08 15:01 ` Catalin Marinas
2010-09-08 15:09 ` Shilimkar, Santosh
2010-09-08 15:09 ` Shilimkar, Santosh
2010-09-08 15:25 ` Catalin Marinas
2010-09-08 15:25 ` Catalin Marinas
2010-09-08 15:29 ` Shilimkar, Santosh
2010-09-08 15:29 ` Shilimkar, Santosh
2010-09-08 15:46 ` Shilimkar, Santosh
2010-09-08 15:46 ` Shilimkar, Santosh
2010-09-08 15:49 ` Catalin Marinas
2010-09-08 15:49 ` Catalin Marinas
2010-09-09 5:18 ` Shilimkar, Santosh
2010-09-09 5:18 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916002134.GL4174@atomide.com \
--to=tony@atomide.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.