From: Tony Lindgren <tony@atomide.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-arm-kernel@lists.infradead.org,
Chikkature Rajashekar Madhusudhan <madhu.cr@ti.com>,
Luciano Coelho <luciano.coelho@nokia.com>,
San Mehat <san@google.com>,
Roger Quadros <roger.quadros@nokia.com>,
Nicolas Pitre <nico@fluxnic.net>, Ido Yariv <ido@wizery.com>,
Kalle Valo <kalle.valo@iki.fi>,
Russell King <linux@arm.linux.org.uk>,
Vitaly Wool <vitalywool@gmail.com>
Subject: Re: [PATCH v6 6/7] omap: zoom: add fixed regulator device for wlan
Date: Thu, 16 Sep 2010 10:44:31 -0700 [thread overview]
Message-ID: <20100916174431.GC29610@atomide.com> (raw)
In-Reply-To: <1284593529-30100-1-git-send-email-ohad@wizery.com>
* Ohad Ben-Cohen <ohad@wizery.com> [100915 16:23]:
> Add a fixed regulator vmmc device to enable power control
> of the wl1271 wlan device.
<snip>
> +static struct fixed_voltage_config zoom_vwlan = {
> + .supply_name = "vwl1271",
> + .microvolts = 1800000, /* 1.8V */
> + .gpio = OMAP_ZOOM_WLAN_PMENA_GPIO,
> + .startup_delay = 70000, /* 70msec */
> + .enable_high = 1,
> + .enabled_at_boot = 0,
> + .init_data = &zoom_vmmc3,
> +};
These are usually aligned with tabs before the = sign.
> +static struct platform_device omap_vwlan_device = {
> + .name = "reg-fixed-voltage",
> + .id = 1,
> + .dev = {
> + .platform_data = &zoom_vwlan,
> + },
> +};
Like in this struct.
After that's fixed, here's my ack for these to go via the
wireless tree:
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 6/7] omap: zoom: add fixed regulator device for wlan
Date: Thu, 16 Sep 2010 10:44:31 -0700 [thread overview]
Message-ID: <20100916174431.GC29610@atomide.com> (raw)
In-Reply-To: <1284593529-30100-1-git-send-email-ohad@wizery.com>
* Ohad Ben-Cohen <ohad@wizery.com> [100915 16:23]:
> Add a fixed regulator vmmc device to enable power control
> of the wl1271 wlan device.
<snip>
> +static struct fixed_voltage_config zoom_vwlan = {
> + .supply_name = "vwl1271",
> + .microvolts = 1800000, /* 1.8V */
> + .gpio = OMAP_ZOOM_WLAN_PMENA_GPIO,
> + .startup_delay = 70000, /* 70msec */
> + .enable_high = 1,
> + .enabled_at_boot = 0,
> + .init_data = &zoom_vmmc3,
> +};
These are usually aligned with tabs before the = sign.
> +static struct platform_device omap_vwlan_device = {
> + .name = "reg-fixed-voltage",
> + .id = 1,
> + .dev = {
> + .platform_data = &zoom_vwlan,
> + },
> +};
Like in this struct.
After that's fixed, here's my ack for these to go via the
wireless tree:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2010-09-16 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 23:32 [PATCH v6 6/7] omap: zoom: add fixed regulator device for wlan Ohad Ben-Cohen
2010-09-15 23:32 ` Ohad Ben-Cohen
2010-09-15 23:32 ` Ohad Ben-Cohen
2010-09-16 17:44 ` Tony Lindgren [this message]
2010-09-16 17:44 ` Tony Lindgren
[not found] ` <20100916174431.GC29610-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-09-16 19:47 ` Ohad Ben-Cohen
2010-09-16 19:47 ` Ohad Ben-Cohen
2010-09-16 19:47 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916174431.GC29610@atomide.com \
--to=tony@atomide.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ido@wizery.com \
--cc=kalle.valo@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linville@tuxdriver.com \
--cc=luciano.coelho@nokia.com \
--cc=madhu.cr@ti.com \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.