From: Andrea Arcangeli <aarcange@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] fix swapin race condition
Date: Thu, 16 Sep 2010 23:08:35 +0200 [thread overview]
Message-ID: <20100916210835.GV5981@random.random> (raw)
In-Reply-To: <20100916210349.GU5981@random.random>
On Thu, Sep 16, 2010 at 11:03:49PM +0200, Andrea Arcangeli wrote:
> If I'm missing something a trace of the exact scenario would help to
> clarify your point.
Also supposing I'm right, I wouldn't mind if you add a
VM_BUG_ON(page_private(page) != entry.val) in the "pte_same == true"
path, just to be sure the invariant page_private(page) ==
pte_to_swp_entry(*page_table) doesn't ever break in a unnoticed way in
the future (I think it's unlikely to ever break but a VM_BUG_ON is
zero cost in production and it'll clarify the invariant). If instead
I'm wrong then just ahead fix it and I'll ack :).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-16 21:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 15:39 [PATCH] fix swapin race condition Andrea Arcangeli
2010-09-03 20:02 ` Andrew Morton
2010-09-04 12:29 ` Andrea Arcangeli
2010-09-03 23:57 ` Rik van Riel
2010-09-06 2:35 ` Hugh Dickins
2010-09-15 23:02 ` Hugh Dickins
2010-09-15 23:42 ` Andrea Arcangeli
2010-09-16 0:10 ` Hugh Dickins
2010-09-16 21:03 ` Andrea Arcangeli
2010-09-16 21:08 ` Andrea Arcangeli [this message]
2010-09-17 2:31 ` Hugh Dickins
2010-09-18 13:19 ` Andrea Arcangeli
2010-09-20 2:35 ` Hugh Dickins
2010-09-20 2:40 ` [PATCH] mm: further " Hugh Dickins
2010-09-20 2:40 ` Hugh Dickins
2010-09-20 3:09 ` Rik van Riel
2010-09-20 3:09 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2010-07-09 0:23 [PATCH] " Andrea Arcangeli
2010-07-09 20:32 ` Hugh Dickins
2010-07-09 21:19 ` Hugh Dickins
2010-07-09 22:02 ` Rik van Riel
2010-07-13 1:08 ` Andrea Arcangeli
2010-07-13 21:30 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916210835.GV5981@random.random \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.