Re: [PATCH] fix swapin race condition

[Rik van Riel <riel@redhat.com>]

On 07/09/2010 04:32 PM, Hugh Dickins wrote:

>>   	struct anon_vma *anon_vma = page_anon_vma(page);
>>
>> -	if (!anon_vma ||
>> -	    (anon_vma->root == vma->anon_vma->root&&
>> -	     page->index == linear_page_index(vma, address)))
>> -		return page;
>> -
>> -	return ksm_does_need_to_copy(page, vma, address);
>> +	return anon_vma&&
>> +		(anon_vma->root != vma->anon_vma->root ||
>> +		 page->index != linear_page_index(vma, address));
>>   }
>
> Hiding in here is a bigger question than your concern:
> are these tests right since Rik refactored the anon_vmas?
> I just don't know, but hope you and Rik can answer.

Yes, this bit is correct.  Andrea and I have gone over
this in detail a few weeks ago :)

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>