All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Kyungmin Park <kmpark@infradead.org>
Cc: "Jeongbae Seo" <jeongbae.seo@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
	ben-linux@fluff.org, kgene.kim@samsung.com,
	akpm@linux-foundation.org, "Hyuk Lee" <hyuk1.lee@samsung.com>,
	정재훈 <jh80.chung@samsung.com>
Subject: Re: [PATCH 5/5] sdhci-s3c: Add support no internal clock divider in host controller
Date: Fri, 17 Sep 2010 16:59:28 +0100	[thread overview]
Message-ID: <20100917155928.GA7561@void.printf.net> (raw)
In-Reply-To: <AANLkTik23B23RW_kmjaL1PeXNiWtU01aNBwUOPrac6HF@mail.gmail.com>

Hi,

On Thu, Sep 16, 2010 at 06:08:28PM +0900, Kyungmin Park wrote:
> Well there are two implementations. and no conclusion yet.
> as s5pc210 don't support internal SDHCI clock, DMC overrides the
> function operation itself when s5pc210. System LSI use the quirks.
> 
> Choose any one from MMC maintainer.

Both approaches are generally acceptable for MMC, so I would want to
leave it up to the maintainer of the driver in question (which is Ben,
in this case?) to choose between them.

That said, I think my own mild preference is for Jaehoon's approach.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] sdhci-s3c: Add support no internal clock divider in host controller
Date: Fri, 17 Sep 2010 16:59:28 +0100	[thread overview]
Message-ID: <20100917155928.GA7561@void.printf.net> (raw)
In-Reply-To: <AANLkTik23B23RW_kmjaL1PeXNiWtU01aNBwUOPrac6HF@mail.gmail.com>

Hi,

On Thu, Sep 16, 2010 at 06:08:28PM +0900, Kyungmin Park wrote:
> Well there are two implementations. and no conclusion yet.
> as s5pc210 don't support internal SDHCI clock, DMC overrides the
> function operation itself when s5pc210. System LSI use the quirks.
> 
> Choose any one from MMC maintainer.

Both approaches are generally acceptable for MMC, so I would want to
leave it up to the maintainer of the driver in question (which is Ben,
in this case?) to choose between them.

That said, I think my own mild preference is for Jaehoon's approach.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2010-09-17 15:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16  8:36 [PATCH 0/5] ARM: S5PV310: Add support HSMMC for S5PV310/S5PC210 Jeongbae Seo
2010-09-16  8:36 ` Jeongbae Seo
2010-09-16  8:36 ` [PATCH 1/5] ARM: S5PV310: Add HSMMC support and SDHCI configuration Jeongbae Seo
2010-09-16  8:36   ` Jeongbae Seo
2010-09-16  9:13   ` Kyungmin Park
2010-09-16  9:13     ` Kyungmin Park
2010-09-17  0:57     ` Kukjin Kim
2010-09-17  0:57       ` Kukjin Kim
2010-09-17  4:15       ` Kyungmin Park
2010-09-17  4:15         ` Kyungmin Park
2010-10-04 11:03   ` Marek Szyprowski
2010-10-04 11:03     ` Marek Szyprowski
2010-10-05  6:58     ` Jeongbae Seo
2010-10-05  6:58       ` Jeongbae Seo
2010-09-16  8:37 ` [PATCH 2/5] ARM: S5PV310: Add HSMMC support into S5PV310 and S5PC210 Jeongbae Seo
2010-09-16  8:37   ` Jeongbae Seo
2010-10-04 11:02   ` Marek Szyprowski
2010-10-04 11:02     ` Marek Szyprowski
2010-10-05  6:46     ` Jeongbae Seo
2010-10-05  6:46       ` Jeongbae Seo
2010-09-16  8:37 ` [PATCH 3/5] ARM: SAMSUNG: Modified to change of bus width and host caps Jeongbae Seo
2010-09-16  8:37   ` Jeongbae Seo
2010-09-16  8:37 ` [PATCH 4/5] ARM: SAMSUNG: Add clock types into platform data Jeongbae Seo
2010-09-16  8:37   ` Jeongbae Seo
2010-09-16  8:37 ` [PATCH 5/5] sdhci-s3c: Add support no internal clock divider in host controller Jeongbae Seo
2010-09-16  8:37   ` Jeongbae Seo
2010-09-16  9:08   ` Kyungmin Park
2010-09-16  9:08     ` Kyungmin Park
2010-09-17  1:18     ` Kukjin Kim
2010-09-17  1:18       ` Kukjin Kim
2010-09-17 15:59     ` Chris Ball [this message]
2010-09-17 15:59       ` Chris Ball
2010-09-30  1:18       ` Kyungmin Park
2010-09-30  1:18         ` Kyungmin Park
2010-09-30  1:51         ` Chris Ball
2010-09-30  1:51           ` Chris Ball
2010-09-30  5:40           ` Jeongbae Seo
2010-09-30  5:40             ` Jeongbae Seo
2010-09-30  6:00             ` Kyungmin Park
2010-09-30  6:00               ` Kyungmin Park
2010-09-17  1:22   ` Kukjin Kim
2010-09-17  1:22     ` Kukjin Kim
2010-09-17  2:39     ` ???
2010-09-17  2:39       ` ???

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100917155928.GA7561@void.printf.net \
    --to=cjb@laptop.org \
    --cc=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=hyuk1.lee@samsung.com \
    --cc=jeongbae.seo@samsung.com \
    --cc=jh80.chung@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kmpark@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.