* odd gfn number checking in p2m.c
@ 2010-09-19 15:49 Olaf Hering
2010-09-19 16:41 ` Keir Fraser
0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2010-09-19 15:49 UTC (permalink / raw)
To: xen-devel
Hello,
how can a gfn become 0x555555 as checked in
p2m.c:guest_physmap_add_entry() and p2m_alloc_table()?
Looking further in p2m.c, audit_p2m() checks only for a 32bit value.
So where is that magic number set, and why is it not a define to
simplify grepping for users of that value?
Olaf
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: odd gfn number checking in p2m.c
2010-09-19 15:49 odd gfn number checking in p2m.c Olaf Hering
@ 2010-09-19 16:41 ` Keir Fraser
0 siblings, 0 replies; 2+ messages in thread
From: Keir Fraser @ 2010-09-19 16:41 UTC (permalink / raw)
To: Olaf Hering, xen-devel@lists.xensource.com
I think the 0x55555 checks are a bit of a hack. It just happens to be the
value we initialise the m2p table to at boot time. Afaik we don't initialise
free mfns back to 0x555...55 in the m2p, so over time that value will become
less frequent in the m2p.
-- Keir
On 19/09/2010 16:49, "Olaf Hering" <olaf@aepfle.de> wrote:
>
> Hello,
>
> how can a gfn become 0x555555 as checked in
> p2m.c:guest_physmap_add_entry() and p2m_alloc_table()?
> Looking further in p2m.c, audit_p2m() checks only for a 32bit value.
>
> So where is that magic number set, and why is it not a define to
> simplify grepping for users of that value?
>
> Olaf
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-19 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-19 15:49 odd gfn number checking in p2m.c Olaf Hering
2010-09-19 16:41 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.