From: Pavel Machek <pavel@ucw.cz>
To: Pekka Enberg <penberg@kernel.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
Lars Lindley <lindley@coyote.org>,
Ruslan Pisarev <ruslan@rpisarev.org.ua>
Subject: Re: [PATCH 1/7] w35und: Kill dead HAL macros in wbhal_f.h
Date: Sun, 19 Sep 2010 23:42:27 +0200 [thread overview]
Message-ID: <20100919214227.GC12416@elf.ucw.cz> (raw)
In-Reply-To: <1284888523-9625-1-git-send-email-penberg@kernel.org>
Hi!
> Fixes an uninitialized variable access in _rx_iq_calibration_loop_winbond():
>
> CC [M] drivers/staging/winbond/phy_calibration.o
> drivers/staging/winbond/phy_calibration.c: In function ???_rx_iq_calibration_loop_winbond???:
> drivers/staging/winbond/phy_calibration.c:1138: warning: ???val??? is used uninitialized in this function
>
Are you sure this is correct?
> @@ -1132,18 +1132,6 @@ u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 fre
> PHY_DEBUG(("[CAL] -> [5]_rx_iq_calibration_loop()\n"));
> PHY_DEBUG(("[CAL] ** factor = %d\n", factor));
>
> -
> -/* RF Control Override */
> - hw_get_cxx_reg(phw_data, 0x80, &val);
> - val |= BIT(19);
> - hw_set_cxx_reg(phw_data, 0x80, val);
> -
We pass pointer to val somewhere, set a bit, write it back. Seems ok
to me...?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-09-19 21:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 9:28 [PATCH 1/7] w35und: Kill dead HAL macros in wbhal_f.h Pekka Enberg
2010-09-19 9:28 ` [PATCH 2/7] w35und: Remove remaining typedef declarations Pekka Enberg
2010-09-19 9:28 ` [PATCH 3/7] w35und: Kill unused scan_s.h header Pekka Enberg
2010-09-19 9:28 ` [PATCH 4/7] w35und: Remove dead code from mlme_s.h Pekka Enberg
2010-09-19 9:28 ` [PATCH 5/7] w35und: Inline mlme_s.h to core.h Pekka Enberg
2010-09-19 9:28 ` [PATCH 6/7] w35und: Remove unused spinlocks Pekka Enberg
2010-09-19 9:28 ` [PATCH 7/7] w35und: Remove unused fields from struct wbsoft_priv Pekka Enberg
2010-09-19 21:43 ` [PATCH 2/7] w35und: Remove remaining typedef declarations Pavel Machek
2010-09-19 21:42 ` Pavel Machek [this message]
2010-09-19 21:43 ` [PATCH 1/7] w35und: Kill dead HAL macros in wbhal_f.h Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100919214227.GC12416@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=ruslan@rpisarev.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.