All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Yang Ruirui <ruirui.r.yang@tieto.com>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com, hch@infradead.org,
	Alex Elder <aelder@sgi.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: -mm: xfs lockdep warning
Date: Mon, 20 Sep 2010 15:13:55 -0400	[thread overview]
Message-ID: <20100920191355.GA28443@infradead.org> (raw)
In-Reply-To: <20100917005227.GJ24409@dastard>

On Fri, Sep 17, 2010 at 10:52:27AM +1000, Dave Chinner wrote:
> Christoph, this implies an inode that has been marked for reclaim
> that has not passed through xfs_fs_evict_inode() after being
> initialised. If it went through the eviction process, the iolock
> would have been re-initialised to a different context. Can you think
> of any path that can get here without going through ->evict? I can't
> off the top of my head...

I think this could happen if the init_inode_always during
re-initialization of an inode in reclaim fails in iget.  I have a patch
to add that I'll run through xfsqa.  It should only happen very rarely.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Yang Ruirui <ruirui.r.yang@tieto.com>,
	hch@infradead.org, Andrew Morton <akpm@linux-foundation.org>,
	xfs@oss.sgi.com, linux-kernel@vger.kernel.org,
	Alex Elder <aelder@sgi.com>
Subject: Re: -mm: xfs lockdep warning
Date: Mon, 20 Sep 2010 15:13:55 -0400	[thread overview]
Message-ID: <20100920191355.GA28443@infradead.org> (raw)
In-Reply-To: <20100917005227.GJ24409@dastard>

On Fri, Sep 17, 2010 at 10:52:27AM +1000, Dave Chinner wrote:
> Christoph, this implies an inode that has been marked for reclaim
> that has not passed through xfs_fs_evict_inode() after being
> initialised. If it went through the eviction process, the iolock
> would have been re-initialised to a different context. Can you think
> of any path that can get here without going through ->evict? I can't
> off the top of my head...

I think this could happen if the init_inode_always during
re-initialization of an inode in reclaim fails in iget.  I have a patch
to add that I'll run through xfsqa.  It should only happen very rarely.


  reply	other threads:[~2010-09-20 19:13 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16  7:46 -mm: xfs lockdep warning Yang Ruirui
2010-09-16  7:46 ` Yang Ruirui
2010-09-17  0:52 ` Dave Chinner
2010-09-17  0:52   ` Dave Chinner
2010-09-20 19:13   ` Christoph Hellwig [this message]
2010-09-20 19:13     ` Christoph Hellwig
2010-09-25 13:08     ` Torsten Kaiser
2010-09-25 13:08       ` Torsten Kaiser
2010-10-04  9:01       ` Tejun Heo
2010-10-04  9:01         ` Tejun Heo
2010-10-04  9:21         ` Dave Chinner
2010-10-04  9:21           ` Dave Chinner
2010-10-05 10:09           ` Torsten Kaiser
2010-10-05 10:09             ` Torsten Kaiser
2010-10-05 16:51             ` Tejun Heo
2010-10-05 16:51               ` Tejun Heo
2010-10-05 16:55               ` Tejun Heo
2010-10-05 16:55                 ` Tejun Heo
2010-10-05 18:09                 ` Torsten Kaiser
2010-10-05 18:09                   ` Torsten Kaiser
2010-10-05 18:17                   ` Christoph Hellwig
2010-10-05 18:17                     ` Christoph Hellwig
2010-10-05 17:54               ` Torsten Kaiser
2010-10-05 17:54                 ` Torsten Kaiser
     [not found]               ` <AANLkTineNfy+hfnK-sjHNB+h05oC4qbJ+81pg95Bmn=b@mail.gmail.com>
     [not found]                 ` <4CAC366E.7070609@kernel.org>
     [not found]                   ` <4CAC38D9.8020407@kernel.org>
     [not found]                     ` <AANLkTikw=ObzgWu35fsuriC-jVrzDRHRfFJeT8-4-ndY@mail.gmail.com>
     [not found]                       ` <4CAC934E.2030807@kernel.org>
     [not found]                         ` <AANLkTinrBeMDyQJaYJFALTPpOgEaAy7yoPdyQ0Gpay3G@mail.gmail.com>
     [not found]                           ` <4CACC0CD.5000001@kernel.org>
2010-10-07 11:14                             ` Tejun Heo
2010-10-07 13:21                               ` Torsten Kaiser
2010-10-07 14:05                                 ` Tejun Heo
2010-10-07 15:15                                   ` Torsten Kaiser
2010-10-07 15:41                                     ` Tejun Heo
     [not found]                                       ` <AANLkTi=LnbH7LNUr+YuR+uKLFasKyV7hOZc1zD0qqHnW@mail.gmail.com>
2010-10-08 12:40                                         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100920191355.GA28443@infradead.org \
    --to=hch@infradead.org \
    --cc=aelder@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruirui.r.yang@tieto.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.