All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nadav Har'El" <nyh@math.technion.ac.il>
To: Gleb Natapov <gleb@redhat.com>
Cc: Joerg Roedel <joro@8bytes.org>, Chris Wright <chrisw@redhat.com>,
	kvm@vger.kernel.org, avi@redhat.com
Subject: Re: KVM call minutes for Sept 21
Date: Thu, 23 Sep 2010 01:00:19 +0200	[thread overview]
Message-ID: <20100922230019.GA20148@fermat.math.technion.ac.il> (raw)
In-Reply-To: <20100922201856.GA6274@redhat.com>

On Wed, Sep 22, 2010, Gleb Natapov wrote about "Re: KVM call minutes for Sept 21":
> are reworked even if maintained. Nadav said that he doesn't even know
> how this part of code is working. This is worrying.

Hi,

I just wanted to clarify that reason I don't know exactly how this specific
part of the code works, is because I didn't write it. It doesn't mean that
I think it is so complex that nobody can ever understand it, or that there
is a cause for worry.

The people who wrote this code were convinced (see thread from October 2009,
starting with http://www.mail-archive.com/kvm@vger.kernel.org/msg23898.html)
that their approach was the right thing to do for the IDT_VECTORING_INFO.
Between them being convinced that this is the right way, and you being
convinced that it is the wrong way, I am not (yet) convinced about either
direction. Before I'm quick to simply get rid of this (working) code and
replace it with something else, I need to understand all the little details
involved, and to try to rewrite the code to be more nested-SVM-like and still
work, and to understand how I might test whether it actually works (and
it isn't simply that my workload misses this case altogether). I'll do this.

Nadav.

-- 
Nadav Har'El                        |    Thursday, Sep 23 2010, 15 Tishri 5771
nyh@math.technion.ac.il             |-----------------------------------------
Phone +972-523-790466, ICQ 13349191 |I'm a peripheral visionary: I see into
http://nadav.harel.org.il           |the future, but mostly off to the sides.

  reply	other threads:[~2010-09-22 23:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 18:05 KVM call minutes for Sept 21 Chris Wright
2010-09-21 18:05 ` [Qemu-devel] " Chris Wright
2010-09-21 18:23 ` Anthony Liguori
2010-09-21 18:23   ` [Qemu-devel] " Anthony Liguori
2010-09-22  0:04 ` Nadav Har'El
2010-09-22  1:48   ` Chris Wright
2010-09-22 17:49     ` Nadav Har'El
2010-09-22 18:03       ` Anthony Liguori
2010-09-22 19:34         ` Joerg Roedel
2010-09-22 19:48       ` Joerg Roedel
2010-09-22  9:02   ` Gleb Natapov
2010-09-22 16:29     ` Nadav Har'El
2010-09-22 17:47       ` Gleb Natapov
2010-09-22 19:20         ` Joerg Roedel
2010-09-22 20:18           ` Gleb Natapov
2010-09-22 23:00             ` Nadav Har'El [this message]
2010-09-26 14:03           ` Avi Kivity
2010-09-26 20:25             ` Joerg Roedel
2010-09-27  8:36               ` Avi Kivity
2010-09-27 14:18                 ` Gleb Natapov
2010-09-27 14:22                   ` Avi Kivity
2010-09-26 13:27   ` Avi Kivity
2010-09-26 14:28     ` Nadav Har'El
2010-09-26 14:50       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100922230019.GA20148@fermat.math.technion.ac.il \
    --to=nyh@math.technion.ac.il \
    --cc=avi@redhat.com \
    --cc=chrisw@redhat.com \
    --cc=gleb@redhat.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.