From: Greg KH <greg@kroah.com>
To: Narendra_K@Dell.com
Cc: netdev@vger.kernel.org, linux-hotplug@vger.kernel.org,
linux-pci@vger.kernel.org, Matt_Domsch@Dell.com,
Charles_Rose@Dell.com, Jordan_Hargrave@Dell.com,
Vijay_Nijhawan@Dell.com
Subject: Re: [PATCH] Use firmware provided index to register a network
Date: Thu, 23 Sep 2010 15:27:30 +0000 [thread overview]
Message-ID: <20100923152730.GA1261@kroah.com> (raw)
In-Reply-To: <EDA0A4495861324DA2618B4C45DCB3EE6A0AF8@blrx3m08.blr.amer.dell.com>
On Thu, Sep 23, 2010 at 08:40:44PM +0530, Narendra_K@Dell.com wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah.com]
> > Sent: Thursday, September 23, 2010 12:52 AM
> > To: K, Narendra
> > Cc: netdev@vger.kernel.org; linux-hotplug@vger.kernel.org; linux-
> > pci@vger.kernel.org; Domsch, Matt; Rose, Charles; Hargrave, Jordan;
> > Nijhawan, Vijay
> > Subject: Re: [PATCH] Use firmware provided index to register a network
> > interface
> >
> > On Wed, Sep 22, 2010 at 01:31:38PM -0500, Narendra K wrote:
> > > Hello,
> > >
> > > Here is another approach to address the issue of "eth0 does not
> > always
> > > map to the Integrated NIC Port 1 as denoted on server chassis
> label".
> > > For more details please refer to the thread -
> > > http://marc.info/?l=linux-netdev&m\x128163454631618&w=3.
> > >
> > > Patch makes use of the firmware provided index to derive ethN names.
> > > That way the naming scheme adheres to the existing requirements of
> > > ethN namespace and with IFNAMSIZ length.
> >
> > Ick, again, what's wrong with using udev for this as it is designed
> to?
> > That way no kernel changes are needed, and no one has to rely on the
> > BIOS getting the firmware number right (meaning it will work on all
> > types of systems.)
> >
>
> 1. We tried addressing this issue using udev only and without any kernel
> changes, during Nov-Dec 2008 timeframe using Biosdevname udev helper
> utility. Biosdevname utility has the ability to suggest BIOS intended
> name of an interface given its OS name.
>
> /sbin/biosdevname -I eth2 - (OS name)
> eth0 - (Name according to the BIOS)
>
> KERNEL!="eth*", GOTO="biosdevname_end"
> ACTION!="add", GOTO="biosdevname_end"
> NAME="?*", GOTO="biosdevname_end"
>
> PROGRAM="/sbin/biosdevname --policy=all_ethN -i %k",
> ENV{INTERFACE_NAME}="%c"
>
> LABEL="biosdevname_end"
>
> We observed that renames in the same namespace, which is ethN namespace,
> resulted in interface names like eth_rename_ren. The solution was
> susceptible to driver load order. Please refer to this bug report-
> https://bugzilla.novell.com/show_bug.cgi?idD1079.
>
> This solution was not favored.
That's because for some reason you don't want to accept the fact that if
you want to rename things in a persistant manner, you have to do so in a
namespace that is outside of the kernel's normal one.
Now trying to change the kernel namespace itself seems like a bad hack
around this fact.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Narendra_K@Dell.com
Cc: netdev@vger.kernel.org, linux-hotplug@vger.kernel.org,
linux-pci@vger.kernel.org, Matt_Domsch@Dell.com,
Charles_Rose@Dell.com, Jordan_Hargrave@Dell.com,
Vijay_Nijhawan@Dell.com
Subject: Re: [PATCH] Use firmware provided index to register a network interface
Date: Thu, 23 Sep 2010 08:27:30 -0700 [thread overview]
Message-ID: <20100923152730.GA1261@kroah.com> (raw)
In-Reply-To: <EDA0A4495861324DA2618B4C45DCB3EE6A0AF8@blrx3m08.blr.amer.dell.com>
On Thu, Sep 23, 2010 at 08:40:44PM +0530, Narendra_K@Dell.com wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah.com]
> > Sent: Thursday, September 23, 2010 12:52 AM
> > To: K, Narendra
> > Cc: netdev@vger.kernel.org; linux-hotplug@vger.kernel.org; linux-
> > pci@vger.kernel.org; Domsch, Matt; Rose, Charles; Hargrave, Jordan;
> > Nijhawan, Vijay
> > Subject: Re: [PATCH] Use firmware provided index to register a network
> > interface
> >
> > On Wed, Sep 22, 2010 at 01:31:38PM -0500, Narendra K wrote:
> > > Hello,
> > >
> > > Here is another approach to address the issue of "eth0 does not
> > always
> > > map to the Integrated NIC Port 1 as denoted on server chassis
> label".
> > > For more details please refer to the thread -
> > > http://marc.info/?l=linux-netdev&m=128163454631618&w=3.
> > >
> > > Patch makes use of the firmware provided index to derive ethN names.
> > > That way the naming scheme adheres to the existing requirements of
> > > ethN namespace and with IFNAMSIZ length.
> >
> > Ick, again, what's wrong with using udev for this as it is designed
> to?
> > That way no kernel changes are needed, and no one has to rely on the
> > BIOS getting the firmware number right (meaning it will work on all
> > types of systems.)
> >
>
> 1. We tried addressing this issue using udev only and without any kernel
> changes, during Nov-Dec 2008 timeframe using Biosdevname udev helper
> utility. Biosdevname utility has the ability to suggest BIOS intended
> name of an interface given its OS name.
>
> /sbin/biosdevname -I eth2 - (OS name)
> eth0 - (Name according to the BIOS)
>
> KERNEL!="eth*", GOTO="biosdevname_end"
> ACTION!="add", GOTO="biosdevname_end"
> NAME=="?*", GOTO="biosdevname_end"
>
> PROGRAM="/sbin/biosdevname --policy=all_ethN -i %k",
> ENV{INTERFACE_NAME}="%c"
>
> LABEL="biosdevname_end"
>
> We observed that renames in the same namespace, which is ethN namespace,
> resulted in interface names like eth_rename_ren. The solution was
> susceptible to driver load order. Please refer to this bug report-
> https://bugzilla.novell.com/show_bug.cgi?id=441079.
>
> This solution was not favored.
That's because for some reason you don't want to accept the fact that if
you want to rename things in a persistant manner, you have to do so in a
namespace that is outside of the kernel's normal one.
Now trying to change the kernel namespace itself seems like a bad hack
around this fact.
thanks,
greg k-h
next prev parent reply other threads:[~2010-09-23 15:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 18:31 [PATCH] Use firmware provided index to register a network interface Narendra K
2010-09-22 18:31 ` Narendra K
2010-09-22 19:22 ` [PATCH] Use firmware provided index to register a network Greg KH
2010-09-22 19:22 ` [PATCH] Use firmware provided index to register a network interface Greg KH
2010-09-23 15:10 ` Narendra_K
2010-09-23 15:22 ` Narendra_K
2010-09-23 15:27 ` Greg KH [this message]
2010-09-23 15:27 ` Greg KH
2010-09-23 15:50 ` Narendra_K
2010-09-23 15:51 ` Narendra_K
2010-09-23 16:33 ` [PATCH] Use firmware provided index to register a network Greg KH
2010-09-23 16:33 ` [PATCH] Use firmware provided index to register a network interface Greg KH
2010-10-07 14:14 ` Narendra_K
2010-10-07 14:26 ` [PATCH] Use firmware provided index to register a network Narendra_K
2010-10-07 14:27 ` [PATCH] Use firmware provided index to register a network interface Tim Small
2010-10-07 14:27 ` Tim Small
2010-10-07 14:31 ` [PATCH] Use firmware provided index to register a network Greg KH
2010-10-07 14:31 ` [PATCH] Use firmware provided index to register a network interface Greg KH
2010-09-22 22:07 ` Tim Small
2010-09-22 22:07 ` Tim Small
2010-09-22 22:16 ` [PATCH] Use firmware provided index to register a network Stephen Hemminger
2010-09-22 22:16 ` [PATCH] Use firmware provided index to register a network interface Stephen Hemminger
2010-09-23 6:34 ` Tim Small
2010-09-23 6:34 ` Tim Small
2010-09-23 15:13 ` Narendra_K
2010-09-23 15:25 ` Narendra_K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923152730.GA1261@kroah.com \
--to=greg@kroah.com \
--cc=Charles_Rose@Dell.com \
--cc=Jordan_Hargrave@Dell.com \
--cc=Matt_Domsch@Dell.com \
--cc=Narendra_K@Dell.com \
--cc=Vijay_Nijhawan@Dell.com \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.