From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
James Bottomley <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org
Subject: Re: scsi_dh_alua: add missing transitioning state support
Date: Thu, 23 Sep 2010 14:53:46 -0400 [thread overview]
Message-ID: <20100923185346.GA12218@redhat.com> (raw)
In-Reply-To: <20100923134438.GA17966@redhat.com>
On Thu, Sep 23 2010 at 9:44am -0400,
Mike Snitzer <snitzer@redhat.com> wrote:
> > From db02ba3c33a4a1dbfcdc4de1b73e378f7b3d8925 Mon Sep 17 00:00:00 2001
> > From: Hannes Reinecke <hare@suse.de>
> > Date: Wed, 22 Sep 2010 12:09:07 +0200
> > Subject: [PATCH] scsi_dh_alua: Handle all states correctly
> >
> > For ALUA we should be handling all states, independent of whether
> > is explicit or implicit. For 'Transitioning' we should be retry
> > for a certain amount of time; after that we're setting the port
> > to 'Standby' and return SCSI_DH_RETRY to signal upper layers
> > a retry is in order here.
> >
> > Signed-off-by: Hannes Reinecke <hare@suse.de>
>
> Acked-by: Mike Snitzer <snitzer@redhat.com>
BTW, we're missing the include for the msleep() introduced in this
patch:
#include <linux/delay.h>
James, any chance you'd add that?
Or should Hannes send a revised patch?
Mike
prev parent reply other threads:[~2010-09-23 18:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 19:05 [PATCH] scsi_dh_alua: add missing transitioning state support Mike Snitzer
2010-08-17 19:23 ` Nicholas A. Bellinger
2010-08-30 9:36 ` Hannes Reinecke
2010-08-31 15:11 ` Mike Snitzer
2010-09-20 15:35 ` Mike Snitzer
2010-09-21 2:27 ` Mike Christie
2010-09-21 2:28 ` Mike Christie
2010-09-21 19:33 ` Mike Snitzer
2010-09-21 21:14 ` Mike Christie
2010-09-22 10:13 ` Hannes Reinecke
2010-09-22 12:29 ` Mike Snitzer
2010-09-23 7:15 ` Hannes Reinecke
2010-09-23 13:44 ` Mike Snitzer
2010-09-23 18:53 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923185346.GA12218@redhat.com \
--to=snitzer@redhat.com \
--cc=James.Bottomley@suse.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.