* [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register
@ 2010-09-22 15:16 Dimitris Papastamos
2010-09-23 17:36 ` Liam Girdwood
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dimitris Papastamos @ 2010-09-22 15:16 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches
We need to pass the register index and not the register value.
This patch depends on my previous patch "ASoC: Delegate to hw
specific read for volatile registers".
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
sound/soc/soc-cache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
index 5d9d2f8..3e4680b 100644
--- a/sound/soc/soc-cache.c
+++ b/sound/soc/soc-cache.c
@@ -177,7 +177,7 @@ static int snd_soc_8_8_write(struct snd_soc_codec *codec, unsigned int reg,
data[0] = reg;
data[1] = value & 0xff;
- if (!snd_soc_codec_volatile_register(codec, value) &&
+ if (!snd_soc_codec_volatile_register(codec, reg) &&
reg < codec->driver->reg_cache_size)
cache[reg] = value;
--
1.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register
2010-09-22 15:16 [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register Dimitris Papastamos
@ 2010-09-23 17:36 ` Liam Girdwood
2010-09-23 19:05 ` Mark Brown
2010-09-23 19:06 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2010-09-23 17:36 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, Mark Brown, patches
On Wed, 2010-09-22 at 16:16 +0100, Dimitris Papastamos wrote:
> We need to pass the register index and not the register value.
> This patch depends on my previous patch "ASoC: Delegate to hw
> specific read for volatile registers".
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-cache.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-cache.c b/sound/soc/soc-cache.c
> index 5d9d2f8..3e4680b 100644
> --- a/sound/soc/soc-cache.c
> +++ b/sound/soc/soc-cache.c
> @@ -177,7 +177,7 @@ static int snd_soc_8_8_write(struct snd_soc_codec *codec, unsigned int reg,
> data[0] = reg;
> data[1] = value & 0xff;
>
> - if (!snd_soc_codec_volatile_register(codec, value) &&
> + if (!snd_soc_codec_volatile_register(codec, reg) &&
> reg < codec->driver->reg_cache_size)
> cache[reg] = value;
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register
2010-09-22 15:16 [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register Dimitris Papastamos
2010-09-23 17:36 ` Liam Girdwood
@ 2010-09-23 19:05 ` Mark Brown
2010-09-23 19:06 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2010-09-23 19:05 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood
On Wed, Sep 22, 2010 at 04:16:06PM +0100, Dimitris Papastamos wrote:
> We need to pass the register index and not the register value.
> This patch depends on my previous patch "ASoC: Delegate to hw
> specific read for volatile registers".
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register
2010-09-22 15:16 [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register Dimitris Papastamos
2010-09-23 17:36 ` Liam Girdwood
2010-09-23 19:05 ` Mark Brown
@ 2010-09-23 19:06 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2010-09-23 19:06 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood
On Wed, Sep 22, 2010 at 04:16:06PM +0100, Dimitris Papastamos wrote:
> We need to pass the register index and not the register value.
> This patch depends on my previous patch "ASoC: Delegate to hw
> specific read for volatile registers".
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Meh, wrong finger macro - applied thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-23 19:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-22 15:16 [PATCH] ASoC: Fix incorrect parameter to snd_soc_codec_volatile_register Dimitris Papastamos
2010-09-23 17:36 ` Liam Girdwood
2010-09-23 19:05 ` Mark Brown
2010-09-23 19:06 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.