From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: matt mooney <mfm@muteddisk.com>
Cc: kernel-janitors@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
usb-storage@lists.one-eyed-alien.net,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Felipe Balbi <felipe.balbi@nokia.com>,
David Vrabel <david.vrabel@csr.com>
Subject: Re: [usb-storage] [PATCH 23/24] usb: change to new flag variable
Date: Fri, 24 Sep 2010 20:02:18 +0000 [thread overview]
Message-ID: <20100924200218.GC25677@one-eyed-alien.net> (raw)
In-Reply-To: <1dd0f4a1709a9b139fe87f2b311cc0d129900b3f.1285355033.git.mfm@muteddisk.com>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Fri, Sep 24, 2010 at 12:17:33PM -0700, matt mooney wrote:
> Replace EXTRA_CFLAGS with ccflags-y.
> diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile
> index ef7e5a8..786f086 100644
> --- a/drivers/usb/storage/Makefile
> +++ b/drivers/usb/storage/Makefile
> @@ -5,7 +5,7 @@
> # Rewritten to use lists instead of if-statements.
> #
>
> -EXTRA_CFLAGS := -Idrivers/scsi
> +ccflags-y := -Idrivers/scsi
>
> obj-$(CONFIG_USB_STORAGE) += usb-storage.o
I don't really know anything about the new 'ccflags' stuff.. but my
instincts tell me that perhaps that should be
'ccflags-$(CONFIG_USB_STORAGE)' rather than 'ccflags-y'?
Does it make a difference that usb-storage can be built-in or a loadable
module?
Matt
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
I could always suspend a few hundred accounts and watch what happens.
-- Tanya
User Friendly, 7/31/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
To: matt mooney <mfm@muteddisk.com>
Cc: kernel-janitors@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
usb-storage@lists.one-eyed-alien.net,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Felipe Balbi <felipe.balbi@nokia.com>,
David Vrabel <david.vrabel@csr.com>
Subject: Re: [usb-storage] [PATCH 23/24] usb: change to new flag variable
Date: Fri, 24 Sep 2010 13:02:18 -0700 [thread overview]
Message-ID: <20100924200218.GC25677@one-eyed-alien.net> (raw)
In-Reply-To: <1dd0f4a1709a9b139fe87f2b311cc0d129900b3f.1285355033.git.mfm@muteddisk.com>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Fri, Sep 24, 2010 at 12:17:33PM -0700, matt mooney wrote:
> Replace EXTRA_CFLAGS with ccflags-y.
> diff --git a/drivers/usb/storage/Makefile b/drivers/usb/storage/Makefile
> index ef7e5a8..786f086 100644
> --- a/drivers/usb/storage/Makefile
> +++ b/drivers/usb/storage/Makefile
> @@ -5,7 +5,7 @@
> # Rewritten to use lists instead of if-statements.
> #
>
> -EXTRA_CFLAGS := -Idrivers/scsi
> +ccflags-y := -Idrivers/scsi
>
> obj-$(CONFIG_USB_STORAGE) += usb-storage.o
I don't really know anything about the new 'ccflags' stuff.. but my
instincts tell me that perhaps that should be
'ccflags-$(CONFIG_USB_STORAGE)' rather than 'ccflags-y'?
Does it make a difference that usb-storage can be built-in or a loadable
module?
Matt
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
I could always suspend a few hundred accounts and watch what happens.
-- Tanya
User Friendly, 7/31/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-09-24 20:02 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 19:17 [PATCH 01/24] base: change to new flag variable matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 02/24] char: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 03/24] dma: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 04/24] hwmon: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [lm-sensors] " matt mooney
2010-09-24 19:17 ` [PATCH 05/24] i2c: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 06/24] ide: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 07/24] ieee802154: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 08/24] infiniband: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 09/24] input: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 10/24] isdn: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 11/24] memstick: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 12/24] message: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 13/24] misc: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 14/24] mmc: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 15/24] net: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 16/24] pci: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 17/24] power: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 18/24] pps: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 19/24] rapidio: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 20/24] rtc: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 21/24] scsi: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 22/24] spi: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 23/24] usb: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 19:17 ` [PATCH 24/24] video: " matt mooney
2010-09-24 19:17 ` matt mooney
2010-09-24 20:02 ` Matthew Dharm [this message]
2010-09-24 20:02 ` [usb-storage] [PATCH 23/24] usb: " Matthew Dharm
2010-09-24 20:28 ` matt mooney
2010-09-24 20:28 ` matt mooney
2010-09-24 23:21 ` matt mooney
2010-09-24 23:21 ` matt mooney
2010-10-08 18:33 ` [PATCH 22/24] spi: " Grant Likely
2010-10-08 18:33 ` Grant Likely
2010-09-25 1:37 ` [rtc-linux] [PATCH 20/24] rtc: " Wan ZongShun
2010-09-25 1:37 ` Wan ZongShun
2010-10-15 19:54 ` [PATCH 16/24] pci: " Jesse Barnes
2010-10-15 19:54 ` Jesse Barnes
2010-09-24 19:25 ` [PATCH 15/24] net: " John W. Linville
2010-09-24 19:25 ` John W. Linville
2010-09-24 20:01 ` David Miller
2010-09-24 20:01 ` David Miller
2010-09-28 13:02 ` [PATCH 13/24] misc: " Michał Mirosław
2010-09-28 13:02 ` Michał Mirosław
2010-09-29 22:55 ` matt mooney
2010-09-29 22:55 ` matt mooney
2010-09-24 20:01 ` [PATCH 10/24] isdn: " David Miller
2010-09-24 20:01 ` David Miller
2010-09-26 10:31 ` [PATCH 07/24] ieee802154: " Dmitry Eremin-Solenikov
2010-09-26 10:31 ` Dmitry Eremin-Solenikov
2010-09-24 20:01 ` [PATCH 06/24] ide: " David Miller
2010-09-24 20:01 ` David Miller
[not found] ` <b3e2061e1e6703f7b84c0484030e07de6000546a.1285355033.git.mfm-Oo0r1OC9pj9iLUuM0BA3LQ@public.gmane.org>
2010-09-25 11:26 ` [PATCH 05/24] i2c: " Jean Delvare
2010-09-25 11:26 ` Jean Delvare
2010-09-25 11:26 ` Jean Delvare
[not found] ` <20100925132611.03ef0882-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-09-26 2:12 ` matt mooney
2010-09-26 2:12 ` matt mooney
2010-09-26 2:12 ` matt mooney
[not found] ` <20100926021217.GC8191-HC+Z4NTRIlA6jSvU4L2mP2ItS4zQEDct@public.gmane.org>
2010-09-26 7:29 ` Jean Delvare
2010-09-26 7:29 ` Jean Delvare
2010-09-26 7:29 ` Jean Delvare
[not found] ` <20100926092931.68980448-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-09-26 18:07 ` matt mooney
2010-09-26 18:07 ` matt mooney
2010-09-26 18:07 ` matt mooney
2010-09-29 13:56 ` Jean Delvare
2010-09-29 13:56 ` Jean Delvare
2010-09-24 23:54 ` [lm-sensors] [PATCH 04/24] hwmon: " Guenter Roeck
2010-09-24 23:54 ` Guenter Roeck
2010-09-24 23:54 ` Guenter Roeck
2010-09-27 15:04 ` Valdis.Kletnieks
2010-09-27 15:04 ` Valdis.Kletnieks
2010-09-27 15:04 ` [lm-sensors] " Valdis.Kletnieks
2010-09-27 17:23 ` matt mooney
2010-09-27 17:23 ` matt mooney
2010-09-27 17:23 ` [lm-sensors] " matt mooney
2010-09-25 2:52 ` [PATCH 01/24] base: " Américo Wang
2010-09-25 2:52 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100924200218.GC25677@one-eyed-alien.net \
--to=mdharm-kernel@one-eyed-alien.net \
--cc=david.vrabel@csr.com \
--cc=dbrownell@users.sourceforge.net \
--cc=felipe.balbi@nokia.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mfm@muteddisk.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.