* [PATCH 00/21] Staging: cleaned up makefiles cflag lines @ 2010-09-24 18:25 ` T Dent 0 siblings, 0 replies; 10+ messages in thread From: T Dent @ 2010-09-24 18:25 UTC (permalink / raw) To: greg; +Cc: linux-kernel, kernel-janitors I changed every makefile in the staging directory to use the proper ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . Thanks, Tracey Dent ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 00/21] Staging: cleaned up makefiles cflag lines @ 2010-09-24 18:25 ` T Dent 0 siblings, 0 replies; 10+ messages in thread From: T Dent @ 2010-09-24 18:25 UTC (permalink / raw) To: greg; +Cc: linux-kernel, kernel-janitors I changed every makefile in the staging directory to use the proper ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . Thanks, Tracey Dent ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines 2010-09-24 18:25 ` T Dent @ 2010-09-24 19:31 ` matt mooney -1 siblings, 0 replies; 10+ messages in thread From: matt mooney @ 2010-09-24 19:31 UTC (permalink / raw) To: T Dent; +Cc: greg, linux-kernel, kernel-janitors On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: > I changed every makefile in the staging directory to use the proper > ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . Um, you didn't do a lot of these right. Maybe you should look into why the change was made in the first place. For semantic reasons, I was also changing the first assignment to ":=" from "+=". Thanks, mfm -- GPG-Key: 9AFE00EA ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines @ 2010-09-24 19:31 ` matt mooney 0 siblings, 0 replies; 10+ messages in thread From: matt mooney @ 2010-09-24 19:31 UTC (permalink / raw) To: T Dent; +Cc: greg, linux-kernel, kernel-janitors On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: > I changed every makefile in the staging directory to use the proper > ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . Um, you didn't do a lot of these right. Maybe you should look into why the change was made in the first place. For semantic reasons, I was also changing the first assignment to ":=" from "+=". Thanks, mfm -- GPG-Key: 9AFE00EA ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines 2010-09-24 19:31 ` matt mooney @ 2010-09-24 20:39 ` T Dent -1 siblings, 0 replies; 10+ messages in thread From: T Dent @ 2010-09-24 20:39 UTC (permalink / raw) To: matt mooney; +Cc: greg, linux-kernel, kernel-janitors On 9/24/10, matt mooney <mfmooney@gmail.com> wrote: > On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: >> I changed every makefile in the staging directory to use the proper >> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . > > Um, you didn't do a lot of these right. Maybe you should look into why > the change was made in the first place. For semantic reasons, I was > also changing the first assignment to ":=" from "+=". I can resend them with the a small modification to the patch files if you want. > > Thanks, > mfm > > -- > GPG-Key: 9AFE00EA > Thanks, Tracey Dent ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines @ 2010-09-24 20:39 ` T Dent 0 siblings, 0 replies; 10+ messages in thread From: T Dent @ 2010-09-24 20:39 UTC (permalink / raw) To: matt mooney; +Cc: greg, linux-kernel, kernel-janitors On 9/24/10, matt mooney <mfmooney@gmail.com> wrote: > On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: >> I changed every makefile in the staging directory to use the proper >> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . > > Um, you didn't do a lot of these right. Maybe you should look into why > the change was made in the first place. For semantic reasons, I was > also changing the first assignment to ":=" from "+=". I can resend them with the a small modification to the patch files if you want. > > Thanks, > mfm > > -- > GPG-Key: 9AFE00EA > Thanks, Tracey Dent ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines 2010-09-24 20:39 ` T Dent @ 2010-09-24 20:51 ` matt mooney -1 siblings, 0 replies; 10+ messages in thread From: matt mooney @ 2010-09-24 20:51 UTC (permalink / raw) To: T Dent; +Cc: matt mooney, greg, linux-kernel, kernel-janitors On 16:39 Fri 24 Sep , T Dent wrote: > On 9/24/10, matt mooney <mfmooney@gmail.com> wrote: > > On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: > >> I changed every makefile in the staging directory to use the proper > >> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . > > > > Um, you didn't do a lot of these right. Maybe you should look into why > > the change was made in the first place. For semantic reasons, I was > > also changing the first assignment to ":=" from "+=". > > I can resend them with the a small modification to the patch files if you want. After looking at more of them, my "a lot" was a little bit of an overstatement. The first few I randomly looked at happen to use the incorrect pattern, but most are simple without relying on a variable. Yeah, I think you should resubmit with a "[PATCH v2]." The pattern is: ifeq ($(FOO),y) EXTRA_CFLAGS := <flags> endif changes to: ccflags-$(FOO) := <flags> Also, the rest of the kernel tree has been done except drivers/media; however, I am going to email them in a little bit asking if some consolidation is possible due to every driver there relying on a few flags. So thanks for the help (though is was a good thing I was saving staging for last)! -mfm ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines @ 2010-09-24 20:51 ` matt mooney 0 siblings, 0 replies; 10+ messages in thread From: matt mooney @ 2010-09-24 20:51 UTC (permalink / raw) To: T Dent; +Cc: matt mooney, greg, linux-kernel, kernel-janitors On 16:39 Fri 24 Sep , T Dent wrote: > On 9/24/10, matt mooney <mfmooney@gmail.com> wrote: > > On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: > >> I changed every makefile in the staging directory to use the proper > >> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . > > > > Um, you didn't do a lot of these right. Maybe you should look into why > > the change was made in the first place. For semantic reasons, I was > > also changing the first assignment to ":=" from "+=". > > I can resend them with the a small modification to the patch files if you want. After looking at more of them, my "a lot" was a little bit of an overstatement. The first few I randomly looked at happen to use the incorrect pattern, but most are simple without relying on a variable. Yeah, I think you should resubmit with a "[PATCH v2]." The pattern is: ifeq ($(FOO),y) EXTRA_CFLAGS := <flags> endif changes to: ccflags-$(FOO) := <flags> Also, the rest of the kernel tree has been done except drivers/media; however, I am going to email them in a little bit asking if some consolidation is possible due to every driver there relying on a few flags. So thanks for the help (though is was a good thing I was saving staging for last)! -mfm ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines 2010-09-24 20:51 ` matt mooney @ 2010-09-24 21:12 ` T Dent -1 siblings, 0 replies; 10+ messages in thread From: T Dent @ 2010-09-24 21:12 UTC (permalink / raw) To: T Dent, matt mooney, greg, linux-kernel, kernel-janitors On 9/24/10, matt mooney <mfm@muteddisk.com> wrote: > On 16:39 Fri 24 Sep , T Dent wrote: >> On 9/24/10, matt mooney <mfmooney@gmail.com> wrote: >> > On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: >> >> I changed every makefile in the staging directory to use the proper >> >> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . >> > >> > Um, you didn't do a lot of these right. Maybe you should look into why >> > the change was made in the first place. For semantic reasons, I was >> > also changing the first assignment to ":=" from "+=". >> >> I can resend them with the a small modification to the patch files if you >> want. > > After looking at more of them, my "a lot" was a little bit of an > overstatement. The first few I randomly looked at happen to use the > incorrect > pattern, but most are simple without relying on a variable. Yeah, I think > you > should resubmit with a "[PATCH v2]." The pattern is: > > ifeq ($(FOO),y) > EXTRA_CFLAGS := <flags> > endif > > changes to: > > ccflags-$(FOO) := <flags> > > Also, the rest of the kernel tree has been done except drivers/media; > however, I > am going to email them in a little bit asking if some consolidation is > possible > due to every driver there relying on a few flags. So thanks for the help > (though > is was a good thing I was saving staging for last)! > > -mfm > > Okay i'll resubmit the patches when I edit it how you said. Thanks, Tracey ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/21] Staging: cleaned up makefiles cflag lines @ 2010-09-24 21:12 ` T Dent 0 siblings, 0 replies; 10+ messages in thread From: T Dent @ 2010-09-24 21:12 UTC (permalink / raw) To: T Dent, matt mooney, greg, linux-kernel, kernel-janitors On 9/24/10, matt mooney <mfm@muteddisk.com> wrote: > On 16:39 Fri 24 Sep , T Dent wrote: >> On 9/24/10, matt mooney <mfmooney@gmail.com> wrote: >> > On Fri, Sep 24, 2010 at 11:25 AM, T Dent <tdent48227@gmail.com> wrote: >> >> I changed every makefile in the staging directory to use the proper >> >> ccflags-y option instead of EXTRA_CFLAGS. It builds also :) . >> > >> > Um, you didn't do a lot of these right. Maybe you should look into why >> > the change was made in the first place. For semantic reasons, I was >> > also changing the first assignment to ":=" from "+=". >> >> I can resend them with the a small modification to the patch files if you >> want. > > After looking at more of them, my "a lot" was a little bit of an > overstatement. The first few I randomly looked at happen to use the > incorrect > pattern, but most are simple without relying on a variable. Yeah, I think > you > should resubmit with a "[PATCH v2]." The pattern is: > > ifeq ($(FOO),y) > EXTRA_CFLAGS := <flags> > endif > > changes to: > > ccflags-$(FOO) := <flags> > > Also, the rest of the kernel tree has been done except drivers/media; > however, I > am going to email them in a little bit asking if some consolidation is > possible > due to every driver there relying on a few flags. So thanks for the help > (though > is was a good thing I was saving staging for last)! > > -mfm > > Okay i'll resubmit the patches when I edit it how you said. Thanks, Tracey ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-09-24 21:12 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-09-24 18:25 [PATCH 00/21] Staging: cleaned up makefiles cflag lines T Dent 2010-09-24 18:25 ` T Dent 2010-09-24 19:31 ` matt mooney 2010-09-24 19:31 ` matt mooney 2010-09-24 20:39 ` T Dent 2010-09-24 20:39 ` T Dent 2010-09-24 20:51 ` matt mooney 2010-09-24 20:51 ` matt mooney 2010-09-24 21:12 ` T Dent 2010-09-24 21:12 ` T Dent
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.