[PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Mark Brown]

Since Jassi is doing so much good work and can offer such good review
for the Samsung CPU support add an entry for the Samsung ASoC drivers
to MAINTAINERS listing him.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
---
 MAINTAINERS |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index b5b8baa..f51409b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4965,6 +4965,12 @@ F:	drivers/media/common/saa7146*
 F:	drivers/media/video/*7146*
 F:	include/media/*7146*
 
+SAMSUNG AUDIO (ASoC) DRIVERS
+M:	Jassi Brar <jassi.brar@samsung.com>
+L:	alsa-devel@alsa-project.org (moderated for non-subscribers)
+S:	Supported
+F:	sound/soc/s3c24xx
+
 TLG2300 VIDEO4LINUX-2 DRIVER
 M:	Huang Shijie <shijie8@gmail.com>
 M:	Kang Yong <kangyong@telegent.com>
-- 
1.7.1

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Jassi Brar]

On Sat, Sep 25, 2010 at 5:16 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Since Jassi is doing so much good work and can offer such good review
> for the Samsung CPU support add an entry for the Samsung ASoC drivers
> to MAINTAINERS listing him.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
>  MAINTAINERS |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b5b8baa..f51409b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4965,6 +4965,12 @@ F:       drivers/media/common/saa7146*
>  F:     drivers/media/video/*7146*
>  F:     include/media/*7146*
>
> +SAMSUNG AUDIO (ASoC) DRIVERS
> +M:     Jassi Brar <jassi.brar@samsung.com>
> +L:     alsa-devel@alsa-project.org (moderated for non-subscribers)
> +S:     Supported
> +F:     sound/soc/s3c24xx
> +
>  TLG2300 VIDEO4LINUX-2 DRIVER
>  M:     Huang Shijie <shijie8@gmail.com>
>  M:     Kang Yong <kangyong@telegent.com>

Acked-by: Jassi Brar <jassi.brar@samsung.com>

Thanks.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Kyungmin Park]

Good news,

At the first work, can you proceed the directory name change from
s3c24xx to samsung?

it's really misleading and confusing to others.

Thank you,
Kyungmin Park

On Sat, Sep 25, 2010 at 9:15 PM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Sat, Sep 25, 2010 at 5:16 PM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
>> Since Jassi is doing so much good work and can offer such good review
>> for the Samsung CPU support add an entry for the Samsung ASoC drivers
>> to MAINTAINERS listing him.
>>
>> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
>> ---
>>  MAINTAINERS |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b5b8baa..f51409b 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4965,6 +4965,12 @@ F:       drivers/media/common/saa7146*
>>  F:     drivers/media/video/*7146*
>>  F:     include/media/*7146*
>>
>> +SAMSUNG AUDIO (ASoC) DRIVERS
>> +M:     Jassi Brar <jassi.brar@samsung.com>
>> +L:     alsa-devel@alsa-project.org (moderated for non-subscribers)
>> +S:     Supported
>> +F:     sound/soc/s3c24xx
>> +
>>  TLG2300 VIDEO4LINUX-2 DRIVER
>>  M:     Huang Shijie <shijie8@gmail.com>
>>  M:     Kang Yong <kangyong@telegent.com>
>
> Acked-by: Jassi Brar <jassi.brar@samsung.com>
>
> Thanks.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Jassi Brar]

On Sun, Sep 26, 2010 at 7:38 PM, Kyungmin Park <kmpark@infradead.org> wrote:
> Good news,
>
> At the first work, can you proceed the directory name change from
> s3c24xx to samsung?
>
> it's really misleading and confusing to others.
I am currently working on overhauling the Samsung ASoC support (AC97,
PCM, DMA rename and I2S redesign).
Hopefully patches will be ready within few days.

Regards.

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Kyungmin Park]

On Sun, Sep 26, 2010 at 7:41 PM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Sun, Sep 26, 2010 at 7:38 PM, Kyungmin Park <kmpark@infradead.org> wrote:
>> Good news,
>>
>> At the first work, can you proceed the directory name change from
>> s3c24xx to samsung?
>>
>> it's really misleading and confusing to others.
> I am currently working on overhauling the Samsung ASoC support (AC97,
> PCM, DMA rename and I2S redesign).
> Hopefully patches will be ready within few days.

Also please consider the power consumption issues. Lower Power (LP)
and runtime PM.
In the previous time it's handled by multimedia team (user level) but
they can't control it well.
In rough idea, it creates the some interface and just toggle it either
LP and normal.
As you know Lower Power Audio is one of big issues at power consumption.

I'm not sure runtime PM is required for audio since ALSA control the
codec well. but try to reduce the power as we can.

Thank you,
Kyungmin Park

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Mark Brown]

On Sun, Sep 26, 2010 at 07:49:42PM +0900, Kyungmin Park wrote:

> I'm not sure runtime PM is required for audio since ALSA control the
> codec well. but try to reduce the power as we can.

About all you can do with most CPUs is turn off the clocks within the
block when they're not needed, the runtime PM subsystem itself is
usually only useful if you've got support for power gating within the
CPU (which tends to be done over multiple blocks so they all need to go
idle before you can power them off).

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Kyungmin Park]

On Mon, Sep 27, 2010 at 9:20 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Sun, Sep 26, 2010 at 07:49:42PM +0900, Kyungmin Park wrote:
>
>> I'm not sure runtime PM is required for audio since ALSA control the
>> codec well. but try to reduce the power as we can.
>
> About all you can do with most CPUs is turn off the clocks within the
> block when they're not needed, the runtime PM subsystem itself is
> usually only useful if you've got support for power gating within the
> CPU (which tends to be done over multiple blocks so they all need to go
> idle before you can power them off).
Yes, recent Samsung SoC supports the clock & block gating. As the
word, clock gating means enable/disable the clock and block gating
means turn on/off some peripherals blocks to reduce the power. e..g,
In case of audio, AUDIO block including I2S, AC97 and so on.
However codec is different. even though it can turn on/off codec, I
think it have to re-initialize to use it and it takes some times.

To Jassi,
You can talk with Mr. Choi. he will explain our requirement.

Thank you,
Kyungmin Park
>

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Mark Brown]

On Mon, Sep 27, 2010 at 11:01:54AM +0900, Kyungmin Park wrote:

> Yes, recent Samsung SoC supports the clock & block gating. As the
> word, clock gating means enable/disable the clock and block gating
> means turn on/off some peripherals blocks to reduce the power. e..g,
> In case of audio, AUDIO block including I2S, AC97 and so on.

It's very straightforward, yes (though in the case of AC'97 the split
between CODEC and CPU is more tricky than you might at first think since
by default the CPU is clock master for everything).

> However codec is different. even though it can turn on/off codec, I
> think it have to re-initialize to use it and it takes some times.

The same is true for CPU IPs, of course.  With modern CODECs this is
becoming less and less of an issue - with VMID referenced CODECs there
was always a lengthy delay to bring up VMID but with ground referenced,
PDM and class D outputs it's becoming less and less of an issue to just
power things down.

Re: [PATCH] ASoC: Add Jassi Brar as Samsung maintainer

[Jassi Brar]

On Sun, Sep 26, 2010 at 7:49 PM, Kyungmin Park <kmpark@infradead.org> wrote:
>>> Good news,
>>>
>>> At the first work, can you proceed the directory name change from
>>> s3c24xx to samsung?
>>>
>>> it's really misleading and confusing to others.
>> I am currently working on overhauling the Samsung ASoC support (AC97,
>> PCM, DMA rename and I2S redesign).
>> Hopefully patches will be ready within few days.
>
> Also please consider the power consumption issues. Lower Power (LP)
> and runtime PM.
> In the previous time it's handled by multimedia team (user level) but
> they can't control it well.
> In rough idea, it creates the some interface and just toggle it either
> LP and normal.
> As you know Lower Power Audio is one of big issues at power consumption.

The Secondary fifo(overlay stereo channel) of I2Sv5 can receive data from a
dedicated h/w buffer via dedicated audio-internal DMA as well as from
system memory via system DMA(ex PL330).

LPAM(power saving by using iDMA and iBuff while system is in deep-idle mode)
is just one use of the overlay channel.
Please remember that some other user might use it purely for h/w mixing
in normal-power mode while using system RAM and DMA.
So, ATM, I am against putting any power-mode detection mechanism into
audio drivers.
IMO, it's the responsibility of user-space to setup routes/modes to
serve it's purpose.

Anyways, I am open to suggestions. Mr Choi may ping me anytime.

Thanks.