All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Jean Delvare <khali@linux-fr.org>
Subject: Re: [lm-sensors] [PATCH] hwmon (coretemp): Fix build breakage if
Date: Mon, 27 Sep 2010 11:48:01 +0000	[thread overview]
Message-ID: <20100927114801.GA31757@ericsson.com> (raw)
In-Reply-To: <20100927062510.GA17825@elte.hu>

On Mon, Sep 27, 2010 at 02:25:10AM -0400, Ingo Molnar wrote:
> 
> * Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> 
> > Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> > a build breakage if CONFIG_SMP is undefined. This patch
> > fixes the problem.
> > 
> > Reported-by: Ingo Molnar <mingo@elte.hu>
> > Cc: Fenghua Yu <fenghua.yu@intel.com>
> > Cc: Jean Delvare <khali@linux-fr.org>
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > 
> > ---
> >  drivers/hwmon/coretemp.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index baa842a..58a3c2d 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu)
> >  		list_del(&p->list);
> >  		mutex_unlock(&pdev_list_mutex);
> >  		kfree(p);
> > +#ifdef CONFIG_SMP
> >  		for_each_cpu(i, cpu_sibling_mask(cpu))
> >  			if (i != cpu && !coretemp_device_add(i))
> >  				break;
> > +#endif
> 
> Wont this result in an 'unused variable i' compiler warning?
> 
Sigh. Yes, of course. Must have been blind when I compiled it. Serves me right, 
for pushing this out in a hurry. You'll see rev2 of the patch in a minute.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined
Date: Mon, 27 Sep 2010 04:48:01 -0700	[thread overview]
Message-ID: <20100927114801.GA31757@ericsson.com> (raw)
In-Reply-To: <20100927062510.GA17825@elte.hu>

On Mon, Sep 27, 2010 at 02:25:10AM -0400, Ingo Molnar wrote:
> 
> * Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> 
> > Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced
> > a build breakage if CONFIG_SMP is undefined. This patch
> > fixes the problem.
> > 
> > Reported-by: Ingo Molnar <mingo@elte.hu>
> > Cc: Fenghua Yu <fenghua.yu@intel.com>
> > Cc: Jean Delvare <khali@linux-fr.org>
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > 
> > ---
> >  drivers/hwmon/coretemp.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> > index baa842a..58a3c2d 100644
> > --- a/drivers/hwmon/coretemp.c
> > +++ b/drivers/hwmon/coretemp.c
> > @@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu)
> >  		list_del(&p->list);
> >  		mutex_unlock(&pdev_list_mutex);
> >  		kfree(p);
> > +#ifdef CONFIG_SMP
> >  		for_each_cpu(i, cpu_sibling_mask(cpu))
> >  			if (i != cpu && !coretemp_device_add(i))
> >  				break;
> > +#endif
> 
> Wont this result in an 'unused variable i' compiler warning?
> 
Sigh. Yes, of course. Must have been blind when I compiled it. Serves me right, 
for pushing this out in a hurry. You'll see rev2 of the patch in a minute.

Guenter

  reply	other threads:[~2010-09-27 11:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-26 19:50 [lm-sensors] [PATCH] hwmon (coretemp): Fix build breakage if SMP is Guenter Roeck
2010-09-26 19:50 ` [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-27  6:25 ` [lm-sensors] [PATCH] hwmon (coretemp): Fix build breakage if Ingo Molnar
2010-09-27  6:25   ` [PATCH] hwmon (coretemp): Fix build breakage if SMP is undefined Ingo Molnar
2010-09-27 11:48   ` Guenter Roeck [this message]
2010-09-27 11:48     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100927114801.GA31757@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=fenghua.yu@intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.