All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Jean Delvare <khali@linux-fr.org>
Subject: Re: [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if
Date: Mon, 27 Sep 2010 14:40:08 +0000	[thread overview]
Message-ID: <20100927144008.GA2577@ericsson.com> (raw)
In-Reply-To: <20100927125946.GB2862@elte.hu>

On Mon, Sep 27, 2010 at 08:59:46AM -0400, Ingo Molnar wrote:
> 
> * Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> 
> > +#ifdef CONFIG_SMP
> > +#endif
> > +#ifdef CONFIG_SMP
> > +#endif
> 
> Hm, this tickles my uglo-meter. Is there no cleaner way, preferably one 
> that doesnt involve preprocessor directives?
> 
After looking through the code I thought about a much cleaner fix for
handling the SMP defines in coretemp.c and pkgtemp.c. Essentially
it will move all SMP dependencies into a single #ifdef, and also
optimize the loop in question with cpumask_first() / cpumask_next().
Maybe I can get rid of some of the SMP dependencies entirely. However,
the driver also uses phys_proc_id and cpu_core_id from cpuinfo_x86,
and those are only available if SMP is defined.

That would be way too invasive for .36, though. I'll stick with the
current patch and submit a cleanup for .37. That also fits well with
the other pending cleanups for the two drivers.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined
Date: Mon, 27 Sep 2010 07:40:08 -0700	[thread overview]
Message-ID: <20100927144008.GA2577@ericsson.com> (raw)
In-Reply-To: <20100927125946.GB2862@elte.hu>

On Mon, Sep 27, 2010 at 08:59:46AM -0400, Ingo Molnar wrote:
> 
> * Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> 
> > +#ifdef CONFIG_SMP
> > +#endif
> > +#ifdef CONFIG_SMP
> > +#endif
> 
> Hm, this tickles my uglo-meter. Is there no cleaner way, preferably one 
> that doesnt involve preprocessor directives?
> 
After looking through the code I thought about a much cleaner fix for
handling the SMP defines in coretemp.c and pkgtemp.c. Essentially
it will move all SMP dependencies into a single #ifdef, and also
optimize the loop in question with cpumask_first() / cpumask_next().
Maybe I can get rid of some of the SMP dependencies entirely. However,
the driver also uses phys_proc_id and cpu_core_id from cpuinfo_x86,
and those are only available if SMP is defined.

That would be way too invasive for .36, though. I'll stick with the
current patch and submit a cleanup for .37. That also fits well with
the other pending cleanups for the two drivers.

Thanks,
Guenter


  parent reply	other threads:[~2010-09-27 14:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 11:59 [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if SMP Guenter Roeck
2010-09-27 11:59 ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-27 12:59 ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Ingo Molnar
2010-09-27 12:59   ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Ingo Molnar
2010-09-27 13:02   ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Pekka Enberg
2010-09-27 13:02     ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Pekka Enberg
2010-09-27 23:27     ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Guenter Roeck
2010-09-27 23:27       ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-27 23:44       ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Linus Torvalds
2010-09-27 23:44         ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Linus Torvalds
2010-09-28  0:07         ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Guenter Roeck
2010-09-28  0:07           ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-28  0:26         ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Guenter Roeck
2010-09-28  0:26           ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-28  1:00           ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Linus Torvalds
2010-09-28  1:00             ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Linus Torvalds
2010-09-28  1:12             ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Guenter Roeck
2010-09-28  1:12               ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-27 13:15   ` [lm-sensors] [PATCH v2] hwmon (coretemp): Fix build breakage if Guenter Roeck
2010-09-27 13:15     ` [PATCH v2] hwmon (coretemp): Fix build breakage if SMP is undefined Guenter Roeck
2010-09-27 14:40   ` Guenter Roeck [this message]
2010-09-27 14:40     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100927144008.GA2577@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=fenghua.yu@intel.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.