Re: [PATCH] UAS driver

[Matthew Wilcox <willy@linux.intel.com>]

On Mon, Sep 27, 2010 at 10:56:49PM -0700, Greg KH wrote:
> On Tue, Sep 28, 2010 at 01:07:34AM -0400, Matthew Wilcox wrote:
> > +static struct usb_device_id uas_usb_ids[] = {
> > +	{ USB_INTERFACE_INFO(8, 6, 0x50) },
> > +	{ USB_INTERFACE_INFO(8, 6, 0x62) },
> > +	{ USB_INTERFACE_INFO(8, 6, 0xaa) }, /* A prototype */
> > +	{ }
> 
> Don't we have the proper #defines in the usb/ch9.h file that you can use
> here?  If not, please add them so that we don't have "magic" numbers.

We've got
#define USB_CLASS_MASS_STORAGE          8
in usb/ch9.h, which I can use.

The other numbers are in include/linux/usb_usual.h, which is actually a pain
to include (I haven't figured out everything I need to do to include it).

What I'd like to do is pull the subclasses and protocols out into a new
include file, include/linux/usb/storage.h to match audio.h.  Would you be
likely to accept such a patch?


I don't intend to add 0xaa to a header file ... I see its inclusion in
this driver as a temporary thing, and I'd rather remove support for it
than add it to a header.