From: Matthew Wilcox <willy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sarah Sharp
<sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH] UAS driver
Date: Tue, 28 Sep 2010 03:17:11 -0400 [thread overview]
Message-ID: <20100928071711.GE3799@linux.intel.com> (raw)
In-Reply-To: <20100928070613.GA11056-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
On Tue, Sep 28, 2010 at 12:06:13AM -0700, Greg KH wrote:
> > I don't intend to add 0xaa to a header file ... I see its inclusion in
> > this driver as a temporary thing, and I'd rather remove support for it
> > than add it to a header.
>
> I'm afraid to ask what the 0xaa is, but here goes, what is it?
It's a prototype device that has the wrong protocol ID. Eventually I'll
just drop support for it from the driver, but it's a useful device
to keep testing with for the moment (it supports some aspects of the
protocol that other devices I have access to don't).
Since nobody else is likely to have one, I'd rather take the line out
of the in-tree driver and patch it back in locally, than I would add it
to the header file.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-09-28 7:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 5:07 [PATCH] UAS driver Matthew Wilcox
2010-09-28 5:55 ` Greg KH
[not found] ` <20100928050733.GB3799-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-28 5:56 ` Greg KH
2010-09-28 6:45 ` Matthew Wilcox
[not found] ` <20100928064549.GD3799-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-28 7:06 ` Greg KH
[not found] ` <20100928070613.GA11056-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-09-28 7:17 ` Matthew Wilcox [this message]
2010-09-28 7:25 ` Greg KH
2010-09-28 7:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928071711.GE3799@linux.intel.com \
--to=willy-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.