Re: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

[Wolfram Sang <w.sang@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]

On Tue, Sep 28, 2010 at 06:54:47AM -0700, Philip Rakity wrote:

> taking this off line for a bit (if you don't mind)

Actually, I do. Going back to the list.

> I really like what you are doing but it does not go far enough.  The
> controller I work on is somewhat funny and broken.  It needs to do
> either pre or post processing for some of the calls.

I never claimed that my current patchset should solve all issues. It
deals with some issues I encountered (and then some more, because there
were similar issues on the list), and tries to push things in the right
direction. Most of us are just working on one specific driver, so we
have to live with a slow, step-by-step procedure. I tried to get some
funding for general, large scale cleanup work, but did not get any
response, so far.

> For reset for example --- I need to check if the reset is RESET_DAT
> and handle that differently then RESET_CMD.  If RESET_ALL I need to do
> post processing to restore the controller private registers.

I know the reset-routine probably needs another hook. I think it was
Alan who also mentioned some requirements for it. But besides this, I am
not going to dive deeply into that topic (at least for now). It is too
specific for me at the moment.

Quite frankly, I am a bit overwhelmed by the massive request of guidance
for pltfm-specific drivers and I cannot provide this anymore at this
level as long as I have other work to do (which allows me to buy the
bread). As a result, I will continue reviewing and such but it will take
longer.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]