From: Wolfram Sang <w.sang@pengutronix.de>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: linux-mmc@vger.kernel.org,
Anton Vorontsov <cbouatmailru@gmail.com>,
Zhu Richard-R65037 <r65037@freescale.com>,
Philip Rakity <prakity@marvell.com>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Saeed Bishara <saeed@marvell.com>
Subject: Re: [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51
Date: Tue, 28 Sep 2010 16:51:02 +0200 [thread overview]
Message-ID: <20100928145102.GJ4441@pengutronix.de> (raw)
In-Reply-To: <AANLkTikHMXV+Bkg=fQEhw-2WszT3PeKwWvswrE-7h1EM@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
> > +static int esdhc_pltfm_init(struct sdhci_host *host,
> > + struct sdhci_pltfm_data *pdata, void *priv_pdata)
> > +{
> > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> > + struct clk *clk;
> > +
> > + clk = clk_get(NULL, "sdhc");
>
> Here only could support one device, how about several device, for
> example sdhc.0, sdhc.1 sdhc.2, if using this method, they will get the
> first clock.
> Then sdhc.1 sdhc.2 can not work.
>
Ouch, totally overlooked this one. Thanks for spotting it!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-09-28 14:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 12:36 [PATCH 0/6] Add driver for mx35/51-esdhc-controller (and update sdhci for that) Wolfram Sang
2010-09-28 12:36 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-09-28 12:57 ` Anton Vorontsov
2010-09-28 13:54 ` zhangfei gao
[not found] ` <48641052-49AF-4A24-9C8C-42E59791D6A7@marvell.com>
2010-09-28 14:49 ` Wolfram Sang
2010-09-28 12:36 ` [PATCH 2/6] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-09-28 12:36 ` [PATCH 3/6] mmc: sdhci: introduce private get_ro Wolfram Sang
2010-09-28 12:36 ` [PATCH 4/6] mmc: sdhci_pltfm: pass platform_data on custom init-call Wolfram Sang
2010-09-28 12:58 ` Anton Vorontsov
2010-09-28 12:36 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-28 12:58 ` Anton Vorontsov
2010-09-28 12:36 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-09-28 12:58 ` Anton Vorontsov
2010-09-28 14:04 ` zhangfei gao
2010-09-28 14:51 ` Wolfram Sang [this message]
2010-09-28 20:57 ` Ben Dooks
2010-09-29 1:59 ` zhangfei gao
2010-09-29 2:27 ` Zhu Richard-R65037
2010-09-29 3:22 ` zhangfei gao
2010-09-29 3:41 ` Zhu Richard-R65037
2010-09-29 19:26 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2010-09-29 20:07 [PATCH V3 0/6] SD/MMC-driver for MX35/51 (and improvements to SDHCI) Wolfram Sang
2010-09-29 20:08 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-09-29 20:08 ` Wolfram Sang
2010-09-29 20:14 ` Chris Ball
2010-09-29 20:14 ` Chris Ball
2010-10-11 14:21 [PATCH 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-11 14:21 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-14 3:07 ` Chris Ball
2010-10-14 3:07 ` Chris Ball
2010-10-15 10:20 [PATCH V5 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-15 10:21 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-10-15 10:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928145102.GJ4441@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cbouatmailru@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
--cc=r65037@freescale.com \
--cc=saeed@marvell.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.