Re: [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51

[Chris Ball <cjb@laptop.org>]

Hi Wolfram,

On Mon, Oct 11, 2010 at 04:21:06PM +0200, Wolfram Sang wrote:
> This driver adds basic support for the esdhc-core found on e.g.
> imx35/51. It adds up to the pltfm-core.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
> Tested-by : Eric Bénard <eric@eukrea.com>
> ---
> 
> Changes since last version:
> 
> * use PTR_ERR if clk_get failed
> 
>  drivers/mmc/host/Kconfig           |   10 +++
>  drivers/mmc/host/Makefile          |    1 +
>  drivers/mmc/host/sdhci-esdhc-imx.c |  143 ++++++++++++++++++++++++++++++++++++
>  drivers/mmc/host/sdhci-pltfm.c     |    3 +
>  drivers/mmc/host/sdhci-pltfm.h     |    1 +
>  5 files changed, 158 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mmc/host/sdhci-esdhc-imx.c
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8de7b9e..7b07f10 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -130,6 +130,16 @@ config MMC_SDHCI_CNS3XXX
>  
>  	  If unsure, say N.
>  
> +config MMC_SDHCI_ESDHC_IMX
> +	bool "SDHCI platform support for the Freescale eSDHC i.MX controller"
> +	depends on MMC_SDHCI_PLTFM
> +	select MMC_SDHCI_IO_ACCESSORS
> +	help
> +	  This selects the Freescale eSDHC controller support on the platform
> +	  bus, found on platforms like mx35/51.
> +
> +	  If unsure, say N.
> +

Could you add a machine dependency here?  Otherwise this is going to
offer itself to x86 users, and then fail to compile due to lack of a
clk_* implementation.

Apart from that, looks ready for mmc-next -- the mdelay(100) fix can
come later, since that's orthogonal.

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child