From: Chris Ball <cjb@laptop.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Zhu Richard-R65037 <r65037@freescale.com>
Subject: Re: [PATCH 0/6] SD/MMC driver for MX25/35/51
Date: Mon, 11 Oct 2010 17:59:29 +0100 [thread overview]
Message-ID: <20101011165929.GB21335@void.printf.net> (raw)
In-Reply-To: <20101011164459.GB476@pengutronix.de>
Hi Wolfram,
On Mon, Oct 11, 2010 at 06:44:59PM +0200, Wolfram Sang wrote:
> > Mind fixing up the >80 char lines in the last two patches? It's just:
>
> Sigh, I don't think it will help the readability of the code, but if it can't
> be helped...
Okay. Perhaps as a compromise, just reflow the two lines in 5/6 and
leave the long prototypes in 6/6 as they are? (For the second hunk
in 5/6, you could just pull the start of the line back two cols.)
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/6] SD/MMC driver for MX25/35/51
Date: Mon, 11 Oct 2010 17:59:29 +0100 [thread overview]
Message-ID: <20101011165929.GB21335@void.printf.net> (raw)
In-Reply-To: <20101011164459.GB476@pengutronix.de>
Hi Wolfram,
On Mon, Oct 11, 2010 at 06:44:59PM +0200, Wolfram Sang wrote:
> > Mind fixing up the >80 char lines in the last two patches? It's just:
>
> Sigh, I don't think it will help the readability of the code, but if it can't
> be helped...
Okay. Perhaps as a compromise, just reflow the two lines in 5/6 and
leave the long prototypes in 6/6 as they are? (For the second hunk
in 5/6, you could just pull the start of the line back two cols.)
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-10-11 16:59 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 14:21 [PATCH 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-11 14:21 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-11 14:21 ` [PATCH 2/6] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-11 14:21 ` [PATCH 3/6] mmc: sdhci: introduce private get_ro Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-11 14:21 ` [PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-11 14:21 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-11 17:10 ` [PATCH v2 " Wolfram Sang
2010-10-11 17:10 ` Wolfram Sang
2010-10-11 18:33 ` Chris Ball
2010-10-11 18:33 ` Chris Ball
2010-10-13 10:22 ` Zhu Richard-R65037
2010-10-13 10:22 ` Zhu Richard-R65037
2010-10-13 10:31 ` Wolfram Sang
2010-10-13 10:31 ` Wolfram Sang
2010-10-11 14:21 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-10-14 3:07 ` Chris Ball
2010-10-14 3:07 ` Chris Ball
2010-10-11 16:32 ` [PATCH 0/6] SD/MMC driver for MX25/35/51 Chris Ball
2010-10-11 16:32 ` Chris Ball
2010-10-11 16:44 ` Wolfram Sang
2010-10-11 16:44 ` Wolfram Sang
2010-10-11 16:59 ` Chris Ball [this message]
2010-10-11 16:59 ` Chris Ball
2010-10-12 22:06 ` Arnaud Patard
2010-10-12 22:06 ` Arnaud Patard (Rtp)
2010-10-13 8:15 ` Eric Bénard
2010-10-13 8:15 ` Eric Bénard
2010-10-13 8:29 ` Wolfram Sang
2010-10-13 8:29 ` Wolfram Sang
2010-10-13 9:28 ` Arnaud Patard
2010-10-13 9:28 ` Arnaud Patard (Rtp)
2010-10-13 9:53 ` Zhu Richard-R65037
2010-10-13 9:53 ` Zhu Richard-R65037
2010-10-13 10:06 ` Wolfram Sang
2010-10-13 10:06 ` Wolfram Sang
2010-10-13 10:09 ` Eric Bénard
2010-10-13 10:09 ` Eric Bénard
2010-10-13 10:13 ` Zhu Richard-R65037
2010-10-13 10:13 ` Zhu Richard-R65037
2010-10-13 10:20 ` Wolfram Sang
2010-10-13 10:20 ` Wolfram Sang
2010-10-15 10:27 ` Wolfram Sang
2010-10-15 10:27 ` Wolfram Sang
2010-10-18 3:29 ` Zhu Richard-R65037
2010-10-18 3:29 ` Zhu Richard-R65037
2010-10-18 8:48 ` Zhu Richard-R65037
2010-10-18 8:48 ` Zhu Richard-R65037
2010-10-18 9:36 ` Eric Bénard
2010-10-18 9:36 ` Eric Bénard
2010-10-18 9:44 ` Zhu Richard-R65037
2010-10-18 9:44 ` Zhu Richard-R65037
2010-10-18 11:38 ` Wolfram Sang
2010-10-18 11:38 ` Wolfram Sang
2010-10-18 11:51 ` Eric Bénard
2010-10-18 11:51 ` Eric Bénard
2010-10-18 11:36 ` Wolfram Sang
2010-10-18 11:36 ` Wolfram Sang
2010-10-15 10:25 ` Wolfram Sang
2010-10-15 10:25 ` Wolfram Sang
2010-10-15 21:20 ` Arnaud Patard
2010-10-15 21:20 ` Arnaud Patard (Rtp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011165929.GB21335@void.printf.net \
--to=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.