From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arun Murthy <arun.murthy@stericsson.com>
Cc: eric.y.miao@gmail.com, linux@arm.linux.org.uk,
grinberg@compulab.co.il, mike@compulab.co.il,
robert.jarzmik@free.fr, marek.vasut@gmail.com, drwyrm@gmail.com,
stefan@openezx.org, laforge@openezx.org,
ospite@studenti.unina.it, philipp.zabel@gmail.com,
mad_soft@inbox.ru, maz@misterjones.org, daniel@caiaq.de,
haojian.zhuang@marvell.com, timur@freescale.com,
ben-linux@fluff.org, support@simtec.co.uk,
arnaud.patard@rtp-net.org, dgreenday@gmail.com,
anarsoul@gmail.com, akpm@linux-foundation.org,
mcuelenaere@gmail.com, kernel@pengutronix.de,
andre.goddard@gmail.com, jkosina@suse.cz, tj@kernel.org,
hsweeten@visionengravers.com, u.kleine-koenig@pengutronix.de,
kgene.kim@samsung.com, ralf@linux-mips.org, lars@metafoo.de,
dilinger@collabora.co.uk, mroth@nessie.de,
randy.dunlap@oracle.com, lethal@linux-sh.org,
rusty@rustcorp.com.au, damm@opensource.se, mst@redhat.com,
rpurdie@rpsys.net, sguinot@lacie.co, sameo@linux.intel.com,
balajitk@ti.com, rnayak@ti.com, santosh.shilimkar@ti.com,
hemanthv@ti.com, michael.hennerich@analog.com, vapier@gentoo.org,
khali@linux-fr.org, jic23@cam.ac.uk, re.emese@gmail.com,
linux@simtec.co.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
linus.walleij@stericsson.com, mattias.wallin@stericsson.com
Subject: Re: [PATCH 2/7] backlight:pwm: add an element 'name' to platform data
Date: Tue, 28 Sep 2010 10:47:45 -0700 [thread overview]
Message-ID: <20100928174744.GF10739@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1285659648-21409-3-git-send-email-arun.murthy@stericsson.com>
On Tue, Sep 28, 2010 at 01:10:43PM +0530, Arun Murthy wrote:
> A new element 'name' is added to pwm backlight platform data structure.
> This is required to identify the pwm device.
> - pb->pwm = pwm_request(data->pwm_id, "backlight");
> + if (!data->name)
> + data->name = "backlight";
> + pb->pwm = pwm_request(data->pwm_id, data->name);
If we're going to go through and require that all PWM API users be
updated to take platform data for the name might it not be better to
switch over to the clock API style request by device interface?
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] backlight:pwm: add an element 'name' to platform data
Date: Tue, 28 Sep 2010 10:47:45 -0700 [thread overview]
Message-ID: <20100928174744.GF10739@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1285659648-21409-3-git-send-email-arun.murthy@stericsson.com>
On Tue, Sep 28, 2010 at 01:10:43PM +0530, Arun Murthy wrote:
> A new element 'name' is added to pwm backlight platform data structure.
> This is required to identify the pwm device.
> - pb->pwm = pwm_request(data->pwm_id, "backlight");
> + if (!data->name)
> + data->name = "backlight";
> + pb->pwm = pwm_request(data->pwm_id, data->name);
If we're going to go through and require that all PWM API users be
updated to take platform data for the name might it not be better to
switch over to the clock API style request by device interface?
next prev parent reply other threads:[~2010-09-28 17:47 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 7:40 [PATCHv2 0/7] PWM core driver for pwm based led and backlight driver Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` [PATCH 1/7] pwm: Add pwm core driver Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 8:14 ` Vasily Khoruzhick
2010-09-28 8:14 ` Vasily Khoruzhick
2010-09-28 8:38 ` Arun MURTHY
2010-09-28 8:47 ` Vasily Khoruzhick
2010-09-28 8:47 ` Vasily Khoruzhick
2010-09-28 8:57 ` Arun MURTHY
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FA8F@EXDCVYMBSTM006.EQ1STM.loca l>
2010-09-28 8:50 ` Hemanth V
2010-09-28 8:50 ` Hemanth V
2010-09-28 9:03 ` Arun MURTHY
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FB21@EXDCVYMBSTM006.EQ1STM.loca l>
2010-09-28 9:34 ` Hemanth V
2010-09-28 9:34 ` Hemanth V
2010-09-28 9:34 ` Hemanth V
2010-09-28 9:49 ` Arun MURTHY
2010-09-28 9:49 ` Arun MURTHY
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FBF9@EXDCVYMBSTM006.EQ1STM.loca l>
2010-09-28 10:41 ` Hemanth V
2010-09-28 10:41 ` Hemanth V
2010-09-28 10:41 ` Hemanth V
2010-09-28 10:53 ` Arun MURTHY
2010-09-28 8:54 ` Lars-Peter Clausen
2010-09-28 8:54 ` Lars-Peter Clausen
2010-09-28 9:18 ` Arun MURTHY
2010-09-28 9:57 ` Lars-Peter Clausen
2010-09-28 9:57 ` Lars-Peter Clausen
2010-09-28 10:28 ` Arun MURTHY
2010-09-28 21:04 ` Lars-Peter Clausen
2010-09-28 21:04 ` Lars-Peter Clausen
2010-09-28 21:04 ` Lars-Peter Clausen
2010-09-28 21:04 ` Lars-Peter Clausen
2010-09-29 4:49 ` Arun MURTHY
2010-09-29 4:49 ` Arun MURTHY
2010-09-29 4:49 ` Arun MURTHY
2010-09-29 12:12 ` Trilok Soni
2010-09-29 12:12 ` Trilok Soni
2010-09-29 12:12 ` Trilok Soni
2010-10-01 3:25 ` Arun MURTHY
2010-10-01 3:25 ` Arun MURTHY
2010-10-01 3:25 ` Arun MURTHY
2010-10-01 6:47 ` Trilok Soni
2010-10-01 6:47 ` Trilok Soni
2010-10-01 6:47 ` Trilok Soni
2010-10-01 7:25 ` Arun MURTHY
2010-10-01 7:25 ` Arun MURTHY
2010-10-01 7:25 ` Arun MURTHY
2010-10-01 7:42 ` Jassi Brar
2010-10-01 7:42 ` Jassi Brar
2010-10-01 7:42 ` Jassi Brar
2010-10-01 8:46 ` Arun MURTHY
2010-10-01 8:46 ` Arun MURTHY
2010-10-01 8:46 ` Arun MURTHY
2010-10-01 10:39 ` Jassi Brar
2010-10-01 10:39 ` Jassi Brar
2010-10-01 10:39 ` Jassi Brar
2010-10-01 18:00 ` Mark Brown
2010-10-01 18:00 ` Mark Brown
2010-10-01 18:00 ` Mark Brown
2010-10-04 4:22 ` Arun MURTHY
2010-10-04 4:22 ` Arun MURTHY
2010-10-04 4:22 ` Arun MURTHY
2010-09-28 17:46 ` Mark Brown
2010-09-28 17:46 ` Mark Brown
2010-09-28 19:42 ` Ryan Mallon
2010-09-28 19:42 ` Ryan Mallon
2010-09-28 7:40 ` [PATCH 2/7] backlight:pwm: add an element 'name' to platform data Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 17:47 ` Mark Brown [this message]
2010-09-28 17:47 ` Mark Brown
2010-09-28 7:40 ` [PATCH 3/7] leds: pwm: add a new " Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 8:01 ` Eric Miao
2010-09-28 8:01 ` Eric Miao
2010-09-28 8:36 ` Arun MURTHY
2010-09-28 8:36 ` Arun MURTHY
2010-09-28 7:40 ` [PATCH 4/7] pwm: Align existing pwm drivers with pwm-core driver Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 8:58 ` Lars-Peter Clausen
2010-09-28 8:58 ` Lars-Peter Clausen
2010-09-28 9:26 ` Arun MURTHY
2010-09-28 10:10 ` Lars-Peter Clausen
2010-09-28 10:10 ` Lars-Peter Clausen
2010-09-28 10:33 ` Arun MURTHY
2010-09-28 7:40 ` [PATCH 5/7] platform: Update the pwm based led and backlight platform data Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` [PATCH 6/7] pwm: move existing pwm driver to drivers/pwm Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 8:02 ` Eric Miao
2010-09-28 7:40 ` [PATCH 7/7] pwm: Modify backlight and led Kconfig aligning to pwm core Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
-- strict thread matches above, loose matches on Subject: below --
2010-09-28 10:35 [PATCH 0/7] PWM core driver for pwm based led and backlight driver Arun Murthy
2010-09-28 10:35 ` [PATCH 2/7] backlight:pwm: add an element 'name' to platform data Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928174744.GF10739@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=anarsoul@gmail.com \
--cc=andre.goddard@gmail.com \
--cc=arnaud.patard@rtp-net.org \
--cc=arun.murthy@stericsson.com \
--cc=balajitk@ti.com \
--cc=ben-linux@fluff.org \
--cc=damm@opensource.se \
--cc=daniel@caiaq.de \
--cc=dgreenday@gmail.com \
--cc=dilinger@collabora.co.uk \
--cc=drwyrm@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=grinberg@compulab.co.il \
--cc=haojian.zhuang@marvell.com \
--cc=hemanthv@ti.com \
--cc=hsweeten@visionengravers.com \
--cc=jic23@cam.ac.uk \
--cc=jkosina@suse.cz \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=khali@linux-fr.org \
--cc=laforge@openezx.org \
--cc=lars@metafoo.de \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@simtec.co.uk \
--cc=mad_soft@inbox.ru \
--cc=marek.vasut@gmail.com \
--cc=mattias.wallin@stericsson.com \
--cc=maz@misterjones.org \
--cc=mcuelenaere@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=mike@compulab.co.il \
--cc=mroth@nessie.de \
--cc=mst@redhat.com \
--cc=ospite@studenti.unina.it \
--cc=philipp.zabel@gmail.com \
--cc=ralf@linux-mips.org \
--cc=randy.dunlap@oracle.com \
--cc=re.emese@gmail.com \
--cc=rnayak@ti.com \
--cc=robert.jarzmik@free.fr \
--cc=rpurdie@rpsys.net \
--cc=rusty@rustcorp.com.au \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=sguinot@lacie.co \
--cc=stefan@openezx.org \
--cc=support@simtec.co.uk \
--cc=timur@freescale.com \
--cc=tj@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.