All of lore.kernel.org
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] SPI: add PrimeCell generic DMA to PL022 v12
Date: Wed, 29 Sep 2010 17:20:55 +0900	[thread overview]
Message-ID: <20100929082055.GC4703@angua.secretlab.ca> (raw)
In-Reply-To: <1285684441-21700-2-git-send-email-linus.walleij@stericsson.com>

On Tue, Sep 28, 2010 at 04:33:55PM +0200, Linus Walleij wrote:
> This extends the PL022 SSP/SPI driver with generic DMA engine
> support using the PrimeCell DMA engine interface. Also fix up the
> test code for the U300 platform.
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> ---
> Changes:
> - Switch CONFIG_DMADEVICES for CONFIG_DMA_ENGINE to counter
>   a compilation error spotted by Grant.
> ---
>  arch/arm/mach-u300/dummyspichip.c |    1 +
>  drivers/spi/amba-pl022.c          |  516 ++++++++++++++++++++++++++++++-------
>  include/linux/amba/pl022.h        |    6 +
>  3 files changed, 435 insertions(+), 88 deletions(-)
> 
> diff --git a/arch/arm/mach-u300/dummyspichip.c b/arch/arm/mach-u300/dummyspichip.c
> index 03f7936..b86e944 100644
> --- a/arch/arm/mach-u300/dummyspichip.c
> +++ b/arch/arm/mach-u300/dummyspichip.c
> @@ -267,6 +267,7 @@ static struct spi_driver pl022_dummy_driver = {
>  	.driver = {
>  		.name	= "spi-dummy",
>  		.owner	= THIS_MODULE,
> +		.bus = &spi_bus_type,

This shouldn't be necessary.  spi_register_driver already sets the bus
type field.

Otherwise, this patch looks good.  If you're okay with me dropping
this hunk, then I'll pick up this patch into my next-spi branch.

g.

WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org, yuanyabin1978@sina.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] SPI: add PrimeCell generic DMA to PL022 v12
Date: Wed, 29 Sep 2010 17:20:55 +0900	[thread overview]
Message-ID: <20100929082055.GC4703@angua.secretlab.ca> (raw)
In-Reply-To: <1285684441-21700-2-git-send-email-linus.walleij@stericsson.com>

On Tue, Sep 28, 2010 at 04:33:55PM +0200, Linus Walleij wrote:
> This extends the PL022 SSP/SPI driver with generic DMA engine
> support using the PrimeCell DMA engine interface. Also fix up the
> test code for the U300 platform.
> 
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> ---
> Changes:
> - Switch CONFIG_DMADEVICES for CONFIG_DMA_ENGINE to counter
>   a compilation error spotted by Grant.
> ---
>  arch/arm/mach-u300/dummyspichip.c |    1 +
>  drivers/spi/amba-pl022.c          |  516 ++++++++++++++++++++++++++++++-------
>  include/linux/amba/pl022.h        |    6 +
>  3 files changed, 435 insertions(+), 88 deletions(-)
> 
> diff --git a/arch/arm/mach-u300/dummyspichip.c b/arch/arm/mach-u300/dummyspichip.c
> index 03f7936..b86e944 100644
> --- a/arch/arm/mach-u300/dummyspichip.c
> +++ b/arch/arm/mach-u300/dummyspichip.c
> @@ -267,6 +267,7 @@ static struct spi_driver pl022_dummy_driver = {
>  	.driver = {
>  		.name	= "spi-dummy",
>  		.owner	= THIS_MODULE,
> +		.bus = &spi_bus_type,

This shouldn't be necessary.  spi_register_driver already sets the bus
type field.

Otherwise, this patch looks good.  If you're okay with me dropping
this hunk, then I'll pick up this patch into my next-spi branch.

g.

  parent reply	other threads:[~2010-09-29  8:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28 14:33 [PATCH 0/7] PrimeCell Generic DMA v12 Linus Walleij
2010-09-28 14:33 ` Linus Walleij
2010-09-28 14:33 ` [PATCH 1/7] SPI: add PrimeCell generic DMA to PL022 v12 Linus Walleij
2010-09-28 14:33   ` Linus Walleij
2010-09-28 14:33   ` [PATCH 2/7] ARM: add PrimeCell generic DMA to PL011 v12 Linus Walleij
2010-09-28 14:33     ` Linus Walleij
2010-09-28 14:33     ` [PATCH 3/7] ARM: add PrimeCell generic DMA to MMCI/PL180 v12 Linus Walleij
2010-09-28 14:33       ` Linus Walleij
2010-09-28 14:33       ` [PATCH 4/7] ARM: config U300 PL180 PL011 PL022 for DMA v12 Linus Walleij
2010-09-28 14:33         ` Linus Walleij
2010-09-28 14:33         ` [PATCH 5/7] ARM: config Ux500 PL011 PL022 PL180 " Linus Walleij
2010-09-28 14:33           ` Linus Walleij
2010-09-28 14:34           ` [PATCH 6/7] ARM: config RealViews PL011 PL022 " Linus Walleij
2010-09-28 14:34             ` Linus Walleij
2010-09-28 14:34             ` [PATCH 7/7] ARM: config Versatiles " Linus Walleij
2010-09-28 14:34               ` Linus Walleij
2010-09-29  8:20   ` Grant Likely [this message]
2010-09-29  8:20     ` [PATCH 1/7] SPI: add PrimeCell generic DMA to PL022 v12 Grant Likely
2010-09-29 11:54     ` Linus Walleij
2010-09-29 11:54       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100929082055.GC4703@angua.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.