* [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged
@ 2010-09-29 20:39 Frans Meulenbroeks
2010-09-29 21:03 ` Denys Dmytriyenko
2010-09-29 21:35 ` Paul Menzel
0 siblings, 2 replies; 6+ messages in thread
From: Frans Meulenbroeks @ 2010-09-29 20:39 UTC (permalink / raw)
To: openembedded-devel
copy the files directly from the work area to staging. That way
there are no unpackaged files in image/ so no NOTE messages.
Additional advantage is that it is faster as we save the copy to the image dir.
See also http://thread.gmane.org/gmane.comp.handhelds.openembedded/37487
Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Acked-by: Roman I Khimov <khimov@altell.ru>
Tested-by: Petr ?tetiar <ynezz@true.cz>
Acked-by: Eric B?nard <eric@eukrea.com>
---
This is the formal patch, following up the discussion mentioned above
It really works like a charm. Kernel build time is greatly reduced.
If there are no objections, and since there are already 2 acks,
I will push tomorrow my evening (20 hrs or so after posting)
Feel free to add additional acks.
Frans
classes/kernel.bbclass | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/classes/kernel.bbclass b/classes/kernel.bbclass
index 5f8bc8a..cfb4ad8 100644
--- a/classes/kernel.bbclass
+++ b/classes/kernel.bbclass
@@ -121,7 +121,12 @@ kernel_do_install() {
oe_runmake SUBDIRS="scripts/genksyms"
fi
- kerneldir=${D}/kernel/
+
+}
+
+sysroot_stage_all_append() {
+
+ kerneldir=${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
if [ -e include/asm ] ; then
# This link is generated only in kernel before 2.6.33-rc1, don't stage it for newer kernels
@@ -200,11 +205,6 @@ kernel_do_install() {
cp -fR scripts $kerneldir/
}
-sysroot_stage_all_append() {
- sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
- cp -fpPR ${D}/kernel/.config ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
-}
-
kernel_do_configure() {
yes '' | oe_runmake oldconfig
if [ ! -z "${INITRAMFS_IMAGE}" ]; then
--
1.6.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged
2010-09-29 20:39 [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged Frans Meulenbroeks
@ 2010-09-29 21:03 ` Denys Dmytriyenko
2010-09-29 21:35 ` Paul Menzel
1 sibling, 0 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2010-09-29 21:03 UTC (permalink / raw)
To: openembedded-devel
On Wed, Sep 29, 2010 at 10:39:58PM +0200, Frans Meulenbroeks wrote:
> copy the files directly from the work area to staging. That way
> there are no unpackaged files in image/ so no NOTE messages.
> Additional advantage is that it is faster as we save the copy to the image dir.
>
> See also http://thread.gmane.org/gmane.comp.handhelds.openembedded/37487
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> Acked-by: Roman I Khimov <khimov@altell.ru>
> Tested-by: Petr ?tetiar <ynezz@true.cz>
> Acked-by: Eric B?nard <eric@eukrea.com>
Acked-by: Denys Dmytriyenko <denis@denix.org>
> ---
>
> This is the formal patch, following up the discussion mentioned above
> It really works like a charm. Kernel build time is greatly reduced.
>
> If there are no objections, and since there are already 2 acks,
> I will push tomorrow my evening (20 hrs or so after posting)
> Feel free to add additional acks.
>
> Frans
>
> classes/kernel.bbclass | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/classes/kernel.bbclass b/classes/kernel.bbclass
> index 5f8bc8a..cfb4ad8 100644
> --- a/classes/kernel.bbclass
> +++ b/classes/kernel.bbclass
> @@ -121,7 +121,12 @@ kernel_do_install() {
> oe_runmake SUBDIRS="scripts/genksyms"
> fi
>
> - kerneldir=${D}/kernel/
> +
> +}
> +
> +sysroot_stage_all_append() {
> +
> + kerneldir=${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
>
> if [ -e include/asm ] ; then
> # This link is generated only in kernel before 2.6.33-rc1, don't stage it for newer kernels
> @@ -200,11 +205,6 @@ kernel_do_install() {
> cp -fR scripts $kerneldir/
> }
>
> -sysroot_stage_all_append() {
> - sysroot_stage_dir ${D}/kernel ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
> - cp -fpPR ${D}/kernel/.config ${SYSROOT_DESTDIR}${STAGING_KERNEL_DIR}
> -}
> -
> kernel_do_configure() {
> yes '' | oe_runmake oldconfig
> if [ ! -z "${INITRAMFS_IMAGE}" ]; then
> --
> 1.6.4.2
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged
2010-09-29 20:39 [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged Frans Meulenbroeks
2010-09-29 21:03 ` Denys Dmytriyenko
@ 2010-09-29 21:35 ` Paul Menzel
2010-09-30 6:30 ` Frans Meulenbroeks
1 sibling, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2010-09-29 21:35 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
Dear Frans,
Am Mittwoch, den 29.09.2010, 22:39 +0200 schrieb Frans Meulenbroeks:
> copy the files directly from the work area to staging. That way
> there are no unpackaged files in image/ so no NOTE messages.
> Additional advantage is that it is faster as we save the copy to the image dir.
>
> See also http://thread.gmane.org/gmane.comp.handhelds.openembedded/37487
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> Acked-by: Roman I Khimov <khimov@altell.ru>
> Tested-by: Petr ?tetiar <ynezz@true.cz>
> Acked-by: Eric B?nard <eric@eukrea.com>
please fix the special characters when you commit this.
I tried to apply your patch using `pwam.sh 3097` and saw that you
already accidentally had commited this patch in
9a5382aad4e5a3e52fa52722cf5587fdba958e9f [1].
wpa-supplicant : moved unused files to obsolete dir
Please revert that commit and commit appropriately.
[…]
Thanks,
Paul
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=9a5382aad4e5a3e52fa52722cf5587fdba958e9f
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged
2010-09-29 21:35 ` Paul Menzel
@ 2010-09-30 6:30 ` Frans Meulenbroeks
2010-09-30 9:45 ` Paul Menzel
0 siblings, 1 reply; 6+ messages in thread
From: Frans Meulenbroeks @ 2010-09-30 6:30 UTC (permalink / raw)
To: openembedded-devel
2010/9/29 Paul Menzel <paulepanter@users.sourceforge.net>:
> Dear Frans,
>
>
> Am Mittwoch, den 29.09.2010, 22:39 +0200 schrieb Frans Meulenbroeks:
>> copy the files directly from the work area to staging. That way
>> there are no unpackaged files in image/ so no NOTE messages.
>> Additional advantage is that it is faster as we save the copy to the image dir.
>>
>> See also http://thread.gmane.org/gmane.comp.handhelds.openembedded/37487
>>
>> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
>> Acked-by: Roman I Khimov <khimov@altell.ru>
>> Tested-by: Petr ?tetiar <ynezz@true.cz>
>> Acked-by: Eric B?nard <eric@eukrea.com>
>
> please fix the special characters when you commit this.
Will do, I have just cut'n'pasted the lines. but I agree I was lazy
and it was better to fix this.
>
> I tried to apply your patch using `pwam.sh 3097` and saw that you
> already accidentally had commited this patch in
> 9a5382aad4e5a3e52fa52722cf5587fdba958e9f [1].
>
> wpa-supplicant : moved unused files to obsolete dir
>
> Please revert that commit and commit appropriately.
Thanks for spotting this. I have already reverted the commit.
Will make a new patch for it.
Guess this accidently got picked up by the wpa-supplicant commit and
went unnoticed.
I'll try to take some more care next time.
apologies for any inconvenience.
Frans
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-04 14:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-29 20:39 [PATCH] kernel.bbclass: avoid NOTE messages for files that are staged but not packaged Frans Meulenbroeks
2010-09-29 21:03 ` Denys Dmytriyenko
2010-09-29 21:35 ` Paul Menzel
2010-09-30 6:30 ` Frans Meulenbroeks
2010-09-30 9:45 ` Paul Menzel
2010-10-04 14:27 ` Frans Meulenbroeks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.