From: Dave Chinner <david@fromorbit.com>
To: Arkadiusz Miskiewicz <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*()
Date: Thu, 30 Sep 2010 09:24:46 +1000 [thread overview]
Message-ID: <20100929232445.GR5665@dastard> (raw)
In-Reply-To: <201009291954.32292.arekm@maven.pl>
On Wed, Sep 29, 2010 at 07:54:32PM +0200, Arkadiusz Miskiewicz wrote:
> On Wednesday 29 of September 2010, Lukas Czerner wrote:
> > Pass MKFS_OPTIONS to mkfs.$FSTYP in _scratch_mkfs_sized().
> > Preserve user defined MKFS_OPTIONS in _scratch_mkfs_geom().
> > ---
> > common.rc | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/common.rc b/common.rc
> [...]
> > case $FSTYP in
> > xfs)
> > - MKFS_OPTIONS="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"
> > + MKFS_OPTIONS+="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"
>
> common.rc uses /bin/sh and += notation is a bashizm. Won't work on strict
> posix shells.
We've converted all of xfstests to use bash rather than bin/sh because of
all the bashisms in the code, so this is fine.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-09-29 23:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 14:35 [PATCH 1/2] xfstests 224: Use $SCRATCH_MNT variable Lukas Czerner
2010-09-29 14:35 ` [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*() Lukas Czerner
2010-09-29 16:26 ` Eric Sandeen
2010-09-29 17:54 ` Arkadiusz Miskiewicz
2010-09-29 23:24 ` Dave Chinner [this message]
2010-09-29 16:18 ` [PATCH 1/2] xfstests 224: Use $SCRATCH_MNT variable Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929232445.GR5665@dastard \
--to=david@fromorbit.com \
--cc=arekm@maven.pl \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.