All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: esandeen@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*()
Date: Wed, 29 Sep 2010 11:26:54 -0500	[thread overview]
Message-ID: <4CA368CE.3010907@redhat.com> (raw)
In-Reply-To: <1285770951-27000-2-git-send-email-lczerner@redhat.com>

Lukas Czerner wrote:
> Pass MKFS_OPTIONS to mkfs.$FSTYP in _scratch_mkfs_sized().
> Preserve user defined MKFS_OPTIONS in _scratch_mkfs_geom().
> ---

thanks, this looks good too.  both are committed now.

-Eric

>  common.rc |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/common.rc b/common.rc
> index 65989c1..52b7125 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -327,7 +327,7 @@ _scratch_mkfs_sized()
>  	_scratch_mkfs_xfs -d size=$fssize -b size=$blocksize
>  	;;
>      ext2|ext3|ext4)
> -	/sbin/mkfs.$FSTYP -b $blocksize $SCRATCH_DEV $blocks
> +	/sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
>  	;;
>      *)
>  	_notrun "Filesystem $FSTYP not supported in _scratch_mkfs_sized"
> @@ -349,10 +349,10 @@ _scratch_mkfs_geom()
>  
>      case $FSTYP in
>      xfs)
> -	MKFS_OPTIONS="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"
> +	MKFS_OPTIONS+="-b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult"
>  	;;
>      ext4)
> -	MKFS_OPTIONS="-b $blocksize -E stride=$sunit_blocks,stripe_width=$swidth_blocks"
> +	MKFS_OPTIONS+="-b $blocksize -E stride=$sunit_blocks,stripe_width=$swidth_blocks"
>  	;;
>      *)
>  	_notrun "can't mkfs $FSTYP with geometry"

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-09-29 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 14:35 [PATCH 1/2] xfstests 224: Use $SCRATCH_MNT variable Lukas Czerner
2010-09-29 14:35 ` [PATCH 2/2] xfstests: Use $MKFS_OPTIONS in _scratch_mkfs_*() Lukas Czerner
2010-09-29 16:26   ` Eric Sandeen [this message]
2010-09-29 17:54   ` Arkadiusz Miskiewicz
2010-09-29 23:24     ` Dave Chinner
2010-09-29 16:18 ` [PATCH 1/2] xfstests 224: Use $SCRATCH_MNT variable Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA368CE.3010907@redhat.com \
    --to=sandeen@redhat.com \
    --cc=esandeen@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.