From: Greg KH <greg@kroah.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org,
Marek Belisko <marek.belisko@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix skb, netdev, memory leaks
Date: Thu, 30 Sep 2010 11:13:45 +0000 [thread overview]
Message-ID: <20100930111345.GA9978@kroah.com> (raw)
In-Reply-To: <1285696175-5654-1-git-send-email-segooon@gmail.com>
On Tue, Sep 28, 2010 at 09:49:35PM +0400, Vasiliy Kulikov wrote:
> ft1000_copy_up_pkt() doesn't free skb on errors.
> init_ft1000_card() doesn't free netdev with free_netdev() but with kfree().
> init_ft1000_card() doesn't check request_region()'s return value
> and doesn't free region on error.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> Compile tested.
No you didn't
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 32 +++++++++++++--------
> 1 files changed, 20 insertions(+), 12 deletions(-)
This file doesn't build at this point in time, how did you build test
this?
I don't mind taking the patch, but please, don't lie.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org,
Marek Belisko <marek.belisko@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix skb, netdev, memory leaks
Date: Thu, 30 Sep 2010 04:13:45 -0700 [thread overview]
Message-ID: <20100930111345.GA9978@kroah.com> (raw)
In-Reply-To: <1285696175-5654-1-git-send-email-segooon@gmail.com>
On Tue, Sep 28, 2010 at 09:49:35PM +0400, Vasiliy Kulikov wrote:
> ft1000_copy_up_pkt() doesn't free skb on errors.
> init_ft1000_card() doesn't free netdev with free_netdev() but with kfree().
> init_ft1000_card() doesn't check request_region()'s return value
> and doesn't free region on error.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> Compile tested.
No you didn't
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 32 +++++++++++++--------
> 1 files changed, 20 insertions(+), 12 deletions(-)
This file doesn't build at this point in time, how did you build test
this?
I don't mind taking the patch, but please, don't lie.
thanks,
greg k-h
next prev parent reply other threads:[~2010-09-30 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 8:59 [PATCH] staging: ft1000: fix skb, netdev, memory leaks Vasiliy Kulikov
2010-09-26 8:59 ` Vasiliy Kulikov
2010-09-28 17:49 ` Vasiliy Kulikov
2010-09-28 17:49 ` Vasiliy Kulikov
2010-09-30 11:13 ` Greg KH [this message]
2010-09-30 11:13 ` Greg KH
2010-09-30 19:23 ` Vasiliy Kulikov
2010-09-30 19:23 ` Vasiliy Kulikov
2010-09-30 19:53 ` Greg KH
2010-09-30 19:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930111345.GA9978@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.