From: Tony Lindgren <tony@atomide.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: Cory Maccarrone <darkstar6262@gmail.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] [OMAP] HTCHERALD: MMC, I2C, HTCPLD, SPI, TSC2046
Date: Thu, 30 Sep 2010 12:15:35 -0700 [thread overview]
Message-ID: <20100930191535.GM3117@atomide.com> (raw)
In-Reply-To: <AANLkTimsk+vbi15xz5bxJyQrF0yXF3i7Dn=TajjV3tkU@mail.gmail.com>
* Michał Mirosław <mirqus@gmail.com> [100930 11:57]:
> 2010/9/30 Tony Lindgren <tony@atomide.com>:
> > * Cory Maccarrone <darkstar6262@gmail.com> [100930 11:34]:
> >> > Looks like also board-sx1-mmc.c and board-h[23]-mmc.c have the
> >> > same spotty voltage range.
> >> > Cory, care to do a patch that fixes it for all of them?
> >> Yeah, I can do that. I'll resubmit this patch too with the fixed up ranges.
> > Turns out I already did it :) Care to test/ack this one?
>
> [...]
> > diff --git a/arch/arm/mach-omap1/board-sx1-mmc.c b/arch/arm/mach-omap1/board-sx1-mmc.c
> > index 5b33ae8..be5a365 100644
> > --- a/arch/arm/mach-omap1/board-sx1-mmc.c
> > +++ b/arch/arm/mach-omap1/board-sx1-mmc.c
> > @@ -44,7 +44,8 @@ static struct omap_mmc_platform_data mmc1_data = {
> > .nr_slots = 1,
> > .slots[0] = {
> > .set_power = mmc_set_power,
> > - .ocr_mask = MMC_VDD_28_29 | MMC_VDD_30_31 |
> > + .ocr_mask = MMC_VDD_28_29 | MMC_VDD_29_30 |
> > + MMC_VDD_30_31 | MMC_VDD_31_32 |
> > MMC_VDD_32_33 | MMC_VDD_33_34,
> > .name = "mmcblk",
> > },
> [...]
>
> Al least this one seems wrong (haven't checked others) as the
> mmc_set_power() ignores vdd parameter. This suggests that the board
> supports only one particular voltage, not the whole range.
Hmm yeah good catch. With the external power it's board specific.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [OMAP] HTCHERALD: MMC, I2C, HTCPLD, SPI, TSC2046
Date: Thu, 30 Sep 2010 12:15:35 -0700 [thread overview]
Message-ID: <20100930191535.GM3117@atomide.com> (raw)
In-Reply-To: <AANLkTimsk+vbi15xz5bxJyQrF0yXF3i7Dn=TajjV3tkU@mail.gmail.com>
* Micha? Miros?aw <mirqus@gmail.com> [100930 11:57]:
> 2010/9/30 Tony Lindgren <tony@atomide.com>:
> > * Cory Maccarrone <darkstar6262@gmail.com> [100930 11:34]:
> >> > Looks like also board-sx1-mmc.c and board-h[23]-mmc.c have the
> >> > same spotty voltage range.
> >> > Cory, care to do a patch that fixes it for all of them?
> >> Yeah, I can do that. ?I'll resubmit this patch too with the fixed up ranges.
> > Turns out I already did it :) Care to test/ack this one?
>
> [...]
> > diff --git a/arch/arm/mach-omap1/board-sx1-mmc.c b/arch/arm/mach-omap1/board-sx1-mmc.c
> > index 5b33ae8..be5a365 100644
> > --- a/arch/arm/mach-omap1/board-sx1-mmc.c
> > +++ b/arch/arm/mach-omap1/board-sx1-mmc.c
> > @@ -44,7 +44,8 @@ static struct omap_mmc_platform_data mmc1_data = {
> > ? ? ? ?.nr_slots ? ? ? ? ? ? ? ? ? ? ? = 1,
> > ? ? ? ?.slots[0] ? ? ? = {
> > ? ? ? ? ? ? ? ?.set_power ? ? ? ? ? ? ?= mmc_set_power,
> > - ? ? ? ? ? ? ? .ocr_mask ? ? ? ? ? ? ? = MMC_VDD_28_29 | MMC_VDD_30_31 |
> > + ? ? ? ? ? ? ? .ocr_mask ? ? ? ? ? ? ? = MMC_VDD_28_29 | MMC_VDD_29_30 |
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? MMC_VDD_30_31 | MMC_VDD_31_32 |
> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?MMC_VDD_32_33 | MMC_VDD_33_34,
> > ? ? ? ? ? ? ? ?.name ? ? ? ? ? ? ? ? ? = "mmcblk",
> > ? ? ? ?},
> [...]
>
> Al least this one seems wrong (haven't checked others) as the
> mmc_set_power() ignores vdd parameter. This suggests that the board
> supports only one particular voltage, not the whole range.
Hmm yeah good catch. With the external power it's board specific.
Tony
next prev parent reply other threads:[~2010-09-30 19:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 4:34 [PATCH] [OMAP] HTCHERALD: MMC, I2C, HTCPLD, SPI, TSC2046 Cory Maccarrone
2010-08-18 4:35 ` Cory Maccarrone
2010-08-18 4:35 ` Cory Maccarrone
2010-09-23 17:22 ` Tony Lindgren
2010-09-23 17:22 ` Tony Lindgren
2010-09-23 17:26 ` Cory Maccarrone
2010-09-23 17:26 ` Cory Maccarrone
2010-09-24 0:30 ` Tony Lindgren
2010-09-24 0:30 ` Tony Lindgren
2010-09-24 9:23 ` Michał Mirosław
2010-09-24 9:23 ` Michał Mirosław
2010-09-24 15:38 ` Cory Maccarrone
2010-09-24 15:38 ` Cory Maccarrone
2010-09-24 16:00 ` Russell King - ARM Linux
2010-09-24 16:00 ` Russell King - ARM Linux
2010-09-24 16:11 ` Michał Mirosław
2010-09-24 16:11 ` Michał Mirosław
2010-09-24 22:52 ` Tony Lindgren
2010-09-24 22:52 ` Tony Lindgren
2010-09-30 18:42 ` Cory Maccarrone
2010-09-30 18:42 ` Cory Maccarrone
2010-09-30 18:48 ` Tony Lindgren
2010-09-30 18:48 ` Tony Lindgren
2010-09-30 18:53 ` Cory Maccarrone
2010-09-30 18:53 ` Cory Maccarrone
2010-09-30 19:05 ` Michał Mirosław
2010-09-30 19:05 ` Michał Mirosław
2010-09-30 19:15 ` Tony Lindgren [this message]
2010-09-30 19:15 ` Tony Lindgren
2010-09-30 22:11 ` Tony Lindgren
2010-09-30 22:11 ` Tony Lindgren
2010-11-25 15:23 ` Cory Maccarrone
2010-11-25 15:23 ` Cory Maccarrone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930191535.GM3117@atomide.com \
--to=tony@atomide.com \
--cc=darkstar6262@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mirqus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.